[Bug 17507] New: Scrollbars are inappropriately displayed in Ascentive Library Files installer
http://bugs.winehq.org/show_bug.cgi?id=17507
Summary: Scrollbars are inappropriately displayed in Ascentive Library Files installer Product: Wine Version: 1.1.15 Platform: PC URL: http://www.ascentive.com/support/new/libraryfiles.exe OS/Version: Linux Status: UNCONFIRMED Severity: trivial Priority: P2 Component: richedit AssignedTo: wine-bugs@winehq.org ReportedBy: arethusa26@gmail.com CC: dylan.ah.smith@gmail.com
Created an attachment (id=19614) --> (http://bugs.winehq.org/attachment.cgi?id=19614) Ascentive Library Files installer with bad commit
With today's Git (wine-1.1.15-221-g79cc416), some text areas of the Ascentive Library Files installer are drawn with scrollbars that should not be present. The issue was determined to be:
dc03b6b2f25cc4aa63ad2776943f55fd3f5aa656 is first bad commit commit dc03b6b2f25cc4aa63ad2776943f55fd3f5aa656 Author: Dylan Smith dylan.ah.smith@gmail.com Date: Fri Dec 19 08:15:04 2008 -0500
richedit: Removed redundant editor height variables and calculations.
During wrapping there were three different heights that were being stored, with only one of them being done correctly. The other ones failed to incorporate the height of the paragraph or row, so ended up being incorrect.
:040000 040000 63cbc79b51a8a40b8242ff5f261d55462ff7c209 805ff3ddce5185e0a30f4b5cc9b03db398f2bb93 M dlls
Wine built prior to the commit did not show the problem.
http://bugs.winehq.org/show_bug.cgi?id=17507
--- Comment #1 from Andrew Nguyen arethusa26@gmail.com 2009-02-22 17:00:16 --- Created an attachment (id=19615) --> (http://bugs.winehq.org/attachment.cgi?id=19615) Ascentive Library Files installer without bad commit
http://bugs.winehq.org/show_bug.cgi?id=17507
Andrew Nguyen arethusa26@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression
http://bugs.winehq.org/show_bug.cgi?id=17507
Dylan Smith dylan.ah.smith@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |ASSIGNED Ever Confirmed|0 |1
--- Comment #2 from Dylan Smith dylan.ah.smith@gmail.com 2009-02-24 01:43:17 --- The problem was the difference in the calculation used by SetScrollInfo and the richedit controls in calculating whether to hide or show the scrollbar. Specifically when the height of the text is the same as the height of the richedit control.
I sent a patch that fixes the bug to the wine-patches mailing list.
richedit: Fixed scrollbar visibility calculation after SetScrollInfo. (Bug 17507) http://www.winehq.org/pipermail/wine-patches/2009-February/069843.html
http://bugs.winehq.org/show_bug.cgi?id=17507
--- Comment #3 from Dylan Smith dylan.ah.smith@gmail.com 2009-02-24 11:26:32 --- (In reply to comment #2)
richedit: Fixed scrollbar visibility calculation after SetScrollInfo. (Bug 17507) http://www.winehq.org/pipermail/wine-patches/2009-February/069843.html
My patch that fixes the bug is in the git tree as commit 5f51221d9c1b94040ef354e7f62a0ce9a838cdab.
Please test and mark the bug as resolved if it works for you.
http://bugs.winehq.org/show_bug.cgi?id=17507
Andrew Nguyen arethusa26@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED
--- Comment #4 from Andrew Nguyen arethusa26@gmail.com 2009-02-25 04:40:40 --- Problem seems to be fixed, thanks.
http://bugs.winehq.org/show_bug.cgi?id=17507
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #5 from Alexandre Julliard julliard@winehq.org 2009-02-27 16:31:53 --- Closing bugs fixed in 1.1.16.
-
wine-bugs＠winehq.org