[Bug 21898] New: uTorrent 2.0 redraws the listview torrent progress indicator incorrectly

http://bugs.winehq.org/show_bug.cgi?id=21898

Summary: uTorrent 2.0 redraws the listview torrent progress
                    indicator incorrectly
           Product: Wine
           Version: 1.1.39
          Platform: x86
               URL: http://www.utorrent.com/downloads
        OS/Version: Linux
            Status: NEW
          Keywords: download, regression
          Severity: trivial
          Priority: P2
         Component: comctl32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

Created an attachment (id=26545)
 --> (http://bugs.winehq.org/attachment.cgi?id=26545)
uTorrent 2.0 +listview trace

In wine-1.1.39-163-g583f0f0, when moving the horizontal scrollbar of the
torrent listview in uTorrent 2.0, the torrent progress indicator doesn't move
correctly along with the other listview elements, but is instead redrawn in the
same location over the other elements. Regression testing indicated:

3cd15e5db5b9b89abbc3d5a7a16b62ce28eed153 is first bad commit
commit 3cd15e5db5b9b89abbc3d5a7a16b62ce28eed153
Author: Nikolay Sivov 
Date:   Fri May 29 01:35:36 2009 +0400

comctl32/listview: Don't offset subitem rectangles with item padding
returned by LVM_GETSUBITEMRECT.

:040000 040000 85aa1a9ccb92f30e8cc33386dfed7e48549f35ec
bd2bace8bb5080b042ea33b0271bf1db4cedc36f M    dlls

A +listview trace when moving the horizontal scrollbar is attached.

[Bug 21898] uTorrent 2.0 redraws the listview torrent progress indicator incorrectly

http://bugs.winehq.org/show_bug.cgi?id=21898

--- Comment #1 from Andrew Nguyen   2010-02-28 23:35:24 ---
Created an attachment (id=26546)
 --> (http://bugs.winehq.org/attachment.cgi?id=26546)
uTorrent 2.0 correct listview rendering

[Bug 21898] uTorrent 2.0 redraws the listview torrent progress indicator incorrectly

http://bugs.winehq.org/show_bug.cgi?id=21898

--- Comment #2 from Andrew Nguyen   2010-02-28 23:35:43 ---
Created an attachment (id=26547)
 --> (http://bugs.winehq.org/attachment.cgi?id=26547)
uTorrent 2.0 incorrect listview rendering

[Bug 21898] uTorrent 2.0 redraws the listview torrent progress indicator incorrectly

http://bugs.winehq.org/show_bug.cgi?id=21898

Alex Balut  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 21898] uTorrent 2.0 redraws the listview torrent progress indicator incorrectly

http://bugs.winehq.org/show_bug.cgi?id=21898

Dylan Smith  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Dylan Smith   2010-03-03 01:42:16 ---
I have submitted a patch that fixes the issue without breaking the tests that
the commit causing the regression fixed.

http://www.winehq.org/pipermail/wine-patches/2010-March/085454.html

The patch removes the unwanted padding from affecting the x position, but still
offsets the rect by the scroll x position.

[Bug 21898] uTorrent 2.0 redraws the listview torrent progress indicator incorrectly

http://bugs.winehq.org/show_bug.cgi?id=21898

--- Comment #4 from Dylan Smith   2010-03-03 11:29:04 ---
(In reply to comment #3)
> I have submitted a patch that fixes the issue without breaking the tests that
> the commit causing the regression fixed.
>
> http://www.winehq.org/pipermail/wine-patches/2010-March/085454.html

My patch was accepted as commit a7053ecc4c226dc6afc93ff129237ce9b78380b7.

Please confirm that this bug has been fixed, and if so mark is resolved.

[Bug 21898] uTorrent 2.0 redraws the listview torrent progress indicator incorrectly

http://bugs.winehq.org/show_bug.cgi?id=21898

Andrew Nguyen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Andrew Nguyen   2010-03-03 12:13:02 ---
Yes, the uTorrent rendering problem is fixed, thanks.

[Bug 21898] uTorrent 2.0 redraws the listview torrent progress indicator incorrectly

http://bugs.winehq.org/show_bug.cgi?id=21898

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard   2010-03-05 12:43:37 ---
Closing bugs fixed in 1.1.40.

[Bug 21898] uTorrent 2.0 redraws the listview torrent progress indicator incorrectly

http://bugs.winehq.org/show_bug.cgi?id=21898

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thephatness.wine@mailnull.c
                   |                            |om

--- Comment #7 from [e-mail]  2010-04-22 11:54:48 ---
I am still seeing the progress bar out of place when customizing the columns
and moving them around. For example, I have the columns in the order (Name,
Done, Size, Seeds......). If I enable the '#' column and place it in front of
Done, the progress bar is shifted.

1.1.43
Ubuntu Karmic 64

[Bug 21898] uTorrent 2.0 redraws the listview torrent progress indicator incorrectly

http://bugs.winehq.org/show_bug.cgi?id=21898

--- Comment #8 from Nikolay Sivov   2010-04-22 12:34:34 ---
(In reply to comment #7)
> I am still seeing the progress bar out of place when customizing the columns
> and moving them around. For example, I have the columns in the order (Name,
> Done, Size, Seeds......). If I enable the '#' column and place it in front of
> Done, the progress bar is shifted.
>
> 1.1.43
> Ubuntu Karmic 64

Open new bug for it with full description. It's most likely different problem.

[Bug 21898] uTorrent 2.0 redraws the listview torrent progress indicator incorrectly

http://bugs.winehq.org/show_bug.cgi?id=21898

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |a7053ecc4c226dc6afc93ff1292
                   |                            |37ce9b78380b7
    Regression SHA1|                            |3cd15e5db5b9b89abbc3d5a7a16
                   |                            |b62ce28eed153