[Bug 22280] New: Assassin's Creed: compatibility test app aborts when KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

Summary: Assassin's Creed: compatibility test app aborts when
                    KERNEL32.SetThreadPriorityBoost fails
           Product: Wine
           Version: 1.1.42
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Keywords: Installer
          Severity: normal
          Priority: P2
         Component: kernel32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

The Assassin's Creed installer runs 
Program Files/Ubisoft/Assassin's Creed/Detection/Detection.exe
at the end.  This is supposed to pop up a screen showing
whether various components of your system meet minimum spec for the game.
It crashes on wine after calling KERNEL32.SetThreadPriorityBoost.
That function always returns FALSE on wine.  Changing it to return TRUE
lets Detection.exe work properly.

[Bug 22280] Assassin's Creed: compatibility test app aborts when KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

--- Comment #1 from Dan Kegel   2010-04-05 12:33:35 ---
Created an attachment (id=27224)
 --> (http://bugs.winehq.org/attachment.cgi?id=27224)
Patch to make the stub return true, and fix two of the three test failures that
causes.

Can't quite submit to wine-patches because the test fails with
thread.c:711: Test failed: access restrictions not obeyed

[Bug 22280] Assassin's Creed: compatibility test app aborts when KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

Xavier Vachon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Xavier Vachon  2010-08-30 17:52:19 CDT ---
This is still an issue in current git (wine-1.3.1-320-g39b9814)

[Bug 22280] Assassin's Creed: compatibility test app aborts when KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #3 from Austin English  2011-01-17 17:53:58 CST ---
Still in wine-1.3.11-284-ge98a0e5.

[Bug 22280] Assassin's Creed: compatibility test app aborts when KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]

--- Comment #4 from Anastasius Focht  2011-10-14 15:03:39 CDT ---
Hello,

confirming, still present.

~/.wine/drive_c/Program Files/Ubisoft/Assassin's Creed/Detection$
WINEDEBUG=+tid,+seh,+relay wine ./Detection.exe >>log.txt 2>&1

--- snip ---
...
0024:Call
KERNEL32.CreateThread(00000000,00020000,7c3494f6,0056c430,00000004,0032eb68)
ret=7c3495f0
0024:Ret  KERNEL32.CreateThread() retval=000000c4 ret=7c3495f0
0024:Call KERNEL32.SetThreadPriority(000000c4,00000001) ret=00d29dc8
0024:Ret  KERNEL32.SetThreadPriority() retval=00000001 ret=00d29dc8
0024:Call KERNEL32.SetThreadPriorityBoost(000000c4,00000000) ret=00d29e1d
0024:Ret  KERNEL32.SetThreadPriorityBoost() retval=00000000 ret=00d29e1d
0024:Call ntdll.RtlAllocateHeap(00542000,00000000,00001000) ret=7c3416b3
0024:Ret  ntdll.RtlAllocateHeap() retval=0056e908 ret=7c3416b3
0024:Call KERNEL32.OutputDebugStringA(0032ea48
"\n\n..\..\..\src\thread\ms\thread.cpp(334) : ASSERT FAILURE: Ret()\n")
ret=00d2db73
0024:Ret  KERNEL32.OutputDebugStringA() retval=00000000 ret=00d2db73
0024:Call KERNEL32.DebugBreak() ret=00d2db79
0024:trace:seh:raise_exception code=80000003 flags=0 addr=0x7efa1094
ip=7efa1095 tid=0024
0024:trace:seh:raise_exception  eax=7ed2875d ebx=7efe3ff4 ecx=00112fb8
edx=00000000 esi=0032ea44 edi=00000000
0024:trace:seh:raise_exception  ebp=0032e9d0 esp=0032e9c4 cs=0073 ds=007b
es=007b fs=0033 gs=003b flags=00200256
0024:trace:seh:call_vectored_handlers calling handler at 0x7e0d2cf0
code=80000003 flags=0
0024:trace:seh:call_vectored_handlers handler at 0x7e0d2cf0 returned 0
...
......\src\thread\ms\thread.cpp(334) : ASSERT FAILURE: Ret()
wine: Unhandled exception 0x80000003 at address 0x7efa1094 (thread 0009),
starting debugger...
--- snip ---

$ wine --version
wine-1.3.30-152-g0096373

Regards

[Bug 22280] Assassin's Creed: compatibility test app aborts when KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
                 CC|                            |[e-mail]

--- Comment #5 from André H.  2011-11-22 13:55:12 CST ---
fixing status, i doubt that should be assigned to AF

[Bug 22280] Assassin's Creed: compatibility test app aborts when KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

--- Comment #6 from [e-mail] 2012-02-20 11:16:02 CST ---
Created attachment 38989
  --> http://bugs.winehq.org/attachment.cgi?id=38989
Testcase

Test case that makes SetThreadPriorityBoost fail,but works on windows

[Bug 22280] Assassin's Creed: compatibility test app aborts when KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 22280] Assassin's Creed: compatibility test app aborts when KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

--- Comment #7 from [e-mail] 2012-07-27 13:58:49 CDT ---
This affects also Splinter Cell Conviction , it causes assert fail at start

[Bug 22280] Splinter Cell Conviction fails at startup because KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Assassin's Creed:           |Splinter Cell Conviction
                   |compatibility test app      |fails at startup because
                   |aborts when                 |KERNEL32.SetThreadPriorityB
                   |KERNEL32.SetThreadPriorityB |oost fails
                   |oost fails                  |

--- Comment #8 from Dan Kegel  2012-08-13 12:50:52 CDT ---
I haven't tested Splinter Cell Conviction, so I'll take your word for it.
Adjusting summary to list the app that's more seriously affected.

[Bug 22280] Splinter Cell Conviction fails at startup because KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

Berillions  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Berillions  2012-08-13 14:26:15 CDT ---
(In reply to comment #8)
> I haven't tested Splinter Cell Conviction, so I'll take your word for it.
> Adjusting summary to list the app that's more seriously affected.

Dan, i confirm SC Conviction. Works with your hack.

[Bug 22280] Splinter Cell Conviction fails at startup because KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

Jonathan Strander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Jonathan Strander  2012-10-07 21:29:56 CDT ---
The patch Dan posted in comment 1 solves Bug 31866 (which means it's a
duplicate). The game (I Am Alive) crashes after a few seconds of play but I
doubt it's related.

[Bug 22280] Splinter Cell Conviction fails at startup because KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

felix moreno  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from felix moreno  2012-11-05 04:47:02 CST ---
Still fails. I tried wine Detection.exe and optirun wine Detection.exe both
crashes.

[Bug 22280] Splinter Cell Conviction fails at startup because KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Bruno Jesus  2012-11-07 12:15:09 CST ---
*** Bug 31866 has been marked as a duplicate of this bug. ***

[Bug 22280] Splinter Cell Conviction fails at startup because KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

--- Comment #13 from Andrey Gusev  2012-11-07 15:25:50 CST ---
Who knows, when this patch will be built-in. Any dates?

[Bug 22280] Splinter Cell Conviction fails at startup because KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

--- Comment #14 from Dan Kegel  2012-11-07 16:17:37 CST ---
I'm not working on it at the moment, feel free to run with it.

[Bug 22280] Splinter Cell Conviction fails at startup because KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

--- Comment #15 from Berillions  2012-12-07 10:01:36 CST ---
Affect FarCry 3 too.
The game works with hack + wine 1.5.18

[Bug 22280] Splinter Cell Conviction fails at startup because KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

Fael Mc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from Fael Mc  2012-12-17 16:55:48 CST ---
I managed to run (I am alive) here.
The game is very slow, but it opens smoothly and I can play.
I used wine 5.1.19 + patch, Dan Kegel posted in comment 1. 
http://bugs.winehq.org/show_bug.cgi?id=22280#c1

Thank you friends.

[Bug 22280] Splinter Cell Conviction fails at startup because KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

--- Comment #17 from Andrey Gusev  2013-01-21 15:59:21 CST ---
Still waiting for committing a patch. Please.

[Bug 22280] Splinter Cell Conviction fails at startup because KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

--- Comment #18 from Andrey Gusev  2013-05-22 11:42:54 CDT ---
Continues on 1.5.30

[Bug 22280] Splinter Cell Conviction fails at startup because KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

Vincent Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #19 from Vincent Povirk  2013-05-23 14:51:30 CDT ---
*** Bug 32244 has been marked as a duplicate of this bug. ***

[Bug 22280] Splinter Cell Conviction fails at startup because KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

--- Comment #20 from Berillions  2013-05-26 11:36:25 CDT ---
*** Bug 30671 has been marked as a duplicate of this bug. ***

[Bug 22280] Splinter Cell Conviction fails at startup because KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

--- Comment #21 from Bruno Jesus  2013-05-28 15:21:44 CDT ---
Patch commited:
http://source.winehq.org/git/wine.git/?a=commit;h=073d7212a765ec5c4eff3fbf0e...

[Bug 22280] Splinter Cell Conviction fails at startup because KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #22 from Austin English  2013-05-28 20:42:50 CDT ---
(In reply to comment #21)
> Patch commited:
> http://source.winehq.org/git/wine.git/?a=commit;h=073d7212a765ec5c4eff3fbf0e...

The system spec dialog shows up fine in wine-1.5.31-42-g97f501b

[Bug 22280] Splinter Cell Conviction fails at startup because KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #23 from Alexandre Julliard  2013-06-07 15:01:44 CDT ---
Closing bugs fixed in 1.6-rc1.

[Bug 22280] Splinter Cell Conviction fails at startup because KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #24 from Bruno Jesus  2013-06-22 12:34:14 CDT ---
*** Bug 32801 has been marked as a duplicate of this bug. ***

[Bug 22280] Splinter Cell Conviction fails at startup because KERNEL32.SetThreadPriorityBoost fails

https://bugs.winehq.org/show_bug.cgi?id=22280

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |073d7212a765ec5c4eff3fbf0eb
                   |                            |e553462892fa4

[Bug 22280] Splinter Cell Conviction fails at startup because KERNEL32.SetThreadPriorityBoost fails

http://bugs.winehq.org/show_bug.cgi?id=22280

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #25 from Anastasius Focht  ---
*** Bug 36502 has been marked as a duplicate of this bug. ***