[Bug 44914] New: Wrong cursor for IDC_SIZEWE

https://bugs.winehq.org/show_bug.cgi?id=44914

Bug ID: 44914
           Summary: Wrong cursor for IDC_SIZEWE
           Product: Wine
           Version: 3.5
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: winex11.drv
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Download the BCG demo's.

Run BCGPGanttDemo.exe

In the right hand pane, place the cursor at the end of an item.  The cursor
should be a icon with two arrows.

[Bug 44914] Wrong cursor for IDC_SIZEWE

https://bugs.winehq.org/show_bug.cgi?id=44914

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://www.bcgsoft.com/down
                   |                            |load.htm
           Keywords|                            |download, regression
    Regression SHA1|                            |9b2b9d9cb3929b17236cbedac5b
                   |                            |b4ad4333e264f

[Bug 44914] Wrong cursor for IDC_SIZEWE

https://bugs.winehq.org/show_bug.cgi?id=44914

--- Comment #1 from Dmitry Timoshkov  ---
Created attachment 60998
  --> https://bugs.winehq.org/attachment.cgi?id=60998
patch

I guess that Alexandre's intention was to make cursor names use conservative
and more backwards compatible naming scheme. Attached patch uses h_double_arrow
and v_double_arrow for WE/NS mouse pointers and should fix the regression.

[Bug 44914] Wrong cursor for IDC_SIZEWE

https://bugs.winehq.org/show_bug.cgi?id=44914

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://www.bcgsoft.com/down |http://www.bcgsoft.com/down
                   |load.htm                    |load/BCGControlBarProDemo.z
                   |                            |ip

[Bug 44914] Wrong cursor for IDC_SIZEWE

https://bugs.winehq.org/show_bug.cgi?id=44914

--- Comment #2 from Dmitry Timoshkov  ---
Warning: the demo needs mfc42.dll to run.

[Bug 44914] Wrong cursor for IDC_SIZEWE

https://bugs.winehq.org/show_bug.cgi?id=44914

--- Comment #3 from Alistair Leslie-Hughes  ---
(In reply to Dmitry Timoshkov from comment #1)
> Created attachment 60998 [details]
> patch
>
> I guess that Alexandre's intention was to make cursor names use conservative
> and more backwards compatible naming scheme. Attached patch uses
> h_double_arrow
> and v_double_arrow for WE/NS mouse pointers and should fix the regression.

Thanks Dmitry, that's fixed it.

Did you want to upstream it?  Or should I (You OK for me to you use as the
author?)

[Bug 44914] Wrong cursor for IDC_SIZEWE

https://bugs.winehq.org/show_bug.cgi?id=44914

--- Comment #4 from Dmitry Timoshkov  ---
(In reply to Alistair Leslie-Hughes from comment #3)
> Thanks Dmitry, that's fixed it.
>
> Did you want to upstream it?  Or should I (You OK for me to you use as the
> author?)

Sure, go ahead.

[Bug 44914] Wrong cursor for IDC_SIZEWE

https://bugs.winehq.org/show_bug.cgi?id=44914

Giacomo Orlandi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Giacomo Orlandi  ---
I guess this is fixed by
https://source.winehq.org/git/wine.git/commit/508ad84bbef725676f2aab8fbf0e53...
?

[Bug 44914] Wrong cursor for IDC_SIZEWE

https://bugs.winehq.org/show_bug.cgi?id=44914

--- Comment #6 from Alistair Leslie-Hughes  ---
(In reply to Giacomo Orlandi from comment #5)
> I guess this is fixed by
> https://source.winehq.org/git/wine.git/commit/
> 508ad84bbef725676f2aab8fbf0e532fd97eb398 ?

No, the cursor is still incorrect.  
On Mint, I get a |<- cursor instead of <--> cursor.

[Bug 44914] Wrong cursor for IDC_SIZEWE

https://bugs.winehq.org/show_bug.cgi?id=44914

--- Comment #7 from Alexandre Julliard  ---
I suppose we could try the fallbacks in a different order. Do size_hor and
ew-resize also work for you, or only h_double_arrow?

[Bug 44914] Wrong cursor for IDC_SIZEWE

https://bugs.winehq.org/show_bug.cgi?id=44914

--- Comment #8 from Alistair Leslie-Hughes  ---
(In reply to Alexandre Julliard from comment #7)
> I suppose we could try the fallbacks in a different order. Do size_hor and
> ew-resize also work for you, or only h_double_arrow?

Only "left_side" fails.  All the other values work as expected.

Are you sure we need left_side? That cursor for me is used when resizing a
dialog to the left.

[Bug 44914] Wrong cursor for IDC_SIZEWE

https://bugs.winehq.org/show_bug.cgi?id=44914

--- Comment #9 from Alexandre Julliard  ---
I added left_side because it already has a fallback in the X cursor font, but
we could add a fallback for some other one instead.

[Bug 44914] Wrong cursor for IDC_SIZEWE

https://bugs.winehq.org/show_bug.cgi?id=44914

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |c102efbc3522f5954d6150296c1
                   |                            |4dedfc7fe5fb7
             Status|NEW                         |RESOLVED

--- Comment #10 from Alistair Leslie-Hughes  ---
Fixed by
https://source.winehq.org/git/wine.git/?a=commit;h=c102efbc3522f5954d6150296...

[Bug 44914] Wrong cursor for IDC_SIZEWE

https://bugs.winehq.org/show_bug.cgi?id=44914

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #11 from Alexandre Julliard  ---
Closing bugs fixed in 3.8.