[Bug 13867] New: WinSCP: Background transfer queue doesn't refresh/update automatically

http://bugs.winehq.org/show_bug.cgi?id=13867

Summary: WinSCP: Background transfer queue doesn't refresh/update
                    automatically
           Product: Wine
           Version: 1.0-rc4
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

When using the "Transfer on background by default" option in the "Preferences
-> Transfer -> Background" page, the background transfer box does not
automatically refresh itself as it should.

To get the box to update you must manually click one of the current downloads
to get updated information on the transfer. This information will remain static
until the next time you click an entry again.

I have experienced this behavior on Xubuntu 8.04 i386 and Ubuntu 8.04 x86_64.

You can download WinSCP for free at the following URL:
http://winscp.net/eng/download.php

[Bug 13867] WinSCP: Background transfer queue doesn't refresh/update automatically (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=13867

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://winscp.net/eng/downlo
                   |                            |ad.php
           Keywords|                            |download
            Summary|WinSCP: Background transfer |WinSCP: Background transfer
                   |queue doesn't refresh/update|queue doesn't refresh/update
                   |automatically               |automatically (dogfood)

[Bug 13867] WinSCP: Background transfer queue doesn't refresh/update automatically (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=13867

--- Comment #1 from James Munro   2008-07-02 15:42:12 ---
I emailed the author of WinSCP about the API used to redraw the display. He has
sent me the following information, I hope that this is useful for Wine
developers in getting the bug solved:

"Hello James,

I'm using Borland VCL library for WinSCP GUI.
I've tracked down to its code that uses following WinAPI call to update
elements of list view (queue list):

ListView_SetItemText(Handle, Item, SubItem, LPSTR_TEXTCALLBACK);

The LPSTR_TEXTCALLBACK maybe the less-known API.

I hope this helps. Have a nice day.

Martin."

[Bug 13867] WinSCP: Background transfer queue doesn't refresh/update automatically (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=13867

James Munro  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |comctl32
            Version|1.0-rc4                     |1.1.1

--- Comment #2 from James Munro   2008-07-12 05:54:17 ---
Bug is still present in Wine v1.1.1; However, I have found another way to
manually refresh the list view. Minimize and maximize the WinSCP window and the
elements contained inside will have refreshed to the point of you maximizing
the window.

[Bug 13867] WinSCP: Background transfer queue doesn't refresh/update automatically (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=13867

James Hawkins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.1.1                       |1.0-rc4

--- Comment #3 from James Hawkins   2008-07-12 09:38:56 ---
Don't change the original reported version.

[Bug 13867] WinSCP: Background transfer queue doesn't refresh/update automatically (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=13867

--- Comment #4 from Lei Zhang   2008-07-14 13:55:27 ---
Does native comctl32.dll make the bug go away?

[Bug 13867] WinSCP: Background transfer queue doesn't refresh/update automatically (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=13867

--- Comment #5 from James Munro   2008-07-14 14:31:13 ---
Unfortunately I'm having trouble making anything work when trying to use the
native comctl32.dll, It always needs some other DLL and I end up going round in
circles.

Could someone else try who has better experience with the overrides? WinSCP is
a free download and there is a portable version for those who don't want to
install.

[Bug 13867] WinSCP: Background transfer queue doesn't refresh/update automatically (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=13867

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #6 from Lei Zhang   2008-07-15 18:50:07 ---
Confirmed with Wine 1.1.1. Native comctl32 fixes it, though it causes a bunch
of other problems.

[Bug 13867] WinSCP: Background transfer queue doesn't refresh/update automatically (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=13867

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source

--- Comment #7 from Lei Zhang   2008-07-15 19:55:44 ---
Wine seems to handle LPSTR_TEXTCALLBACK just fine. I wonder if BlinkHide is
getting set to the right value in windows/QueueController.cpp?

[Bug 13867] WinSCP: Background transfer queue doesn't refresh/update automatically (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=13867

--- Comment #8 from GameZelda   2008-12-23 01:10:49 ---
Created an attachment (id=18138)
 --> (http://bugs.winehq.org/attachment.cgi?id=18138)
Source code affected by this bug

[Bug 13867] WinSCP: Background transfer queue doesn't refresh/update automatically (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=13867

GameZelda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from GameZelda   2008-12-23 01:12:30 ---
I've assigned this bug to Hex Workshop too.

The problem is that ListView_SetItemText() with LPSTR_TEXTCALLBACK doesn't
update the window.

I've attached a source code sample affected by this bug. Under Windows, the
text "Update 1" and "Update 2" changes automatically every 1 second, but under
Wine it doesn't change until you force Wine to do it (click item, move window,
etc.).

[Bug 13867] WinSCP: Background transfer queue doesn't refresh/update automatically (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=13867

--- Comment #10 from GameZelda   2008-12-23 03:17:53 ---
I've found a solution for the problem (at least for Hex Workshop and the test
application). Can someone test if it also works with WinSPC?

(Based on Wine 1.1.11 source):

File: dll/comctl32/listview.c

LINE 527:
FROM: return bt == LPSTR_TEXTCALLBACKW ? 0 : -1;
TO: return bt == LPSTR_TEXTCALLBACKW ? 1 : -1;

Line 3621:
FROM: if (lpSubItem->hdr.pszText != lpLVItem->pszText)
TO: if (textcmpWT(lpSubItem->hdr.pszText, lpLVItem->pszText, isW))

Thanks.

[Bug 13867] WinSCP: Background transfer queue doesn't refresh/update automatically (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=13867

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch, testcase

[Bug 13867] WinSCP: Background transfer queue doesn't refresh/update automatically (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=13867

Stefan Stranz  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Stefan Stranz   2009-04-29 14:44:32 ---
(In reply to comment #10)
> I've found a solution for the problem (at least for Hex Workshop and the test
> application). Can someone test if it also works with WinSPC?
>
> (Based on Wine 1.1.11 source):
>
> File: dll/comctl32/listview.c
>
> LINE 527:
> FROM: return bt == LPSTR_TEXTCALLBACKW ? 0 : -1;
> TO: return bt == LPSTR_TEXTCALLBACKW ? 1 : -1;
>
> Line 3621:
> FROM: if (lpSubItem->hdr.pszText != lpLVItem->pszText)
> TO: if (textcmpWT(lpSubItem->hdr.pszText, lpLVItem->pszText, isW))
>
> Thanks.

Tested these changes on current git. Fixed the queue not updating in WinSCP.
Attaching a patch file.

[Bug 13867] WinSCP: Background transfer queue doesn't refresh/update automatically (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=13867

--- Comment #12 from Stefan Stranz   2009-04-29 14:46:17 ---
Created an attachment (id=20818)
 --> (http://bugs.winehq.org/attachment.cgi?id=20818)
Patch to fix queue not updating in WinSCP

[Bug 13867] WinSCP: Background transfer queue doesn't refresh/update automatically (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=13867

--- Comment #13 from Nikolay Sivov   2009-06-14 17:39:07 ---
Updated patch sent:

http://www.winehq.org/pipermail/wine-patches/2009-June/074221.html

[Bug 13867] WinSCP: Background transfer queue doesn't refresh/update automatically (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=13867

--- Comment #14 from Nikolay Sivov   2009-06-15 08:07:34 ---
Patch committed:

http://source.winehq.org/git/wine.git/?a=commit;h=7f936a0a6e83538df792952817...

Test again with current.

[Bug 13867] WinSCP: Background transfer queue doesn't refresh/update automatically (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=13867

--- Comment #15 from Nikolay Sivov   2009-06-21 07:12:09 ---
James, test with 1.1.24. It should be solved.

[Bug 13867] WinSCP: Background transfer queue doesn't refresh/update automatically (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=13867

--- Comment #16 from Nikolay Sivov   2009-07-05 11:57:07 ---
(In reply to comment #15)
> James, test with 1.1.24. It should be solved.

Same request, try with 1.1.25.

[Bug 13867] WinSCP: Background transfer queue doesn't refresh/update automatically (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=13867

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #17 from Austin English   2009-07-19 16:46:45 ---
Works fine for me in 1.1.26.

[Bug 13867] WinSCP: Background transfer queue doesn't refresh/update automatically (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=13867

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #18 from Alexandre Julliard   2009-08-07 12:25:15 ---
Closing bugs fixed in 1.1.27.