[Bug 42463] New: ZmLearn crash at startup: "Assertion 'm->state == STATE_PASSIVE' failed at pulse/mainloop.c:787, function pa_mainloop_prepare(). Aborting."

https://bugs.winehq.org/show_bug.cgi?id=42463

Bug ID: 42463
           Summary: ZmLearn crash at startup: "Assertion 'm->state ==
                    STATE_PASSIVE' failed at pulse/mainloop.c:787,
                    function pa_mainloop_prepare(). Aborting."
           Product: Wine
           Version: 2.1
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: winepulse.drv
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 57309
  --> https://bugs.winehq.org/attachment.cgi?id=57309
Log with pulse,tid,pid channel.

reproduce:
1. Setting Windows version as XP and install it.
2. $ cd .wine/drive_c/users/USER_NAME/Application\ Data/ZmLearn
3. $ wine ZmClient.exe
then it will crash.

I find this patch from staging can fix it:
https://github.com/wine-compholio/wine-staging/blob/master/patches/winepulse...

Wine version: wine-2.1-285-gd00f7315e0

[Bug 42463] ZmLearn crash at startup: "Assertion 'm->state == STATE_PASSIVE' failed at pulse/mainloop.c:787, function pa_mainloop_prepare(). Aborting."

https://bugs.winehq.org/show_bug.cgi?id=42463

Jactry Zeng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://ojc93nz4u.qnssl.com
                   |                            |/ZmLearnClient.exe
           Keywords|                            |download, Installer
                 CC|                            |[e-mail]

[Bug 42463] ZmLearn crash at startup: "Assertion 'm->state == STATE_PASSIVE' failed at pulse/mainloop.c:787, function pa_mainloop_prepare(). Aborting."

https://bugs.winehq.org/show_bug.cgi?id=42463

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Sebastian Lackner  ---
(In reply to Jactry Zeng from comment #0)
> I find this patch from staging can fix it:
> https://github.com/wine-compholio/wine-staging/blob/master/patches/winepulse...
> PulseAudio_Support/0001-winepulse.drv-Use-a-separate-mainloop-and-ctx-for-pu.
> patch

Based on the log it looks like AUDDRV_GetPriority is called from two different
threads. Although this works with the patch, it shouldn't really happen in the
first place. The real component is probably mmdevapi.

@Andrew: Should the driver initialization be moved to a init-once section, or
what is your suggestion?

[Bug 42463] ZmLearn crash at startup: "Assertion 'm->state == STATE_PASSIVE' failed at pulse/mainloop.c:787, function pa_mainloop_prepare(). Aborting."

https://bugs.winehq.org/show_bug.cgi?id=42463

--- Comment #2 from Sebastian Lackner  ---
Created attachment 57310
  --> https://bugs.winehq.org/attachment.cgi?id=57310
Proposed patch.

@Jactry: Could you please test that this patch fixes the issue?

[Bug 42463] ZmLearn crash at startup: "Assertion 'm->state == STATE_PASSIVE' failed at pulse/mainloop.c:787, function pa_mainloop_prepare(). Aborting."

https://bugs.winehq.org/show_bug.cgi?id=42463

--- Comment #3 from Jactry Zeng  ---
(In reply to Sebastian Lackner from comment #2)
> Created attachment 57310 [details]
> Proposed patch.
>
> @Jactry: Could you please test that this patch fixes the issue?

Yes, it can fix this bug.

[Bug 42463] ZmLearn crash at startup: "Assertion 'm->state == STATE_PASSIVE' failed at pulse/mainloop.c:787, function pa_mainloop_prepare(). Aborting."

https://bugs.winehq.org/show_bug.cgi?id=42463

--- Comment #4 from Andrew Eikum  ---
(In reply to Sebastian Lackner from comment #2)
> Created attachment 57310 [details]
> Proposed patch.
>
> @Jactry: Could you please test that this patch fixes the issue?

I'm not opposed to this, but I don't understand why calling the init function
twice would cause the assertion failure. It's protected by a mutex, so they
should run in series, and we completely clean up when pulse_test_connect exits.

(See also Bug 40147 and Bug 41102.)

[Bug 42463] ZmLearn crash at startup: "Assertion 'm->state == STATE_PASSIVE' failed at pulse/mainloop.c:787, function pa_mainloop_prepare(). Aborting."

https://bugs.winehq.org/show_bug.cgi?id=42463

Jactry Zeng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |db0518507a595fbad33e47c1afe
                   |                            |54edcf6a50b5d

--- Comment #5 from Jactry Zeng  ---
Fixed by
http://source.winehq.org/git/wine.git/?a=commit;h=db0518507a595fbad33e47c1af...
.

Thanks Sebastian! Thanks Andrew!

[Bug 42463] ZmLearn crash at startup: "Assertion 'm->state == STATE_PASSIVE' failed at pulse/mainloop.c:787, function pa_mainloop_prepare(). Aborting."

https://bugs.winehq.org/show_bug.cgi?id=42463

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 2.3.

[Bug 42463] ZmLearn crash at startup: "Assertion 'm->state == STATE_PASSIVE' failed at pulse/mainloop.c:787, function pa_mainloop_prepare(). Aborting."

https://bugs.winehq.org/show_bug.cgi?id=42463

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.0.x
                 CC|                            |[e-mail]

[Bug 42463] ZmLearn crash at startup: "Assertion 'm->state == STATE_PASSIVE' failed at pulse/mainloop.c:787, function pa_mainloop_prepare(). Aborting."

https://bugs.winehq.org/show_bug.cgi?id=42463

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|2.0.x                       |---

--- Comment #7 from Michael Stefaniuc  ---
Removing the 2.0.x milestone from bugs included in 2.0.2.