[Bug 31604] New: Steam: Windows can not be closed, they are always opened again (regression)

http://bugs.winehq.org/show_bug.cgi?id=31604

Bug #: 31604
           Summary: Steam: Windows can not be closed, they are always
                    opened again (regression)
           Product: Wine
           Version: 1.5.12
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: user32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
    Classification: Unclassified
   Regression SHA1: d35fc4369fd9eb7e5fca78cc0d61e241de286ee0

Using wine 1.5.12, closing a window in Steam immediately re-opens the window. I
have not used Steam with wine for more than a year, and remember that the bug
was already present back then, but according to this bug it was fixed in the
mean time:
http://bugs.winehq.org/show_bug.cgi?id=23872

And indeed, going back to wine 1.5.11 fixed the problem. I did a regression
test, with the following result:

d35fc4369fd9eb7e5fca78cc0d61e241de286ee0 is the first bad commit
commit d35fc4369fd9eb7e5fca78cc0d61e241de286ee0
Author: Alexandre Julliard 
Date:   Wed Aug 29 18:08:37 2012 +0200

user32: Always go through set_window_pos when the WS_VISIBLE style is
changed.

:040000 040000 2181c83f9671eb18ffb3538e627cce5d2b0bf7e0
cdf5240aa47f26a98421467c50979a84b60c68e7 M      dlls

I verified that reverting this commit indeed fixes the problem.

[Bug 31604] Steam: Windows can not be closed, they are always opened again

http://bugs.winehq.org/show_bug.cgi?id=31604

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression
            Summary|Steam: Windows can not be   |Steam: Windows can not be
                   |closed, they are always     |closed, they are always
                   |opened again (regression)   |opened again

[Bug 31604] Steam: Windows can not be closed, they are always opened again

http://bugs.winehq.org/show_bug.cgi?id=31604

byteframe  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from byteframe  2012-09-03 12:19:37 CDT ---
from 1.5.11 to 1.5.12 I now experience this problem. WE is metacity running on
XFCE 4.6.

[Bug 31604] Steam: Windows can not be closed, they are always opened again

http://bugs.winehq.org/show_bug.cgi?id=31604

--- Comment #2 from Austin English  2012-09-04 13:00:03 CDT ---
Should be fixed by
http://source.winehq.org/git/wine.git/commitdiff/2dc234d923b70fa0a0e1815d909....
Please retest.

[Bug 31604] Steam: Windows can not be closed, they are always opened again

http://bugs.winehq.org/show_bug.cgi?id=31604

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from [e-mail] 2012-09-04 14:34:36 CDT ---
That's looking good, thanks a lot :)

[Bug 31604] Steam: Windows can not be closed, they are always opened again

http://bugs.winehq.org/show_bug.cgi?id=31604

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |2dc234d923b70fa0a0e1815d909
                   |                            |035d059aa8772

[Bug 31604] Steam: Windows can not be closed, they are always opened again

http://bugs.winehq.org/show_bug.cgi?id=31604

Philipp Richter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Philipp Richter  2012-09-13 07:10:25 CDT ---
Using latest git version, commit 92ad0a47fafaf92e4819a0229cc9fe71f5318734.
I still get the issue with the windows not closing in Steam. Sometimes it takes
switching from Library to Store for instance to close an open window
successfully, and other times it only works after several tries.

[Bug 31604] Steam: Windows can not be closed, they are always opened again

http://bugs.winehq.org/show_bug.cgi?id=31604

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  2012-09-14 13:34:29 CDT ---
Closing bugs fixed in 1.5.13.