[Bug 40680] New: Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

Bug ID: 40680
           Summary: Rocket league needs
                    bcrypt.dll.BCryptGenerateSymmetricKey
           Product: Wine
           Version: 1.9.10
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: bcrypt
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 54554
  --> https://bugs.winehq.org/attachment.cgi?id=54554
bcrypt patch

Latest Steam update of Rocket League prevents it to run with wine. The game
exits early with this message:
 wine: Call from 0x7b43cf4c to unimplemented function
bcrypt.dll.BCryptGenerateSymmetricKey, aborting

This can be fixed by implementing the missing symbol and making it return 0.
Seems to be enough for now.

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

Maxime  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
       Distribution|---                         |ArchLinux

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

Robin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Robin  ---
Hello Maxime, and thank you for posting a solution to the problem !

But I'm kind of new with wine and playonlinux, how do I modify these 3
differents files? 
I'm playing RocketLeague with PoL and I found bcrypt.dll in 
~/PlayOnLinux's virtual drives/rocketleague/dosdevices/c:/windows/system32
but I can't find anything about bcrypt.h, bcrypt_main.c nor bcrypt.spec

Can you help me ?
Thank you again

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

Søren  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Søren  ---
(In reply to Maxime from comment #0)
> Created attachment 54554 [details]
> bcrypt patch
>
> Latest Steam update of Rocket League prevents it to run with wine. The game
> exits early with this message:
>  wine: Call from 0x7b43cf4c to unimplemented function
> bcrypt.dll.BCryptGenerateSymmetricKey, aborting
>
> This can be fixed by implementing the missing symbol and making it return 0.
> Seems to be enough for now.

I applied the patch which fixed the issue for starting the game. Entering a
competitive game resulted in these errors:

fixme:bcrypt:BCryptOpenAlgorithmProvider algorithm L"AES" not supported
wine: Call from 0x7b43cf7c to unimplemented function bcrypt.dll.BCryptEncrypt,
aborting

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

--- Comment #3 from Maxime  ---
(In reply to Søren from comment #2)
> (In reply to Maxime from comment #0)
> > Created attachment 54554 [details]
> > bcrypt patch
> >
> > Latest Steam update of Rocket League prevents it to run with wine. The game
> > exits early with this message:
> >  wine: Call from 0x7b43cf4c to unimplemented function
> > bcrypt.dll.BCryptGenerateSymmetricKey, aborting
> >
> > This can be fixed by implementing the missing symbol and making it return 0.
> > Seems to be enough for now.
>
> I applied the patch which fixed the issue for starting the game. Entering a
> competitive game resulted in these errors:
>
> fixme:bcrypt:BCryptOpenAlgorithmProvider algorithm L"AES" not supported
> wine: Call from 0x7b43cf7c to unimplemented function
> bcrypt.dll.BCryptEncrypt, aborting

Oups, we may have to go a bit further...

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

bean  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

--- Comment #4 from Maxime  ---
(In reply to Robin from comment #1)
> Hello Maxime, and thank you for posting a solution to the problem !
>
> But I'm kind of new with wine and playonlinux, how do I modify these 3
> differents files? 
> I'm playing RocketLeague with PoL and I found bcrypt.dll in 
> ~/PlayOnLinux's virtual drives/rocketleague/dosdevices/c:/windows/system32
> but I can't find anything about bcrypt.h, bcrypt_main.c nor bcrypt.spec
>
> Can you help me ?
> Thank you again

It is a patch to apply against the source. To test my fix, I recompiled wine.
What distribution are you using?

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

--- Comment #5 from Robin  ---
(In reply to Maxime from comment #4)
> (In reply to Robin from comment #1)
> > Hello Maxime, and thank you for posting a solution to the problem !
> >
> > But I'm kind of new with wine and playonlinux, how do I modify these 3
> > differents files? 
> > I'm playing RocketLeague with PoL and I found bcrypt.dll in 
> > ~/PlayOnLinux's virtual drives/rocketleague/dosdevices/c:/windows/system32
> > but I can't find anything about bcrypt.h, bcrypt_main.c nor bcrypt.spec
> >
> > Can you help me ?
> > Thank you again
>
> It is a patch to apply against the source. To test my fix, I recompiled
> wine. What distribution are you using?

Oh all right, so I should only get the wine sources and make/make-install ?
I'm on Fedora 23.

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

--- Comment #6 from Maxime  ---
(In reply to Robin from comment #5)
> (In reply to Maxime from comment #4)
> > (In reply to Robin from comment #1)
> > > Hello Maxime, and thank you for posting a solution to the problem !
> > >
> > > But I'm kind of new with wine and playonlinux, how do I modify these 3
> > > differents files? 
> > > I'm playing RocketLeague with PoL and I found bcrypt.dll in 
> > > ~/PlayOnLinux's virtual drives/rocketleague/dosdevices/c:/windows/system32
> > > but I can't find anything about bcrypt.h, bcrypt_main.c nor bcrypt.spec
> > >
> > > Can you help me ?
> > > Thank you again
> >
> > It is a patch to apply against the source. To test my fix, I recompiled
> > wine. What distribution are you using?
>
> Oh all right, so I should only get the wine sources and make/make-install ?
> I'm on Fedora 23.

I am not familiar with Fedora, but I guess the easiest would be to get wine
source RPM for version 1.9.10, apply the patch, compile and generate your RPM.
But this will only allow you to run the game and play solo, not multiplayer.

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

--- Comment #7 from Robin  ---
(In reply to Maxime from comment #6)
> (In reply to Robin from comment #5)
> > (In reply to Maxime from comment #4)
> > > (In reply to Robin from comment #1)
> > > > Hello Maxime, and thank you for posting a solution to the problem !
> > > >
> > > > But I'm kind of new with wine and playonlinux, how do I modify these 3
> > > > differents files? 
> > > > I'm playing RocketLeague with PoL and I found bcrypt.dll in 
> > > > ~/PlayOnLinux's virtual drives/rocketleague/dosdevices/c:/windows/system32
> > > > but I can't find anything about bcrypt.h, bcrypt_main.c nor bcrypt.spec
> > > >
> > > > Can you help me ?
> > > > Thank you again
> > >
> > > It is a patch to apply against the source. To test my fix, I recompiled
> > > wine. What distribution are you using?
> >
> > Oh all right, so I should only get the wine sources and make/make-install ?
> > I'm on Fedora 23.
>
> I am not familiar with Fedora, but I guess the easiest would be to get wine
> source RPM for version 1.9.10, apply the patch, compile and generate your
> RPM. But this will only allow you to run the game and play solo, not
> multiplayer.

Thank you for the reply ! I'll try it and let you know :)

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Keywords|                            |patch

--- Comment #8 from Austin English  ---
(In reply to Maxime from comment #0)
> Created attachment 54554 [details]
> bcrypt patch
>
> Latest Steam update of Rocket League prevents it to run with wine. The game
> exits early with this message:
>  wine: Call from 0x7b43cf4c to unimplemented function
> bcrypt.dll.BCryptGenerateSymmetricKey, aborting
>
> This can be fixed by implementing the missing symbol and making it return 0.
> Seems to be enough for now.

Please add a FIXME to the function body (and a space between dwFlags and the
closing parenthesis in the prototype), and submit to wine-patches.  Patches are
not picked up from bugzilla.

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

--- Comment #9 from Maxime  ---
(In reply to Austin English from comment #8)
> (In reply to Maxime from comment #0)
> > Created attachment 54554 [details]
> > bcrypt patch
> >
> > Latest Steam update of Rocket League prevents it to run with wine. The game
> > exits early with this message:
> >  wine: Call from 0x7b43cf4c to unimplemented function
> > bcrypt.dll.BCryptGenerateSymmetricKey, aborting
> >
> > This can be fixed by implementing the missing symbol and making it return 0.
> > Seems to be enough for now.
>
> Please add a FIXME to the function body (and a space between dwFlags and the
> closing parenthesis in the prototype), and submit to wine-patches.  Patches
> are not picked up from bugzilla.

I already improved the patch. I will submit when it will be ready.

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from [e-mail] ---
Hi Maxime,

Thanks for your work. I have been playing RL via playonlinux on SteamOS
'Brewmaster'. I cloned wine 1.9.2 with git and made the edits, however when I
'./configure' I get an error stating that gcc fails the '-V >&5' test. 
Realizing my version of ggc doesn't like the -V command, I tried removing that
line, but it then complains about missing files.

Apparently gcc does need to be greater than version 5 and I think mine is 4.8
or 4.9. I tried upgrading but that caused too many broken dependencies, so I
seem to be stuck.

I'm wondering if you think it would work for me to use your compiled patched
version?

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

--- Comment #11 from Maxime  ---
(In reply to tim.inman from comment #10)
> Hi Maxime,
>
> Thanks for your work. I have been playing RL via playonlinux on SteamOS
> 'Brewmaster'. I cloned wine 1.9.2 with git and made the edits, however when
> I './configure' I get an error stating that gcc fails the '-V >&5' test. 
> Realizing my version of ggc doesn't like the -V command, I tried removing
> that line, but it then complains about missing files.
>
> Apparently gcc does need to be greater than version 5 and I think mine is
> 4.8 or 4.9. I tried upgrading but that caused too many broken dependencies,
> so I seem to be stuck.
>
> I'm wondering if you think it would work for me to use your compiled patched
> version?

Hello,
I never tried SteamOS, but as it is Debian based, maybe there is a way to build
a patched .deb package.

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

--- Comment #12 from Maxime  ---
(In reply to Maxime from comment #11)
> (In reply to tim.inman from comment #10)
> > Hi Maxime,
> >
> > Thanks for your work. I have been playing RL via playonlinux on SteamOS
> > 'Brewmaster'. I cloned wine 1.9.2 with git and made the edits, however when
> > I './configure' I get an error stating that gcc fails the '-V >&5' test. 
> > Realizing my version of ggc doesn't like the -V command, I tried removing
> > that line, but it then complains about missing files.
> >
> > Apparently gcc does need to be greater than version 5 and I think mine is
> > 4.8 or 4.9. I tried upgrading but that caused too many broken dependencies,
> > so I seem to be stuck.
> >
> > I'm wondering if you think it would work for me to use your compiled patched
> > version?
>
> Hello,
> I never tried SteamOS, but as it is Debian based, maybe there is a way to
> build a patched .deb package.

I am using ArchLinux, and I build the patch wine using a modified PKGBUILD
file, which is producing a tar.xz package. The only thing you could do with
that is extract it to /, messing up your system. And wine will probably fail
because of dependency discrepancies between your system and mine.
So in your case, I would go for the official procedure to build a .deb from
source, by applying the patch in the procedure.

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from [e-mail] ---
this bug is affecting me on gentoo. anybody care to explain how to get this
working using playonlinux? i've never patched anything before. i use gentoo
thus install from source all the time and even have playonlinux running in a
nice little systemd nspawn container but am a noob at patching and don't know
where to start.

does this patch allow online play?

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

Captain Crutches  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

--- Comment #14 from [e-mail] ---
Maxime, Earquilla:

I am wondering if your fix is going to get pulled into the next staging
release? - if so playonlinux gives the option to easily install staging
releases and that would be a feasible alternative to building from source
(which is impossible on both of my distros).

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

--- Comment #15 from Maxime  ---
This patch only allows you to run the game and play in solo. In the latest
Steam update of the game, Rocket League is using BCryptEncrypt and
BCryptDecrypt (with AES) when connecting to an online game. These API are not
implemented in wine and using the native windows bcrypt.dll does not help.
So we won't be able to go online before these bcrypt API are implemented.

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #16 from Bruno Jesus  ---
(In reply to Maxime from comment #15)
> This patch only allows you to run the game and play in solo. In the latest
> Steam update of the game, Rocket League is using BCryptEncrypt and
> BCryptDecrypt (with AES) when connecting to an online game. These API are
> not implemented in wine and using the native windows bcrypt.dll does not
> help.
> So we won't be able to go online before these bcrypt API are implemented.

Please open new bugs for the other functions so we don't lose track of other
problems.

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

Robin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |robin.tschirschnitz@googlem
                   |                            |ail.com

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

Robin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |robin.tschirschnitz@googlem
                   |                            |ail.com

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

--- Comment #17 from Hans Leidekker  ---
Created attachment 54565
  --> https://bugs.winehq.org/attachment.cgi?id=54565
bcrypt WIP

Please attach a WINEDEBUG=+bcrypt trace with this patch applied.

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

--- Comment #18 from Søren  ---
Created attachment 54567
  --> https://bugs.winehq.org/attachment.cgi?id=54567
wine bcrypt trace

debug log when trying to join an online game

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

--- Comment #19 from Søren  ---
Comment on attachment 54567
  --> https://bugs.winehq.org/attachment.cgi?id=54567
wine bcrypt trace

It starts the game, i click find match for an online game, it finds a match and
says "joining" but eventually it times out with error: "your connection to the
game timed out (Error: 71)"

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

--- Comment #20 from Hans Leidekker  ---
(In reply to Søren from comment #19)
> Comment on attachment 54567 [details]
> wine bcrypt trace
>
> It starts the game, i click find match for an online game, it finds a match
> and says "joining" but eventually it times out with error: "your connection
> to the game timed out (Error: 71)"

Thanks. Looks like it needs an implementation of BCRYPT_BLOCK_PADDING in
BCryptEncrypt.

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

--- Comment #21 from Maxime  ---
We can move to BUG 40692 to continue on this.

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

bean  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]          |

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

--- Comment #22 from Bruno Jesus  ---
At bug 40692 people say they are able to run the game without any bcrypt
patches. Can the game still be played without any bcrypt patches? If yes lets
resolve it as abandoned since it is no longer possible to reproduce, we have
other bcrypt bugs that still represent wine deficiencies.

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #23 from [e-mail] ---
Does this commit fix the issue?

https://source.winehq.org/git/wine.git/commit/9c5a200de51b6773930f6f97a22d5e...

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |9c5a200de51b6773930f6f97a22
                   |                            |d5ec23aae3434
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #24 from Hans Leidekker  ---
Fixed with 9c5a200de51b6773930f6f97a22d5ec23aae3434.

[Bug 40680] Rocket league needs bcrypt.dll.BCryptGenerateSymmetricKey

https://bugs.winehq.org/show_bug.cgi?id=40680

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #25 from Alexandre Julliard  ---
Closing bugs fixed in 3.0-rc2.