[Bug 18515] New: Deleting the last entry in the overrides tab in winecfg is not shown correctly

http://bugs.winehq.org/show_bug.cgi?id=18515

Summary: Deleting the last entry in the overrides tab in
                    winecfg is not shown correctly
           Product: Wine
           Version: 1.1.21
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Add multiple overrides on a clean .wine.

When the first entry (or anything but the last one) is deleted by selecting and
pressing "Remove" the new updated list is immediately shown.

When one tries to delete the last entry (multiple have to exist) the gui shows
that last one, and the previous one, highlighted. The list doesn't show that an
entry was removed. When pressing 'Apply' (or 'OK' and relaunch winecfg) the
list is updated and it indeed doesn't show the removed entry anymore.

[Bug 18515] Deleting the last entry in the overrides tab in winecfg is not shown correctly

http://bugs.winehq.org/show_bug.cgi?id=18515

--- Comment #1 from Paul Vriens   2009-05-18 04:23:36 ---
It appears to be a regression so I'm doing the regression tests right now.

[Bug 18515] Deleting the last entry in the overrides tab in winecfg is not shown correctly

http://bugs.winehq.org/show_bug.cgi?id=18515

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Nikolay Sivov   2009-05-18 04:32:23 ---
(In reply to comment #1)
> It appears to be a regression so I'm doing the regression tests right now.

Maybe this is a cause:

http://source.winehq.org/git/wine.git/?a=commit;h=d2ecb1194102b6d7e6078556f8...

[Bug 18515] Deleting the last entry in the overrides tab in winecfg is not shown correctly

http://bugs.winehq.org/show_bug.cgi?id=18515

Paul Vriens  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Paul Vriens   2009-05-18 04:54:34 ---
Spot on:

[paul@acer wine-git]$ git bisect bad
d2ecb1194102b6d7e6078556f80e58c70ca39c23 is first bad commit
commit d2ecb1194102b6d7e6078556f80e58c70ca39c23
Author: Dmitry Timoshkov 
Date:   Wed Apr 29 12:55:13 2009 +0900

user32: Add the tests for LB_DELETESTRING, make them pass under Wine.

:040000 040000 dab4740de95040c5e5c729afec80788e26f59def
4fb8a093855489de0828386265e5f350a9ba4b60 M    dlls

[Bug 18515] Deleting the last entry in the overrides tab in winecfg is not shown correctly

http://bugs.winehq.org/show_bug.cgi?id=18515

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression,
                   |                            |source
          Component|-unknown                    |user32

[Bug 18515] Deleting the last entry in the overrides tab in winecfg is not shown correctly

http://bugs.winehq.org/show_bug.cgi?id=18515

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #4 from Dmitry Timoshkov   2009-05-19 01:01:15 ---
Thanks for the report, I sent the patch:
http://www.winehq.org/pipermail/wine-patches/2009-May/073137.html

[Bug 18515] Deleting the last entry in the overrides tab in winecfg is not shown correctly

http://bugs.winehq.org/show_bug.cgi?id=18515

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Dmitry Timoshkov   2009-05-19 11:22:35 ---
Should be fixed now by c293a535c05d5963a9095929e55a0658d342b1ea.

[Bug 18515] Deleting the last entry in the overrides tab in winecfg is not shown correctly

http://bugs.winehq.org/show_bug.cgi?id=18515

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard   2009-05-22 11:19:06 ---
Closing bugs fixed in 1.1.22.