[Bug 43600] New: The Saboteur [GOG] crashes on startup

https://bugs.winehq.org/show_bug.cgi?id=43600

Bug ID: 43600
           Summary: The Saboteur [GOG] crashes on startup
           Product: Wine
           Version: 2.15
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 59017
  --> https://bugs.winehq.org/attachment.cgi?id=59017
Saboteur: Wine crash log

When running GOG version of The Saboteur in Wine 2.15, it just inexplicably
crashes on startup, without any clear messages with normal Wine logging. I
attach a log with +all level. Same happens in Wine staging for the reference.

Kernel: 4.12.6 (Debian testing, x86_64).
CPU: Ryzen 7 1700X.
GPU: AMD RX 480, Mesa 17.1.4 and 17.3.0-devel both.

[Bug 43600] The Saboteur [GOG] crashes on startup

https://bugs.winehq.org/show_bug.cgi?id=43600

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Fabian Maurer  ---
Mind adding a normal log without WINEDEBUG set?

[Bug 43600] The Saboteur [GOG] crashes on startup

https://bugs.winehq.org/show_bug.cgi?id=43600

--- Comment #2 from Shmerl  ---
It's possible it's a game bug, and not limited to Wine. Some report, that it
crashes on CPUs with more than 4 cores (my case). See this thread:
https://www.gog.com/forum/the_saboteur/game_does_not_start_at_all/post29

I'll test their proposed patch later today to confirm, but it's likely
NOTOURBUG case.

[Bug 43600] The Saboteur [GOG] crashes on startup

https://bugs.winehq.org/show_bug.cgi?id=43600

--- Comment #3 from Shmerl  ---
To work around the game bug, you can patch GOG version like this:

echo "9f56d0: eb" | xxd -r - Saboteur.exe

[Bug 43600] The Saboteur [GOG] crashes on startup

https://bugs.winehq.org/show_bug.cgi?id=43600

Shmerl  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |NOTOURBUG
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #4 from Shmerl  ---
Not Wine's bug.

[Bug 43600] The Saboteur [GOG] crashes on startup

https://bugs.winehq.org/show_bug.cgi?id=43600

Matteo Bruni  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|NOTOURBUG                   |INVALID
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Matteo Bruni  ---
We generally resolve application bugs as INVALID. BTW, thanks for the
Linux-friendly oneliner :)

[Bug 43600] The Saboteur [GOG] crashes on startup

https://bugs.winehq.org/show_bug.cgi?id=43600

--- Comment #6 from Shmerl  ---
(In reply to Matteo Bruni from comment #5)
> We generally resolve application bugs as INVALID. BTW, thanks for the
> Linux-friendly oneliner :)

No problem, thanks to jackfuste from WSGF who found that fix by analyzing the
binary.

I updated the info here:

https://pcgamingwiki.com/wiki/The_Saboteur#Fixing_crash_on_CPUs_with_more_th...

And made a script here that checks the binary before patching:

https://gist.github.com/shmerl/4458375a3529995ed6b41b1ce1718eeb