[Bug 11398] New: Some PhotoShop controls are not working properly.

http://bugs.winehq.org/show_bug.cgi?id=11398

Summary: Some PhotoShop controls are not working properly.
           Product: Wine
           Version: 0.9.54.
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: blocker
          Priority: P2
         Component: directx-dinput
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

There are some controls on CS2 that allow you to slide a token indicator along
a scale or to adjust a curve by clicking and dragging on any point across it. I
found multiple examples where these are not working.

1 - Create a new adjustment layer with “Levels”. The resulting dialog has
little sliding tokens to adjust both the input and output levels. On windows
you simply slide them. On Wine you cannot . Here is a screenshot to illustrate:
http://download.erasmix.net/CS2-WINE/Screenshot-1.png

2 -Create a new adjustment layer with “Curves”. The resulting dialog has a
diagonal line that can be adjusted by clicking and dragging anywhere on it. In
Wine this line seems stuck, there is no way to drag points in any direction.
Here is a screenshot to illustrate:
http://download.erasmix.net/CS2-WINE/Screenshot-2.png

3- Create an adjustment layer using “Brightness/Contrast”. This dialog has
little sliding tokens to adjust left or right (these are a bit different than
the ones described on 1). These cannot be slided either. Here is a screenshot
to illustrate: http://download.erasmix.net/CS2-WINE/Screenshot-4.png

[Bug 11398] Some PhotoShop controls are not working properly.

http://bugs.winehq.org/show_bug.cgi?id=11398

James Hawkins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|directx-dinput              |-unknown

--- Comment #1 from James Hawkins   2008-01-30 00:26:57 ---
Photoshop does not use dinput.

[Bug 11398] Some PhotoShop controls are not working properly.

http://bugs.winehq.org/show_bug.cgi?id=11398

--- Comment #2 from Erasmo Acosta   2008-01-30 00:28:48 ---
(In reply to comment #1)
> Photoshop does not use dinput.

Sorry, but bugzilla forced me to guess the component if I didn't know :)

[Bug 11398] Some PhotoShop controls are not working properly.

http://bugs.winehq.org/show_bug.cgi?id=11398

--- Comment #3 from Dmitry Timoshkov   2008-01-30 01:00:52 ---
I opened a sample image Dune.tif and all the controls in dialogs Image->
Adjustments->Levels,Curves,Brightness/Contrast work for me in CS2.

[Bug 11398] Some PhotoShop controls are not working properly.

http://bugs.winehq.org/show_bug.cgi?id=11398

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|blocker                     |normal

[Bug 11398] Some PhotoShop controls are not working properly.

http://bugs.winehq.org/show_bug.cgi?id=11398

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Dan Kegel   2008-01-30 09:14:03 ---
Erasmo, what Linux distribution and graphics card are you using?

[Bug 11398] Some PhotoShop controls are not working properly.

http://bugs.winehq.org/show_bug.cgi?id=11398

--- Comment #5 from Erasmo Acosta   2008-01-30 10:30:55 ---
I use Fedora 8

According to my Xorg.0.log: ATI Technologies Inc Rage XL rev 39, Mem @
0xf1000000/24, 0xf2041000/12, I/O @ 0x9c00/8

By the way. It worked OK this time, so I tried to go back to what I did last
night. You need to do File -> Open, then click on "Use Adobe Dialog". After
that, do Image -> Adjustmens -> Levels (or curves or Brightness /Contrast).

Also, I don't know if this is related, but I see a lot of:

Jan 30 08:16:57 neo kernel: VMBlock warning: DentryOpRevalidate: invalid args
from kernel
Jan 30 08:18:34 neo kernel:last message repeated 4 times
Jan 30 08:20:18 neo kernel:last message repeated 4 times

In my /var/log/messages around the time this is happening and while CS3 is
starting.

Finally, after trying File -> Open for the second time (after having clicked on
"Use Adobe Dialog" on a previous File -> Open, the dialog is not possible to
locate. I see it on the window list panel, but I cannot see it on the screen.

Is it possible ALL this is related and caused by a memory leak?

[Bug 11398] Some PhotoShop controls are not working properly.

http://bugs.winehq.org/show_bug.cgi?id=11398

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #6 from Dmitry Timoshkov   2008-01-31 09:31:30 ---
Thanks for the clarification, I was able to reproduce this bug. I'll have
a look at it.
> Is it possible ALL this is related and caused by a memory leak?

I don't think there is an indication of that. Why do you think that
there is a memory leak in Wine looking at the observed behaviour?

[Bug 11398] Some PhotoShop controls are not working properly.

http://bugs.winehq.org/show_bug.cgi?id=11398

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 11398] Some PhotoShop controls are not working properly.

http://bugs.winehq.org/show_bug.cgi?id=11398

--- Comment #7 from Dmitry Timoshkov   2008-01-31 09:35:47 ---
While looking at it, I noticed that after turning on the Adobe Open File
dialog, pressing ESC discards the dialog and immediately brings "New"
dialog. This doesn't occur under Windows. Can anybody else confirm that?
If yes, that may worth opening a separate bug.

[Bug 11398] Some PhotoShop controls are not working properly.

http://bugs.winehq.org/show_bug.cgi?id=11398

--- Comment #8 from Erasmo Acosta   2008-01-31 10:44:17 ---
(In reply to comment #6)
> Thanks for the clarification, I was able to reproduce this bug. I'll have
> a look at it.
> > Is it possible ALL this is related and caused by a memory leak?
>
> I don't think there is an indication of that. Why do you think that
> there is a memory leak in Wine looking at the observed behaviour?

Just a guess, because of the kernel messages I get when this happens:

VMBlock warning: DentryOpRevalidate: invalid args from kernel

[Bug 11398] Some PhotoShop controls are not working properly.

http://bugs.winehq.org/show_bug.cgi?id=11398

--- Comment #9 from Dan Kegel   2008-01-31 13:41:54 ---
VMBlock is a vmware device.
Searching for that error on google finds lots of hits,
none of which have anything to do with wine.
So that's probably unrelated.

[Bug 11398] Some PhotoShop controls are not working properly.

http://bugs.winehq.org/show_bug.cgi?id=11398

--- Comment #10 from Dmitry Timoshkov   2008-02-04 06:32:36 ---
I've found the source of the problem: at some point main Photoshop window
gets WS_EX_TOPMOST style set. I have a hack which works for me (and makes
both Open File dialog work as much as needed, as well Levels type dialogs),
but Alexandre said that it's wrong. This needs more investigation, Alexandre
thinks that SWP_DoOwnedPopups doesn't behave quite right for topmost windows.

[Bug 11398] Some PhotoShop controls are not working properly.

http://bugs.winehq.org/show_bug.cgi?id=11398

--- Comment #11 from Dmitry Timoshkov   2008-02-07 09:05:19 ---
The following patch fixes the problem for me:

http://www.winehq.org/pipermail/wine-patches/2008-February/049770.html

[Bug 11398] Some PhotoShop controls are not working properly.

http://bugs.winehq.org/show_bug.cgi?id=11398

--- Comment #12 from Dmitry Timoshkov   2008-02-18 09:24:22 ---
Alexandre committed another version of the patch. Please retest.

[Bug 11398] Some PhotoShop controls are not working properly.

http://bugs.winehq.org/show_bug.cgi?id=11398

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
           Keywords|                            |download
         Resolution|                            |FIXED

--- Comment #13 from Dan Kegel   2008-02-18 10:31:32 ---
Damn, you're right.  Fixed.  (When did he sneak that in?)

I can't reproduce the "2nd File/Open invisible" problem in comment #5.

[Bug 11398] Some PhotoShop controls are not working properly.

http://bugs.winehq.org/show_bug.cgi?id=11398

--- Comment #14 from Dmitry Timoshkov   2008-02-18 20:58:20 ---
It has been fixed by the following commit:

http://source.winehq.org/git/wine.git/?a=commit;h=8f15dd4d4e4424a84623f4af7c...

[Bug 11398] Some PhotoShop controls are not working properly.

http://bugs.winehq.org/show_bug.cgi?id=11398

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #15 from Dan Kegel   2008-02-22 11:40:11 ---
0.9.56 released, so closing all bugs marked as RESOLVED FIXED.