[Bug 45829] New: SHGetNameFromIDList argument value differs in different SDK version

https://bugs.winehq.org/show_bug.cgi?id=45829

Bug ID: 45829
           Summary: SHGetNameFromIDList argument value differs in
                    different SDK version
           Product: Wine
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: shell32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

The second parameter for SHGetNameFromIDList are defined as this in different
version of Windows SDK. Note that the values for
SIGDN_PARENTRELATIVEFORADDRESSBAR differ in old and new versions:

// Windows SDK 5.0
typedef enum __MIDL_IShellItem_0001 {
    SIGDN_NORMALDISPLAY                 = 0,
    SIGDN_PARENTRELATIVEPARSING         = 0x80018001,
    SIGDN_PARENTRELATIVEFORADDRESSBAR   = 0x8001c001,
    SIGDN_DESKTOPABSOLUTEPARSING        = 0x80028000,
    SIGDN_PARENTRELATIVEEDITING         = 0x80031001,
    SIGDN_DESKTOPABSOLUTEEDITING        = 0x8004c000,
    SIGDN_FILESYSPATH                   = 0x80058000,
    SIGDN_URL                           = 0x80068000
} SIGDN;

// Windows SDK 7.1A
typedef enum _SIGDN {
    SIGDN_NORMALDISPLAY                 = 0,
    SIGDN_PARENTRELATIVEPARSING         = 0x80018001,
    SIGDN_DESKTOPABSOLUTEPARSING        = 0x80028000,
    SIGDN_PARENTRELATIVEEDITING         = 0x80031001,
    SIGDN_DESKTOPABSOLUTEEDITING        = 0x8004c000,
    SIGDN_FILESYSPATH                   = 0x80058000,
    SIGDN_URL                           = 0x80068000,
    SIGDN_PARENTRELATIVEFORADDRESSBAR   = 0x8007c001,
    SIGDN_PARENTRELATIVE                = 0x80080001
} SIGDN;

// Windows SDK 8.1
typedef enum _SIGDN {
    SIGDN_NORMALDISPLAY                 = 0,
    SIGDN_PARENTRELATIVEPARSING         = 0x80018001,
    SIGDN_DESKTOPABSOLUTEPARSING        = 0x80028000,
    SIGDN_PARENTRELATIVEEDITING         = 0x80031001,
    SIGDN_DESKTOPABSOLUTEEDITING        = 0x8004c000,
    SIGDN_FILESYSPATH                   = 0x80058000,
    SIGDN_URL                           = 0x80068000,
    SIGDN_PARENTRELATIVEFORADDRESSBAR   = 0x8007c001,
    SIGDN_PARENTRELATIVE                = 0x80080001,
    SIGDN_PARENTRELATIVEFORUI           = 0x80094001
} SIGDN;

[Bug 45829] SHGetNameFromIDList argument value differs in different SDK version

https://bugs.winehq.org/show_bug.cgi?id=45829

--- Comment #1 from jacky  ---
The implementation of SHGetNameFromIDList should be updated.

[Bug 45829] SHGetNameFromIDList argument value differs in different SDK version

https://bugs.winehq.org/show_bug.cgi?id=45829

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Version|unspecified                 |3.15

--- Comment #2 from Zebediah Figura  ---
Do you have an application that relies on this?

[Bug 45829] SHGetNameFromIDList argument value differs in different SDK version

https://bugs.winehq.org/show_bug.cgi?id=45829

jacky  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|Linux                       |Windows

--- Comment #3 from jacky  ---
It should not be considered as a bug in fact, just for that I found the values
are different in Windows SDK and then I viewed the implementation of this API
from WINE project. I think it is possible to be a bug in few cases, so it is.

[Bug 45829] SHGetNameFromIDList argument value differs in different SDK version

https://bugs.winehq.org/show_bug.cgi?id=45829

--- Comment #4 from Zebediah Figura  ---
In general I guess a bug that doesn't affect an application isn't really a bug
worth fixing.

I suppose in this case a patch to accept both values would be welcome, though.

[Bug 45829] SHGetNameFromIDList argument value differs in different SDK version

https://bugs.winehq.org/show_bug.cgi?id=45829

--- Comment #5 from Nikolay Sivov  ---
Value convention here is to have increasing number in high word, and a mask in
low word. Old definition you mentioned does not follow this pattern. Wine is
already using newer value, unless you have a test that shows what older value
does there's nothing to fix here.

[Bug 45829] SHGetNameFromIDList argument value differs in different SDK version

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=45829

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #6 from Nikolay Sivov  ---
Marking invalid.

[Bug 45829] SHGetNameFromIDList argument value differs in different SDK version

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=45829

--- Comment #7 from Austin English  ---
Closing.

[Bug 45829] SHGetNameFromIDList argument value differs in different SDK version

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=45829

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Austin English  ---
Closing.