[Bug 35655] New: Wined3d performance drop

Bug ID: 35655 Summary: Wined3d performance drop Product: Wine Version: 1.7.13 Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: directx-d3d Assignee: wine-bugs@winehq.org Reporter: wylda@volny.cz

In between 1.7.13 and wine-1.7.13-27-ge610713 i noticed performace drop in 3Dmark 2000.

In overall score it makes -14%, but as the CPU tests and MTexels/s & KTriangels/s remained cca the same, some FPS tests dropped to -20% ("8MB Texture Rendering Speed").

Since 1.7.13 there were not too much 3d changes, but anyway i bisected to:

4c4552c5a1910a9d5adf8eccff0ac62d89ffe376 is the first bad commit commit 4c4552c5a1910a9d5adf8eccff0ac62d89ffe376 Author: Ken Thomases ken@codeweavers.com Date: Wed Feb 19 16:14:53 2014 -0600

wined3d: Restore the pixel format of the window whose pixel format was actually changed.

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Show replies by date

wine-bugs＠winehq.org

23 Feb 23 Feb

4:15 p.m.

New subject: [Bug 35655] Wined3d performance drop

Wylda wylda@volny.cz changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

10:22 p.m.

New subject: [Bug 35655] Wined3d performance drop

--- Comment #1 from Ken Thomases ken@codeweavers.com --- Yes, I can confirm this.

The problem is the code added to context_enter(). In the ideal case, the outermost context_enter() will find that the wined3d context is still current, and its OpenGL context is the still the current OpenGL context. (That is, the app is neither using WGL nor working with multiple wined3d devices or swapchains on the same thread.) For that ideal case, context_enter() used to just call context_get_current() to query the current wined3d context and wglGetCurrentContext() to query the current OpenGL context. After my commit, it also calls GetPixelFormat(). That additional call is relatively expensive and it's being called a lot, at least for some of the 3DMark 2000 benchmarks.

Unfortunately, it's necessary for correctness. Admittedly, the problem it's solving is relatively uncommon, so the performance hit probably outweighs the correctness.

However, there are already plans[1] to further change how wined3d works and they will remove the need to call GetPixelFormat() so often. I think the best solution is to move forward on that. (Those plans, though, won't help for when wined3d is used on Windows. Then again, the performance characteristics of GetPixelFormat() may be radically different on Windows.)

Speaking of, the other thing we could do is investigate why Wine's GetPixelFormat() is expensive and make it faster.

[1] The WGL_WINE_surface extension proposed in http://www.winehq.org/pipermail/wine-devel/2014-January/102637.html

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

2 Mar 2 Mar

7:54 a.m.

New subject: [Bug 35655] Wined3d performance drop

Béla Gyebrószki gyebro69@gmail.com changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

16 Mar 16 Mar

4:12 a.m.

New subject: [Bug 35655] Wined3d performance drop

Dmitry Timoshkov dmitry@baikal.ru changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |morcant.221@gmail.com

--- Comment #2 from Dmitry Timoshkov dmitry@baikal.ru --- *** Bug 35791 has been marked as a duplicate of this bug. ***

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

30 Apr 30 Apr

1:18 p.m.

New subject: [Bug 35655] Wined3d performance drop

Luke Bratch l_bratch@yahoo.co.uk changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |l_bratch@yahoo.co.uk

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

15 Sep 15 Sep

12:57 a.m.

New subject: [Bug 35655] Wined3d performance drop

http://source.winehq.org/patches/data/106532 http://source.winehq.org/patches/data/106534 http://source.winehq.org/patches/data/106533 http://source.winehq.org/patches/data/106535 http://source.winehq.org/patches/data/106536

--- Comment #3 from Ken Thomases ken@codeweavers.com --- Since I won't be working on the proper solution for this in the foreseeable future, I have submitted reverts of the original problem commit and some related commits:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

30 Sep 30 Sep

5:20 p.m.

New subject: [Bug 35655] Wined3d performance drop

--- Comment #4 from Wylda wylda@volny.cz --- Still in wine 1.7.27. Just for futer comparisons: * wine-1.7.13 ~ 18'735 marks * wine-1.7.27 ~ 15'657 marks

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

21 Oct 21 Oct

9:40 p.m.

New subject: [Bug 35655] Wined3d performance drop

mrdeathjr28@yahoo.es changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |mrdeathjr28@yahoo.es

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

10 Feb 10 Feb

4:30 p.m.

New subject: [Bug 35655] Wined3d performance drop

Michael Stefaniuc mstefani@redhat.com changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

4 May 4 May

6:55 a.m.

New subject: [Bug 35655] Wined3d performance drop

Linards linards.liepins@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |linards.liepins@gmail.com

--- Comment #5 from Linards linards.liepins@gmail.com --- (In reply to Wylda from comment #4)

Still in wine 1.7.27. Just for futer comparisons:

wine-1.7.13 ~ 18'735 marks

wine-1.7.27 ~ 15'657 marks

Offtopic, but I was wondering if Phoronix Test Suite could provide more detailed results than just plain 3DMark numbers? For me as *nix user (for home office) it does not tell much...

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

5 May 5 May

3:26 p.m.

New subject: [Bug 35655] Wined3d performance drop

--- Comment #6 from mrdeathjr28@yahoo.es --- (In reply to Wylda from comment #4)

https://www.youtube.com/watch?v=waYTC-ab4W0

Still in wine 1.7.27. Just for futer comparisons:

wine-1.7.13 ~ 18'735 marks

wine-1.7.27 ~ 15'657 marks

This is video tests in wine 1.7.13 and 1.7.42 with same values for both test

Wine 1.7.13

Wine 1.7.42

https://www.youtube.com/watch?v=QsKQkOC5ggg

In results are this

Wine 1.7.13: 30243

Wine 1.7.42: 30114

However this test is only for 3DMark2000 maybe in other apps still affected

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

7 May 7 May

7:21 a.m.

New subject: [Bug 35655] Wined3d performance drop

--- Comment #7 from Linards linards.liepins@gmail.com --- (In reply to mrdeathjr28 from comment #6)

(In reply to Wylda from comment #4)

...
Still in wine 1.7.27. Just for futer comparisons:

wine-1.7.13 ~ 18'735 marks

wine-1.7.27 ~ 15'657 marks

This is video tests in wine 1.7.13 and 1.7.42 with same values for both test

Wine 1.7.13

https://www.youtube.com/watch?v=waYTC-ab4W0

Wine 1.7.42

https://www.youtube.com/watch?v=QsKQkOC5ggg

In results are this

Wine 1.7.13: 30243

Wine 1.7.42: 30114

However this test is only for 3DMark2000 maybe in other apps still affected

As far as I understand, 3DMark2k5 is not used because Windows XP Infrastructure is not efficiently implemented in wine codebase?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

3 Jun 3 Jun

11:02 p.m.

New subject: [Bug 35655] Wined3d performance drop

Ken Sharp imwellcushtymelike@gmail.com changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

20 Jun 20 Jun

2:52 p.m.

New subject: [Bug 35655] Wined3d performance drop

Wylda wylda@volny.cz changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |matteo.mystral@gmail.com

--- Comment #8 from Wylda wylda@volny.cz ---

(In reply to mrdeathjr28 from comment #6)

Thanks mrdeathjr28 for re-test. I did the same and took me a lot of time.

So numericaly this seems to be fixed, but this is thanks to Matteo's optimizations.

These two Matteo's patches did significant improvement. Note: first number is total score gain in % (because cpu benchmarks remain the same, increased FPS bechmarks change total score just partly), second number shows FPS gain in % for "64MB Texture Rendering Speed":

* wine-1.7.41-95-g978fe23 1st ... +15.5% (against wine-1.7.41 - comparable with 1.7.14 and above) 2nd ... +26.3% (against wine-1.7.41)

* wine-1.7.44-249-g4189d29 1st ... +2.9% (+18.6% against wine-1.7.41) 2nd ... +11.4% (+40.6% against wine-1.7.41)

So these two patches makes this bug numericaly fixed. But when i also revert Ken's patches (this bug is about these patches, not Matteo's) it gives _nice_ boost: 1st ... +38.9% (wine-1.7.45 + revert against wine-1.7.41) 2nd ... +69.2% (wine-1.7.45 + revert against wine-1.7.41)

Gain nearly 70% is awesome, if fixed. (sure 70% is the best value, other tests shows gain between +19% to 56%).

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

2:54 p.m.

New subject: [Bug 35655] Wined3d performance drop

--- Comment #9 from Linards linards.liepins@gmail.com --- (In reply to Wylda from comment #8)

...
(In reply to mrdeathjr28 from comment #6)

Thanks mrdeathjr28 for re-test. I did the same and took me a lot of time.

So numericaly this seems to be fixed, but this is thanks to Matteo's optimizations.

These two Matteo's patches did significant improvement. Note: first number is total score gain in % (because cpu benchmarks remain the same, increased FPS bechmarks change total score just partly), second number shows FPS gain in % for "64MB Texture Rendering Speed":

wine-1.7.41-95-g978fe23

1st ... +15.5% (against wine-1.7.41 - comparable with 1.7.14 and above) 2nd ... +26.3% (against wine-1.7.41)

wine-1.7.44-249-g4189d29

1st ... +2.9% (+18.6% against wine-1.7.41) 2nd ... +11.4% (+40.6% against wine-1.7.41)

So these two patches makes this bug numericaly fixed. But when i also revert Ken's patches (this bug is about these patches, not Matteo's) it gives _nice_ boost: 1st ... +38.9% (wine-1.7.45 + revert against wine-1.7.41) 2nd ... +69.2% (wine-1.7.45 + revert against wine-1.7.41)

Gain nearly 70% is awesome, if fixed. (sure 70% is the best value, other tests shows gain between +19% to 56%).

Great. Waiting for changes to land in pustream in my lifetime. :)

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

25 Jul 25 Jul

1:54 p.m.

New subject: [Bug 35655] Wined3d performance drop

Jonas Jelten jj@stusta.net changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |jj@stusta.net

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

29 Sep 29 Sep

12:07 a.m.

New subject: [Bug 35655] Wined3d performance drop

Michael Müller michael@fds-team.de changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

10:22 a.m.

New subject: [Bug 35655] 3Dmark 2000 shows considerable performance drop after Wine 1.7.13 (expensive GetPixelFormat() called too frequently)

Anastasius Focht focht@gmx.net changed:

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

16 Nov 16 Nov

7:34 p.m.

New subject: [Bug 35655] 3Dmark 2000 shows considerable performance drop after Wine 1.7.13 (expensive GetPixelFormat() called too frequently)

--- Comment #10 from Matteo Bruni matteo.mystral@gmail.com --- This should be fixed now (and this bug looks like a duplicate of bug 35718), can you retest to confirm?

-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

wine-bugs＠winehq.org

17 Nov 17 Nov

2:16 a.m.

New subject: [Bug 35655] 3Dmark 2000 shows considerable performance drop after Wine 1.7.13 (expensive GetPixelFormat() called too frequently)

--- Comment #11 from mrdeathjr28@yahoo.es --- (In reply to Matteo Bruni from comment #10)