http://bugs.winehq.org/show_bug.cgi?id=14365
Summary: do not touch high address space (initial stack, user_space_limit) Product: Wine Version: 1.0.0 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: jreiser@BitWagon.com
Created an attachment (id=14662) --> (http://bugs.winehq.org/attachment.cgi?id=14662) avoid meddling with space above user_space_limit.
In order to co-operate with valgrind and other debugging tools, then wine must not assume anything about the initial stack, nor pretend that wine can manage any address space above the user_space_limit. Patch is attached, and will be sent to wine-patches@winehq.org.
http://bugs.winehq.org/show_bug.cgi?id=14365
--- Comment #1 from Vitaliy Margolen vitaliy@kievinfo.com 2008-07-08 12:31:11 --- Don't reformat arbitrary code. No c++ stile comments please.
This is in case you want to send this patch to wine-patches of course.
http://bugs.winehq.org/show_bug.cgi?id=14365
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
--- Comment #2 from Austin English austinenglish@gmail.com 2009-01-05 11:12:45 --- Is this still an issue in current (1.1.12 or newer) wine? Would you mind resubmitting the patch and asking for comments?
http://bugs.winehq.org/show_bug.cgi?id=14365
--- Comment #3 from Austin English austinenglish@gmail.com 2009-07-16 13:10:51 --- This area has changed a lot recently, might be worth taking another look/re-valgrinding.
http://bugs.winehq.org/show_bug.cgi?id=14365
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=14365
--- Comment #4 from Austin English austinenglish@gmail.com 2012-03-19 14:02:37 CDT --- Still present.
https://bugs.winehq.org/show_bug.cgi?id=14365
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download
https://bugs.winehq.org/show_bug.cgi?id=14365
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian@fds-team.de
--- Comment #5 from Sebastian Lackner sebastian@fds-team.de --- Not sure if this still causes any problems, but the patch is definitely wrong. Just removing the whole reserve_area() code isn't really an appropriate solution. I'll leave it up to Austin if this should be closed as ABANDONED.
https://bugs.winehq.org/show_bug.cgi?id=14365
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ABANDONED Status|UNCONFIRMED |RESOLVED
--- Comment #6 from Austin English austinenglish@gmail.com --- (In reply to Sebastian Lackner from comment #5)
Not sure if this still causes any problems, but the patch is definitely wrong. Just removing the whole reserve_area() code isn't really an appropriate solution. I'll leave it up to Austin if this should be closed as ABANDONED.
It's been 7 years, so yes. If John wants to revisit the patch, we can reopen.
https://bugs.winehq.org/show_bug.cgi?id=14365
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #7 from Austin English austinenglish@gmail.com --- Closing.
-
wine-bugs＠winehq.org