http://bugs.winehq.org/show_bug.cgi?id=20978
Summary: Quicktime 7.1.6.200 installer fails Product: Wine Version: 1.1.34 Platform: PC URL: http://wsidecar.apple.com/cgi-bin/nph-reg3rdpty2.pl/pr oduct=13803&cat=59&platform=osx&method=sa/QuickTimeIns taller.exe OS/Version: Linux Status: NEW Keywords: download, Installer, regression Severity: normal Priority: P2 Component: ole32 AssignedTo: wine-bugs@winehq.org ReportedBy: kennybobs@o2.co.uk CC: madewokherd@gmail.com
Created an attachment (id=25148) --> (http://bugs.winehq.org/attachment.cgi?id=25148) wine-1.1.34-194-g09db528 console output
The installer for Quicktime 7.1.6.200 fails very early.
err:msi:call_script Could not find CLSID for Windows Script err:msidb:TABLE_fetch_stream fetching stream L"Binary.Scripts.vbs", error = 1627 err:msi:ITERATE_Actions Execution halted, action L"FindASUInstalled" returned 13
This is a recent regression.
371f6a4818ee3739282f29a3259f86357e4e47a0 is first bad commit commit 371f6a4818ee3739282f29a3259f86357e4e47a0 Author: Vincent Povirk vincent@codeweavers.com Date: Wed Nov 18 10:38:10 2009 -0600
ole32: Do not allow the same stream to be opened twice.
:040000 040000 4bb7c46b78b29446dc7065e9a91f457f97d3af1c 55fabf4e6e351ea471354e62d51e0a9a562f7bc0 M dlls
http://source.winehq.org/git/wine.git/?a=commitdiff;h=371f6a4818ee3739282f29...
Commit can not be reverted in latest git, but checking out the commit before fixes the problem.
http://bugs.winehq.org/show_bug.cgi?id=20978
--- Comment #1 from Vincent Povirk madewokherd@gmail.com 2009-12-09 20:22:47 --- This looks to me like a case where msi relies on incorrect behavior in the storage implementation, but I'll check in more detail tomorrow.
http://bugs.winehq.org/show_bug.cgi?id=20978
Vincent Povirk madewokherd@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Component|ole32 |msi
--- Comment #2 from Vincent Povirk madewokherd@gmail.com 2009-12-10 17:03:58 --- Yep, msi is trying to open a stream while it already has a valid open object for that stream. The storage implementation could cope with it just fine, but we have tests that show windows fails with STG_E_ACCESSDENIED in this case. So what msi is doing is broken, and it needs to be fixed.
My guess is that the msi implementation shouldn't attach a real IStream object from the ole storage implementation to msi records, but I'd rather have someone familiar with msi look at this.
If it helps, I can write a patch that brings back the old behavior in current Wine, but it can't be committed.
http://bugs.winehq.org/show_bug.cgi?id=20978
--- Comment #3 from Ken Sharp kennybobs@o2.co.uk 2009-12-10 19:12:50 --- Quicktime, and only this specific version, is the only app so far that I have found that fails with this kind of error, so it's not a major problem as other versions still work. The patch might be handy if someone else wants to pick up the bug at a later date though. Up to you.
http://bugs.winehq.org/show_bug.cgi?id=20978
Hans Leidekker hans@meelstraat.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hans@meelstraat.net
--- Comment #4 from Hans Leidekker hans@meelstraat.net 2009-12-11 06:15:58 --- I'm no structured storage expert but perhaps we should keep a list of open streams and search that before trying to open a stream. Or is there a way to query open streams from a storage object?
Then we could clone the stream object and reset the stream pointer to the beginning of the stream, instead of reopening it.
http://bugs.winehq.org/show_bug.cgi?id=20978
--- Comment #5 from Vincent Povirk madewokherd@gmail.com 2009-12-11 10:08:45 --- There's no way to query the open streams from a storage object.
Cloning the existing stream and seeking to the start is fine.
http://bugs.winehq.org/show_bug.cgi?id=20978
Hans Leidekker hans@meelstraat.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #6 from Hans Leidekker hans@meelstraat.net 2009-12-16 11:55:34 --- Fixed by ef522c5ef0aeb2563885ad0a70ffe3fa3f1489f5.
http://bugs.winehq.org/show_bug.cgi?id=20978
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #7 from Alexandre Julliard julliard@winehq.org 2009-12-18 13:08:13 --- Closing bugs fixed in 1.1.35.
http://bugs.winehq.org/show_bug.cgi?id=20978
Ken Sharp kennybobs@o2.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |ef522c5ef0aeb2563885ad0a70f | |fe3fa3f1489f5 Regression SHA1| |371f6a4818ee3739282f29a3259 | |f86357e4e47a0