[Bug 12928] New: Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

Summary: Microsoft Office 2003 won't install in Wine 0.9.61
           Product: Wine
           Version: 0.9.61.
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=12652)
 --> (http://bugs.winehq.org/attachment.cgi?id=12652)
MS Office 2003 install crash output

Microsoft Office 2003 will no longer install in either Windows 2000 or Windows
XP mode under Wine 0.9.61. I am only trying to install the recommended Word,
Excel, and Powerpoint components. It crashes immediately after selecting the
components and starting the installation.

I tried installing using all built in DLL's, as well as with native richedit
and msxml3, and also the rather complex builtin/native DLL setup I normally use
and it crashed the same way under all configurations (Unhandled page fault on
read access).

And by the way, I've been installing it for quite awhile and never had problems
before. It works great under 0.9.60.

I've attached the console output from the crashes.

[Bug 12928] Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

James Hawkins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Installer, regression

--- Comment #1 from James Hawkins   2008-05-02 23:09:26 ---
Please run a regression test:

http://wiki.winehq.org/RegressionTesting

[Bug 12928] Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

--- Comment #2 from Robert M. Muncrief   2008-05-03 09:02:12 ---
Created an attachment (id=12666)
 --> (http://bugs.winehq.org/attachment.cgi?id=12666)
git bisect output identifying errant patch

[Bug 12928] Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

--- Comment #3 from Dmitry Timoshkov   2008-05-03 09:07:56 ---
a2073f2979ea9e440247ea0503be4dce840fc782 is first bad commit
commit a2073f2979ea9e440247ea0503be4dce840fc782
Author: Alexandre Julliard 
Date:   Wed Apr 30 14:24:49 2008 +0200

dxerr9: Don't use Wine debugging macros in static libraries.

:040000 040000 a5c3faed81950f11f11cebe8159074c765cadfd1
893a5a9fdcc173efec4b1ebf9fadac793c2a0154 M      dlls

That's most likely a result of an incorrect regression test.

[Bug 12928] Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

Robert M. Muncrief  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

--- Comment #4 from Robert M. Muncrief   2008-05-03 09:28:38 ---
OK, bisect identified the patch and it's attached above.

But while going through the procedure and seeing how easy it was to use bisect
(I didn't know about it before) I was interested on how such a bug could get
through release regressions tests in the first place, and was surprised to
discover that Wine doesn't have any.

I've written a few regression test programs for clients before, the largest at
Sun Microsystems many years ago, and don't understand why a formal regressions
test program hasn't been written. It seems that with the way bisect can
identify errant patches, all that needs to be done is to create templates
identifying the Windows Applications to be tested, the input and output window
handles and the values to write/read from/to the program, and its arguments.
After that you could run just the program and monitor output messages, again
comparing them to templates of what's acceptable or not, and if an unacceptable
message is output or the program crashes run bisect on it, and automatically
fill out a bug report to be sent to the developers concerned.

But I don't know the internals of Wine. Is there a problem determining
Application window handles and/or setting and reading values from them, or
something else that I'm missing?

If not someone should email me with some specifications about what you need,
and links to documentation about the relevant API's and whatever other
documentation I might need and I'll see what it would take to create one for
you. I'm concerned that your trying to release V1.0 without regressions tests,
because after 1.0 users are going to expect a stable program, and as it stands
now any patch can break programs and you won't know until users find it,
slowing the adoption of Wine as a stable Windows alternative.

[Bug 12928] Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

--- Comment #5 from Robert M. Muncrief   2008-05-03 09:31:03 ---
"That's most likely a result of an incorrect regression test."
 Dmitry Timoshkov

OK, I'll run it again to make sure I didn't do something wrong.

[Bug 12928] Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

Robert M. Muncrief  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12666|0                           |1
        is obsolete|                            |

--- Comment #6 from Robert M. Muncrief   2008-05-03 11:47:52 ---
(From update of attachment 12666)
I made an error during regression tests, this is not the problem.

[Bug 12928] Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

--- Comment #7 from Robert M. Muncrief   2008-05-03 11:56:52 ---
Created an attachment (id=12675)
 --> (http://bugs.winehq.org/attachment.cgi?id=12675)
git bisect output identifying errant patch

Sorry about my previous error. I've attached the bisect output for the correct
error.

The comment for the patch is "msi: Add initial implementation of
MsiPublishAssemblies." and since I don't know how to rewind before a specific
patch I just brute force replaced the dll/ msi, msimg32, msimtf, and msisys.ocx
directories, and include/ msi.h, msidefs.h, msinkaut.h, msinkaut.idl, and
msiquery.h files with ones from a good installation, recompiled, and the
problem went away and I was able to install MS Office 2003.

So it appears the problem indeed has something to do with this patch.

[Bug 12928] Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

Robert M. Muncrief  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12666|application/octet-stream    |text/plain
          mime type|                            |

[Bug 12928] Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

Robert M. Muncrief  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12675|application/octet-stream    |text/plain
          mime type|                            |

[Bug 12928] Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

Robert M. Muncrief  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]         |

[Bug 12928] Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

--- Comment #8 from Robert M. Muncrief   2008-05-03 12:07:05 ---
Bugzilla won't let me CC [e-mail], it says his name can't be
matched. So if someone knows how to contact him please do.

[Bug 12928] Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

Steven Edwards  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

--- Comment #9 from Steven Edwards   2008-05-03 21:13:37 ---
I think James has a patch for this coming

[Bug 12928] Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

James Hawkins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]           |
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #10 from James Hawkins   2008-05-03 21:15:22 ---
I'm on wine-bugs.

[Bug 12928] Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

--- Comment #11 from James Hawkins   2008-05-03 21:18:30 ---
Patches sent:

http://winehq.org/pipermail/wine-patches/2008-May/054508.html
http://winehq.org/pipermail/wine-patches/2008-May/054509.html
http://winehq.org/pipermail/wine-patches/2008-May/054510.html
http://winehq.org/pipermail/wine-patches/2008-May/054511.html

[Bug 12928] Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

--- Comment #12 from Robert M. Muncrief   2008-05-04 18:40:27 ---
Thank you very much.

These patches fixed the MS Office install problem for me, and I was able to
install and run my entire suite of Windows programs, with the exception of
Steam games. However, this is not do to a regression error, Valve unfortunately
updated their Steam Client yesterday so that Steam games no longer run under
Wine. But I'll file a bug report about that later if one hasn't already been
created.

Once again, thank all of you for so quickly remedying this problem.

[Bug 12928] Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |normal
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #13 from Lei Zhang   2008-05-05 16:25:46 ---
patches committed.

[Bug 12928] Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

James Hawkins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #14 from James Hawkins   2008-05-06 15:55:17 ---
*** Bug 13023 has been marked as a duplicate of this bug. ***

[Bug 12928] Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #15 from Alexandre Julliard   2008-05-09 12:55:10 ---
Closing bugs fixed in 1.0-rc1.

[Bug 12928] Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

--- Comment #16 from [e-mail]  2008-05-11 01:47:59 ---
Created an attachment (id=12909)
 --> (http://bugs.winehq.org/attachment.cgi?id=12909)
Console log for Office 2003 install failure on RC1

[Bug 12928] Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from [e-mail]  2008-05-11 01:51:12 ---
This bug is NOT fixed. I tried to install Office 2003 in RC1, OpenSUSE 10.3,
and it failed early on with the message "Installation ended prematurely because
of an error." My console log is attached.

I ran a regression test and it identified the same bad commit as before:

bfe07d1d07c9469a398858d0f077e26c26695b5d is first bad commit
commit bfe07d1d07c9469a398858d0f077e26c26695b5d
Author: James Hawkins 
Date:   Wed Apr 30 04:22:46 2008 -0500

msi: Add initial implementation of MsiPublishAssemblies.

:040000 040000 350f1cb80411637d01a5f8cec26eac85ac2b0927
1c170117cac90dc0eb252354044aeca42c713875 M      dlls
:040000 040000 4ee11e992be061a73a8dfd3a8671e971a935e343
396ca958695023082e31cfc78d804e528b9c8b2b M      include

[Bug 12928] Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

--- Comment #18 from James Hawkins   2008-05-11 18:15:02 ---
The bug is fixed in 1.0-rc1.

[Bug 12928] Microsoft Office 2003 won't install in Wine 0.9.61

http://bugs.winehq.org/show_bug.cgi?id=12928

--- Comment #19 from [e-mail]  2008-05-11 22:00:27 ---
(In reply to comment #18)
> The bug is fixed in 1.0-rc1.

My test was in 1.0-rc1. I opened a new bug report for it--13139.