https://bugs.winehq.org/show_bug.cgi?id=39123
Bug ID: 39123 Summary: Fairy Fencer F - Large number of FIXME ntdll NtQuerySystemInformation calls Product: Wine Version: 1.7.49 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: ntdll Assignee: wine-bugs@winehq.org Reporter: chaos.kagami@gmail.com Distribution: ---
Created attachment 52131 --> https://bugs.winehq.org/attachment.cgi?id=52131 Replaces SYSTEM_INTERRUPT_INFORMATION returning zeroed array with rand() filled array
The following messages are repeated through the log during gameplay of Fairy Fencer F, over and over:
fixme:ntdll:NtQuerySystemInformation info_class SYSTEM_INTERRUPT_INFORMATION fixme:ntdll:NtQuerySystemInformation (0x00000021,0x5dd43a80,0x00000010,0x6fcdd00) stub fixme:ntdll:NtQuerySystemInformation (0x0000002d,0x5dd43a80,0x00000020,0x6fcdd00) stub
Looking through WINE's source, as well as various internet resources - SYSTEM_INTERRUPT_INFORMATION and another two-ish unimplemented queries can be used to seed RNG, or just be used as random numbers. Wine returns a zero-filled array in all of these cases, which results in oddly crippled RNG ranges in Fairy Fencer F. I've observed a whole battle where every attach hit and as long as the same attack was used, it did exactly the same damage every time. Also, in general, the game appears to lack some randomness with these stubs versus windows. Replacing the zero-filled array with a rand() filled one improves the situation, but I'm rather sure it isn't what windows does.
A rather hackish patch is attached. The difference in random numbers in-game should be easily and immediately observable. I'm also aware the patch doesn't meet submission guidelines - it's not meant to be a real fix. I'm not entirely sure what the 'correct' fix is.
https://bugs.winehq.org/show_bug.cgi?id=39123
Jon Feldman chaos.kagami@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |chaos.kagami@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=39123
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Fairy Fencer F - Large |Fairy Fencer F depends on |number of FIXME ntdll |NtQuerySystemInformation(SY |NtQuerySystemInformation |STEM_INTERRUPT_INFORMATION) |calls |volatility for random | |number generation
https://bugs.winehq.org/show_bug.cgi?id=39123
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian@fds-team.de
https://bugs.winehq.org/show_bug.cgi?id=39123
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com
https://bugs.winehq.org/show_bug.cgi?id=39123
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
https://bugs.winehq.org/show_bug.cgi?id=39123
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |STAGED CC| |erich.e.hoover@wine-staging | |.com, michael@fds-team.de Ever confirmed|0 |1 Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/ntdll-SystemIn | |terruptInformation
https://bugs.winehq.org/show_bug.cgi?id=39123
Detlef Riekenberg wine.dev@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wine.dev@web.de
https://bugs.winehq.org/show_bug.cgi?id=39123
--- Comment #1 from Detlef Riekenberg wine.dev@web.de --- Structure definition:
http://www.geoffchappell.com/studies/windows/km/ntoskrnl/api/ex/sysinfo/inte...
https://bugs.winehq.org/show_bug.cgi?id=39123
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv@dawncrow.de Staged patchset|https://github.com/wine-com |https://github.com/wine-sta |pholio/wine-staging/tree/ma |ging/wine-staging/tree/mast |ster/patches/ntdll-SystemIn |er/patches/ntdll-SystemInte |terruptInformation |rruptInformation
https://bugs.winehq.org/show_bug.cgi?id=39123
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|STAGED |RESOLVED Fixed by SHA1| |ec02224941eedf16b8b04396451 | |9f6363b5ce21f Resolution|--- |FIXED
--- Comment #2 from Nikolay Sivov bunglehead@gmail.com --- This was implemented with ec02224941eedf16b8b043964519f6363b5ce21f.
https://bugs.winehq.org/show_bug.cgi?id=39123
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #3 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 5.19.