[Bug 22765] New: fonts no longer anti-aliased after 1.1.44

http://bugs.winehq.org/show_bug.cgi?id=22765

Summary: fonts no longer anti-aliased after 1.1.44
           Product: Wine
           Version: unspecified
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: fonts
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Hello, a change between 1.1.44 and wine-1.1.44-290-g7d3cb53 results in the loss
of anti-aliasing of fonts - observed both in winecfg and in Lotus Notes.

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
          Component|fonts                       |-unknown
            Version|unspecified                 |1.1.44
            Summary|fonts no longer             |Fonts no longer
                   |anti-aliased after 1.1.44   |anti-aliased
           Severity|normal                      |trivial

--- Comment #1 from Vitaliy Margolen   2010-05-19 08:56:30 ---
Please post results of regression testing as described here:
http://wiki.winehq.org/RegressionTesting

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

--- Comment #2 from Alexandre Julliard   2010-05-19 09:01:29 ---
The fontconfig parameters take precedence now, make sure they are set
correctly.

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

--- Comment #3 from Toralf Förster   2010-05-19 10:04:10 ---
Created an attachment (id=28081)
 --> (http://bugs.winehq.org/attachment.cgi?id=28081)
output of eselect fontconfig list

(In reply to comment #2)
> The fontconfig parameters take precedence now, make sure they are set
> correctly.

Erm, under Gentoo anti-aliasing is set and works fine for almost apps, the
eselect output in addition gives me no clue ...

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

--- Comment #4 from Toralf Förster   2010-05-20 09:07:45 ---
(In reply to comment #1)
> Please post results of regression testing as described here:
> http://wiki.winehq.org/RegressionTesting

tfoerste@n22 ~/devel/wine-git $ git bisect good
922e15cbd04fde3d9d4fbb98600f5471420c2daa is the first bad commit
commit 922e15cbd04fde3d9d4fbb98600f5471420c2daa
Author: Alexandre Julliard 
Date:   Mon May 17 11:48:12 2010 +0200

winex11: Use the subpixel rendering configuration from fontconfig to
override the registry options.

:040000 040000 fdcd958a4abd5374f9bc3bc77236e802bf1bcbaa
e6cafdc1e15e81329a57bdbe6038ee4bb303100b M      dlls

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

--- Comment #5 from Alexander Scott-Johns   2010-05-20 13:44:27 ---
Created an attachment (id=28134)
 --> (http://bugs.winehq.org/attachment.cgi?id=28134)
Example fontconfig configuration file.

If you want to enable anti-aliasing in fontconfig, try saving the attachment as
~/.fonts.conf

It's an XML file, and the various settings are documented in the manual [1].

[1] http://fontconfig.org/fontconfig-user.html

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

--- Comment #6 from Toralf Förster   2010-05-20 14:26:36 ---
Created an attachment (id=28135)
 --> (http://bugs.winehq.org/attachment.cgi?id=28135)
old config file (Gentoo)

(In reply to comment #5)
> Created an attachment (id=28134)

--> (http://bugs.winehq.org/attachment.cgi?id=28134) [details]
> Example fontconfig configuration file.

Thx for your example file - I'm wondering why the file from my Gentoo didn't
work in the same manner ....

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

Toralf Förster  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID

--- Comment #7 from Toralf Förster   2010-05-20 14:27:02 ---
not a bug in winie

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Nikolay Sivov   2010-05-20 14:31:41 ---
Closing.

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

Andrew Nguyen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                   |                            |m

--- Comment #9 from Andrew Nguyen   2010-05-22 13:29:22 ---
*** Bug 22827 has been marked as a duplicate of this bug. ***

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

--- Comment #10 from leighman   2010-05-23 06:10:31 ---
Ubuntu does not have
<edit mode="assign" name="rgba">
<const>
rgb
</const>
</edit>
set by default either, which seems to be the key.
Does Wine rely on this?

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

--- Comment #11 from Dmitry Timoshkov   2010-05-23 10:55:12 ---
(In reply to comment #10)
> Ubuntu does not have
>
> <edit mode="assign" name="rgba">
> <const>
> rgb
> </const>
> </edit>
> set by default either, which seems to be the key.
> Does Wine rely on this?

Wine queries the fontconfig APIs, the config file doesn't belong to Wine.

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

--- Comment #12 from leighman   2010-05-23 12:02:20 ---
(In reply to comment #11)
> (In reply to comment #10)
> > Ubuntu does not have
> >
> > <edit mode="assign" name="rgba">
> > <const>
> > rgb
> > </const>
> > </edit>
> > set by default either, which seems to be the key.
> > Does Wine rely on this?
>
> Wine queries the fontconfig APIs, the config file doesn't belong to Wine.

But all other fonts looked fine, whereas Wine needs rgb set to look good.  Is
there a reason for this, otherwise it surely is a bug in Wine?

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

Alexander Scott-Johns  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexander.scott.johns+wineb
                   |                            |[e-mail]

--- Comment #13 from Alexander Scott-Johns   2010-05-23 18:30:32 ---
(In reply to comment #12)
> But all other fonts looked fine, whereas Wine needs rgb set to look good.  Is
> there a reason for this, otherwise it surely is a bug in Wine?

Ubuntu GUI fonts are designed to look OK without brilliant hinting; Wine
probably uses different fonts.

Have you tested Wine's fonts in other applications?

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #14 from Dmitry Timoshkov   2010-05-24 01:33:53 ---
*** Bug 22853 has been marked as a duplicate of this bug. ***

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

--- Comment #15 from Igor Tarasov   2010-05-24 02:37:26 ---
This bug is not invalid.

Try changing rgba value in your .fonts.conf from "rgb" to "none". This field
does not mean "no smoothing", but rather, "no subpixel smoothing". But wine
stops smoothing at all when rgba gets equal to none.

Confirmed on Xubuntu 10.04 with big CRT monitor. :)

Ha! Got the bug.
http://source.winehq.org/git/wine.git/?a=blob;f=dlls/winex11.drv/xrender.c;h...

Line 954:
                    case FC_RGBA_NONE: entry->aa_default = AA_None; break;

Should read:
                    case FC_RGBA_NONE: entry->aa_default = AA_Grey; break;

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

--- Comment #16 from Dmitry Timoshkov   2010-05-24 03:25:34 ---
(In reply to comment #15)
> Try changing rgba value in your .fonts.conf from "rgb" to "none". This field
> does not mean "no smoothing", but rather, "no subpixel smoothing". But wine
> stops smoothing at all when rgba gets equal to none.

Why do you think that's not the same thing?

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

--- Comment #17 from Igor Tarasov   2010-05-24 05:30:34 ---
Because there is non-subpixel (grayscale) font anti-aliasing. Sub-pixel
anti-aliasing (implemented as Cleartype in Windows) is intended for usage on
LCD monitors.
http://en.wikipedia.org/wiki/ClearType

So, setting "none" to "rgba" field does not mean "disable all anti-aliasing",
but rather "do not use sub-pixel anti-aliasing, instead use grayscale
anti-aliasing".

Any anti-aliasing could be enabled/disabled through "antialias" field in
.fonts.conf.

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

--- Comment #18 from Alexander Scott-Johns   2010-05-24 21:52:05 ---
(In reply to comment #17)
> Because there is non-subpixel (grayscale) font anti-aliasing. Sub-pixel
> anti-aliasing (implemented as Cleartype in Windows) is intended for usage on
> LCD monitors.
> http://en.wikipedia.org/wiki/ClearType
>
> So, setting "none" to "rgba" field does not mean "disable all anti-aliasing",
> but rather "do not use sub-pixel anti-aliasing, instead use grayscale
> anti-aliasing".
>
> Any anti-aliasing could be enabled/disabled through "antialias" field in
> .fonts.conf.

AJ has fixed both this and the main bug with two patches:

4c206326913706788644e8f4ebc11dcede368d6f
winex11: Fetch the antialias parameter from fontconfig too.

c30688c4d2e265216e4a30a809b6116e23297648
winex11: Allow the Xft configuration to override both registry and fontconfig
parameters.

fontconfig settings don't need changing any more. This bug should be marked
RESOLVED FIXED.

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |RESOLVED
         Resolution|INVALID                     |FIXED

--- Comment #19 from Dmitry Timoshkov   2010-05-26 02:03:19 ---
Fixed then.

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #20 from Alexandre Julliard   2010-05-28 12:51:56 ---
Closing bugs fixed in 1.2-rc2.

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #21 from Vitaliy Margolen   2010-05-28 16:49:57 ---
*** Bug 22912 has been marked as a duplicate of this bug. ***

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

Christoph Korn  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 22765] Fonts no longer anti-aliased

http://bugs.winehq.org/show_bug.cgi?id=22765

--- Comment #22 from Christoph Korn   2010-05-28 17:17:21 ---
Created an attachment (id=28361)
 --> (http://bugs.winehq.org/attachment.cgi?id=28361)
Fonts in Portal

Here are still odd fonts in Portal on wine-1.2-rc2.