[Bug 21217] New: Menu item for "Visual C++ 2005 Express Command Prompt" busted

http://bugs.winehq.org/show_bug.cgi?id=21217

Summary: Menu item for "Visual C++ 2005 Express Command Prompt"
                    busted
           Product: Wine
           Version: 1.1.35
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Keywords: download
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Installing Visual C++ 2005 Express with winetricks works great:
  wget kegel.com/wine/winetricks
  sh winetricks vc2005express
but the menu item it installs in
Applications / Wine / Programs / Visual C++ 2005 Express Edition / Visual
Studio Tools / Visual Studio 2005 Command Prompt 
doesn't work.  When you try it, Gnome gives the error

Text ended before matching quote was found for ". (The text was 'env
WINEPREFIX="/home/dank/.wine" wine "C:\windows\command\start.exe"
"C:\windows\temp\SIT13762.tmp\Visual Studio 2005 Command Promptomspec /k
""C:\Program Files\Microsoft Visual S udio 8\VC\vcvarsall.bat"" x86')

That menu item is stored in

~/"./share/applications/wine/Programs/Visual C++ 2005 Express Edition/Visual
Studio Tools/Visual Studio 2005 Command Prompt.desktop"

which contains the line

Exec=env WINEPREFIX="/home/dank/.wine" wine "C:\windows\command\start.exe"
"C:\windows\temp\SIT13762.tmp\%comspec%" /k ""C:\Program Files\Microsoft
Visual S udio 8\VC\vcvarsall.bat"" x86

which looks broken in several ways: 
first, there's a space instead of a t in Visual Studio 8;
second, the double quotes around vcvarsall.bat look suspicious;
third, the whole "C:\windows\temp\SIT13762.tmp\%comspec%" bit looks just
wrong, that should just be cmd, shouldn't it?

[Bug 21217] Menu item for "Visual C++ 2005 Express Command Prompt" busted

http://bugs.winehq.org/show_bug.cgi?id=21217

--- Comment #1 from Austin English   2010-05-07 11:02:45 ---
May be fixed by
http://source.winehq.org/git/wine.git/?a=commitdiff;h=55e4eba2ec5657f2cac059....

[Bug 21217] Menu item for "Visual C++ 2005 Express Command Prompt" busted

http://bugs.winehq.org/show_bug.cgi?id=21217

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |55e4eba2ec5657f2cac0591f032
                   |                            |3897a1ad848a3
             Status|NEW                         |RESOLVED
                 CC|                            |[e-mail]
          Component|-unknown                    |programs
         Resolution|                            |FIXED

--- Comment #2 from Anastasius Focht  2012-02-12 12:35:07 CST ---
Hello,

the .desktop files are properly generated now:

"Visual Studio 2005 Command Prompt.desktop"

--- snip ---
[Desktop Entry]
Name=Visual Studio 2005 Command Prompt
Exec=env WINEPREFIX="/home/focht/.wine" wine
C:\\windows\\command\\start.exe /Unix
/home/focht/.wine/dosdevices/c:/users/focht/Start\ Menu/Programs/Visual\
C++\ 2005\ Express\ Edition/Visual\ Studio\ Tools/Visual\ Studio\ 2005\
Command\ Prompt.lnk
Type=Application
StartupNotify=true
Comment=Open Visual Studio 2005 Command Prompt
Path=/home/focht/.wine/dosdevices/c:/Program Files/Microsoft Visual Studio
8/VC/
Icon=6F33_cmd.0
--- snip ---

Though it still fails because the created .lnk file contains a cdrom (iso)
drive path before %comspec%

--- snip ---
$ wine start /Unix "/home/focht/.wine/dosdevices/c:/users/focht/Start
Menu/Programs/Visual C++ 2005 Express Edition/Visual Studio Tools/Visual Studio
2005 Command Prompt.lnk"
...
0052:Call shlwapi.SHCreateStreamOnFileW(0013b760 L"C:\users\focht\Start
Menu\Programs\Visual C++ 2005 Express Edition\Visual Studio Tools\Visual
Studio 2005 Command Prompt.lnk",00000020,0032de7c) ret=7eb985c5 
...
0052:Call KERNEL32.MultiByteToWideChar(00000000,00000000,0013b99d
"F:\%comspec%",0000000c,00000000,00000000) ret=7eb9949b 
...
0052:Call KERNEL32.CreateProcessW(00000000,0032c908
L"F:\C:\windows\system32\cmd.exe /k ""C:\Program Files\Microsoft Visual
Studio 8\VC\vcvarsall.bat"" x86
",00000000,00000000,00000000,00000400,00000000,0013b7f0 L"C:\Program
Files\Microsoft Visual Studio 8\VC\",0032bfb0,0032bfa0) ret=7ebc50df
--- snip ---

But that should be a separate bug ;-)

Regards

[Bug 21217] Menu item for "Visual C++ 2005 Express Command Prompt" busted

http://bugs.winehq.org/show_bug.cgi?id=21217

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  2012-02-17 13:50:27 CST ---
Closing bugs fixed in 1.4-rc4.