http://bugs.winehq.org/show_bug.cgi?id=13344
Summary: DPP 3.4.1.1 - Images with "Fit to window" corrupted Product: Wine Version: 1.0-rc1 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: karlpiers@yahoo.co.uk
Canon DPP 3.4.1.1 - When an image is opened in an Edit window with "Fit to window" the image is shifted up by about 20%, and the lower display region is black. Sometimes almost the entire image display is corrupted. This occurs for all image types:- cr2 (raw files), jpeg, and tiffs. (But note: the 50%,100% and 200% views all function correctly)
This bug also affects the before/after comparison when viewed with fit-to-window (in both up/down & left/right modes, and in split single image/single window modes).
If the fit-to-window issue can be resolved DPP would be much easier to use (since this is a raw image converter and an image manipulation tool - seeing the whole image is important). This issue appears to be a constant through each release of DPP and also of wine (see the wine appdb test reports).
http://bugs.winehq.org/show_bug.cgi?id=13344
Karl Piers karlpiers@yahoo.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|1.0-rc1 |1.0-rc2
--- Comment #1 from Karl Piers karlpiers@yahoo.co.uk 2008-05-26 09:50:50 --- Retested with wine 1.0-rc2 and the problem still occurs.
http://bugs.winehq.org/show_bug.cgi?id=13344
James Hawkins truiken@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|1.0-rc2 |1.0-rc1
--- Comment #2 from James Hawkins truiken@gmail.com 2008-05-26 11:29:42 --- Don't change the original reported version.
http://bugs.winehq.org/show_bug.cgi?id=13344
John Sadler john@centricview.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #3 from John Sadler john@centricview.com 2008-06-02 09:14:33 --- *** This bug has been confirmed by popular vote. ***
http://bugs.winehq.org/show_bug.cgi?id=13344
John Sadler john@centricview.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |john@centricview.com
--- Comment #4 from John Sadler john@centricview.com 2008-06-02 09:15:11 --- bug is present with rc3 too.
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #5 from John Sadler john@centricview.com 2008-06-07 17:38:52 --- bug remains in rc4
http://bugs.winehq.org/show_bug.cgi?id=13344
Sergey sergks@rambler.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sergks@rambler.ru
--- Comment #6 from Sergey sergks@rambler.ru 2008-06-14 11:41:09 --- the same bug in RC5!
http://bugs.winehq.org/show_bug.cgi?id=13344
Lukas Jirkovsky l.jirkovsky@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |l.jirkovsky@gmail.com
--- Comment #7 from Lukas Jirkovsky l.jirkovsky@gmail.com 2008-06-18 03:11:59 --- Confirming with 1.0
--- Comment #8 from John Sadler john@centricview.com 2008-06-28 12:42:36 --- Still persists in 1.1.0
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #9 from Lei Zhang thestig@google.com 2008-07-21 12:35:51 --- someone is trying to fix this bug though: http://www.winehq.org/pipermail/wine-devel/2008-July/067528.html
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #10 from Karl Piers karlpiers@yahoo.co.uk 2008-07-22 02:46:52 --- Lei Zhang, thanks very much for posting the link to Mathias Kosch's proposed fix.
I just tried it out in rc2, i.e. in dib.c, function StretchDIBits, changing the very last call to StretchBlt, so that instead of passing abs(height)-heightSrc-ySrc it passes just ySrc.
With the images I then opened in DPP this appears to solve the fit-to-window image problem! (At long last!)
Of course, Mathias Kosch must determine if the fix doesn't break anything else in order to submit it as an official change, but it looks good for those of us who use wine for DPP ...
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #11 from John Sadler john@centricview.com 2008-07-22 10:11:11 --- This really is great news. Nice work Mathias! Can't wait to see this make the build.
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #12 from Mathias Kosch info@mkosch.de 2008-07-27 10:49:39 --- Created an attachment (id=15095) --> (http://bugs.winehq.org/attachment.cgi?id=15095) Screenshot demonstrating the bug
This screenshot demonstrates the problem (for all who want to see). I colored the picture magenta for privacy and bandwidth reasons. As you can see it is shifted upwards.
Unfortunately I didn't yet find time to proceed with the patch development. I would have to run some tests under Wine and Windows to figure out the correct function of "StretchBlt" with DIBs having positive and negative heights. I will proceed when I find some time. As long as this will take you can use my proposed fix. I didn't yet experience any problems with it.
http://bugs.winehq.org/show_bug.cgi?id=13344
Mathias Kosch info@mkosch.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |info@mkosch.de
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #13 from Mathias Kosch info@mkosch.de 2008-09-21 19:15:18 --- I found out my formerly proposed fix does worse than it helps.
However I now provided an official patch: http://www.winehq.org/pipermail/wine-patches/2008-September/061950.html
http://bugs.winehq.org/show_bug.cgi?id=13344
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dank@kegel.com
--- Comment #14 from Dan Kegel dank@kegel.com 2008-12-01 22:30:43 --- And he posted it again: http://www.winehq.org/pipermail/wine-patches/2008-December/065376.html Feedback, anyone?
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #15 from John Sadler john@centricview.com 2008-12-13 05:33:50 --- Is this patch EVER going to make it into the build? What's blocking its acceptance, and is there something I can do to help?
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #16 from Dan Kegel dank@kegel.com 2008-12-13 08:56:28 --- You should ask (more civilly) on wine-devel and/or irc, I think.
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #17 from Mathias Kosch info@mkosch.de 2008-12-13 17:59:59 --- I already did that about two months ago, but it didn't help: http://www.winehq.org/pipermail/wine-devel/2008-October/069783.html
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #18 from Sergey sergks@rambler.ru 2008-12-14 07:27:52 --- Simple replacement of gdi32.dll.so with gdi32.dll.so containing Mathias Kosch's patch in /usr/lib/wine works for me. Mathias, can you attach fixed gdi32 to your message? I have very old file with your first proposed fix (that you said 'did worse than it helped', but worked for me through several wine updates).
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #19 from Mathias Kosch info@mkosch.de 2008-12-14 09:06:51 --- You can find the recent patch here: http://www.winehq.org/pipermail/wine-patches/attachments/20081201/08b47d4d/a...
You should rather use this version than my very first one, because with the first version my test case fails in most cases. With the recent version the test case entirely passes.
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #20 from Dan Kegel dank@kegel.com 2008-12-14 10:20:38 --- Mathias, you should ask Alexandre Julliard on IRC.
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #21 from John Sadler john@centricview.com 2008-12-15 12:01:27 --- (In reply to comment #16)
You should ask (more civilly) on wine-devel and/or irc, I think.
Sorry, didn't intend to offend.
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #22 from Mathias Kosch info@mkosch.de 2008-12-16 15:35:53 --- Today I got a response from Alexandre Julliard. He noticed my patch but didn't yet find time to verify it. So we've got to wait.
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #23 from Lukas Jirkovsky l.jirkovsky@gmail.com 2009-03-01 02:43:38 --- What is the status of this bug? Will we see the patch in some of the upcoming versions of wine?
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #24 from Dan Kegel dank@kegel.com 2009-03-02 02:57:58 --- He posted it again: http://www.winehq.org/pipermail/wine-patches/2009-March/070073.html
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #25 from Mathias Kosch info@mkosch.de 2009-03-02 15:19:43 --- This time Alexandre promised to look at it. So I hope it won't take long.
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #26 from Lukas Jirkovsky l.jirkovsky@gmail.com 2009-03-04 00:43:07 --- Thanks for the fast replies. I really hope that we will see it early.
http://bugs.winehq.org/show_bug.cgi?id=13344
harald@harald-hoyer.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |harald@harald-hoyer.de
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #27 from Lukas Jirkovsky l.jirkovsky@gmail.com 2009-07-04 03:59:45 --- Mathias, maybe you should be more annoying ;-)
I'm using it for quite a long time along with several other apps without any problem.
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #28 from harald@harald-hoyer.de 2009-07-04 04:05:49 --- nag nag, I want this patch, too.. please!
http://bugs.winehq.org/show_bug.cgi?id=13344
Chris Chiappa griffon+winehq@snurgle.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |griffon+winehq@snurgle.org
http://bugs.winehq.org/show_bug.cgi?id=13344
Carlo Pannucci carlo.pannucci@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |carlo.pannucci@gmail.com
--- Comment #29 from Carlo Pannucci carlo.pannucci@gmail.com 2009-11-05 07:05:12 --- Bug still remains in wine 1.1.32
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #30 from Mathias Kosch info@mkosch.de 2009-11-05 17:13:02 --- Sorry, I didn't yet take the time to proceed with the patch. It isn't much work any more, but I want to check some additional things, which take a little time. (I want to check, if other calls inside "StretchDIBits" also show this behaviour.)
CURRENT PROGRESS: Alexandre found out that the recent patch is not correct for every case. The special case with "StretchDIBits" only seems to occur if (nDestWidth == nSrcWidth) and (nDestHeight == nSrcHeight). I also didn't test different parameters for "biCompression" and "biBitCount". So the next patch will be a little more restrictive and will only modify the behavior for known parameter combinations.
http://bugs.winehq.org/show_bug.cgi?id=13344
tudor tudor.suciu@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tudor.suciu@gmail.com
--- Comment #31 from tudor tudor.suciu@gmail.com 2009-11-22 18:12:42 --- i can confirm in wine 1.33 with dpp 3.7.2 that it works with the patch to dib.c What is the problem to include this patch in wine? Does it break anything? The fact that it doesn't take into account all the possible input values doesn't seem to me a good reason not to include it(it solves part of the problem... )
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #32 from Mathias Kosch info@mkosch.de 2009-12-21 13:11:32 --- Yes, the patch breaks some functionality that worked without the patch applied. Neither way is correct and I cannot say if it is more or less correct with the patch applied or not. This is the reason why Alexandre didn't yet accept it.
Since I'm now having winter hollidays I hope I'll find some hours to look at it again and create a better patch.
http://bugs.winehq.org/show_bug.cgi?id=13344
BlackSir blacksir@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |blacksir@gmail.com
--- Comment #33 from BlackSir blacksir@gmail.com 2010-04-13 14:21:50 --- I still have this bug with wine-1.1.31 and DPP 3.8.0
However fix provided by Mathias Kosch works fine. I've compiled patched with http://is.gd/brkjc wine sources and updated just /usr/lib/wine/gdi32.dll.so from them. I haven't seen any drawbacks yet.
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #34 from Mathias Kosch info@mkosch.de 2010-04-26 14:34:00 --- I now spent some time to create an improved version of my patch with the known issues fixed. I didn't yet perform further tests which parameter combinations are effected by the 'special case'. Instead, I restricted the patch to the currently tested parameters (RGB images with 24 or 32 bits).
You can find the recent patch here: http://www.winehq.org/pipermail/wine-patches/2010-April/087789.html
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #35 from BlackSir blacksir@gmail.com 2010-04-27 02:28:13 --- Hi Mathias! I can't compile wine with the latest version of the patch. Make fails with:
gcc -c -I. -I. -I../../include -I../../include -I/usr/include/freetype2 -D__WINESRC__ -D_GDI32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o freetype.o freetype.c freetype.c:166: error: ‘FT_MulFix’ undeclared here (not in a function) freetype.c:166: warning: type defaults to ‘int’ in declaration of ‘pFT_MulFix’ freetype.c: In function ‘WineEngGetOutlineTextMetrics’: freetype.c:5009: error: called object ‘pFT_MulFix’ is not a function <...> freetype.c:5137: error: called object ‘pFT_MulFix’ is not a function make[2]: *** [freetype.o] Error 1 make[2]: Leaving directory `/home/blacksir/Make/wine-1.0.1/dlls/gdi32' make[1]: *** [gdi32] Error 2 make[1]: Leaving directory `/home/blacksir/Make/wine-1.0.1/dlls' make: *** [dlls] Error 2
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #36 from Juan Lang juan_lang@yahoo.com 2010-04-27 10:22:44 --- (In reply to comment #35)
freetype.c:5137: error: called object ‘pFT_MulFix’ is not a function make[2]: *** [freetype.o] Error 1 make[2]: Leaving directory `/home/blacksir/Make/wine-1.0.1/dlls/gdi32'
freetype.c isn't modified part of the patch, so this problem is unrelated. The patch is against current git, not 1.0.1. As always when trying patches, use current git unless the author states otherwise.
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #37 from BlackSir blacksir@gmail.com 2010-04-27 12:01:08 --- (In reply to comment #36)
patch is against current git, not 1.0.1
Whoops, I've accidentally applied the patch to an old version of Wine. DPP works well on wine 1.1.31 with patched gdi32.dll.so (yes, I know the patch should be applied to the current, but it works well with 1.1.31 sources)
http://bugs.winehq.org/show_bug.cgi?id=13344
piwacet davrosmeglos@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |davrosmeglos@gmail.com
--- Comment #38 from piwacet davrosmeglos@gmail.com 2010-05-02 19:37:51 --- Can confirm this patch works with wine 1.1.43. Running DPP 3.8.0.
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #39 from Carlo Pannucci carlo.pannucci@gmail.com 2010-06-26 09:46:00 --- Bug still present in wine 1.2-rc5.
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #40 from Dan Kegel dank@kegel.com 2010-07-11 22:41:01 --- Patch updated, http://www.winehq.org/pipermail/wine-patches/2010-July/090390.html
http://bugs.winehq.org/show_bug.cgi?id=13344
Michael Stefaniuc mstefani@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch CC| |mstefani@redhat.com
http://bugs.winehq.org/show_bug.cgi?id=13344
--- Comment #41 from Austin English austinenglish@gmail.com 2010-07-30 10:39:43 --- May be fixed by http://source.winehq.org/git/wine.git/?a=commitdiff;h=c68589e3dddcd93171b8af...
http://bugs.winehq.org/show_bug.cgi?id=13344
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.2.x
--- Comment #42 from Alexandre Julliard julliard@winehq.org 2010-07-30 10:57:59 --- Should be fixed.
http://bugs.winehq.org/show_bug.cgi?id=13344
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #43 from Alexandre Julliard julliard@winehq.org 2010-07-30 10:58:14 --- Really marking fixed.
http://bugs.winehq.org/show_bug.cgi?id=13344
Tomasz Golinski tomaszg@alpha.uwb.edu.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tomaszg@alpha.uwb.edu.pl
--- Comment #44 from Tomasz Golinski tomaszg@alpha.uwb.edu.pl 2010-07-30 11:33:33 --- I just checked and it works ok. Thanks.
http://bugs.winehq.org/show_bug.cgi?id=13344
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #45 from Alexandre Julliard julliard@winehq.org 2010-07-30 12:55:22 --- Closing bugs fixed in 1.3.0.
http://bugs.winehq.org/show_bug.cgi?id=13344
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.2.x |---
--- Comment #46 from Alexandre Julliard julliard@winehq.org 2010-10-08 10:40:17 CDT --- Removing 1.2.x milestone from bugs fixed in 1.2.1.
-
wine-bugs＠winehq.org