https://bugs.winehq.org/show_bug.cgi?id=39040
Bug ID: 39040 Summary: Excel 2010 enters installation configuration steps then exits Product: Wine Version: 1.7.48 Hardware: x86 OS: Linux Status: NEW Severity: critical Priority: P2 Component: ntdll Assignee: wine-bugs@winehq.org Reporter: caron@codeweavers.com Distribution: ---
Excel 2010 launches but then enters an incomplete installation process. It performs two attempts to complete installation and then closes with the error:
Microsoft Office cannot verify the license for this application. A repair attempt failed or was canceled by the user. The application will now shut down.
1. Install Office 2010 in a clean prefix * riched20 set to native 2. Launch Excel 2010 3. Excel begins to configure, claiming the install was incomplete
Launching Excel 2010 from Wine 1.7.48 works as expected, launching from:
e3c6777edda76f319e5c465faf6c20bb91ed9f17
Shows the above behavior. This is a regression.
Bisect results:
2a904d3bb379282831035e76bf9d30d347511bab is the first bad commit commit 2a904d3bb379282831035e76bf9d30d347511bab Author: Martin Storsjo martin@martin.st Date: Thu Jul 23 10:36:06 2015 +0300
ntdll: Handle partial image load config structs.
:040000 040000 74e5a8c36c2def8aaa89125e318086358a88dbfc ca6bfb2640b7e2be00b87fb9ebbdedc53225a588 M dlls
https://bugs.winehq.org/show_bug.cgi?id=39040
Caron caron@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |2a904d3bb379282831035e76bf9 | |d30d347511bab
https://bugs.winehq.org/show_bug.cgi?id=39040
Caron caron@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wine@martin.st
https://bugs.winehq.org/show_bug.cgi?id=39040
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |sebastian@fds-team.de Severity|critical |normal
--- Comment #1 from Sebastian Lackner sebastian@fds-team.de --- Since only one application is affected severity "normal" seems to be more appropriate.
https://bugs.winehq.org/show_bug.cgi?id=39040
Caron caron@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Excel 2010 enters |Office 2010 applications |installation configuration |enter installation |steps then exits |configuration steps then | |exit Severity|normal |major
--- Comment #2 from Caron caron@codeweavers.com --- With apologies, this morning I only had time to test out Excel 2010 on a pre-existing (clean) install from Wine 1.7.48, testing Excel with latest git (e3c6777edda76f319e5c465faf6c20bb91ed9f17).
I can now confirm that all applications within the Office 2010 suite are affected. My installation of Office 2010 Pro Plus has:
Word OneNote Access Outlook Excel Powerpoint
All of which are affected. The summary has been updated to reflect the additional information.
And I've had a better read of severity settings for the bug tracker. Moving to 'major' since all applications of Office Pro are affected.
https://bugs.winehq.org/show_bug.cgi?id=39040
--- Comment #3 from Sebastian Lackner sebastian@fds-team.de --- Confirming. I would guess it has to do with a missing validation of loadcfg->Size. An additional check like loadcfg_size == loadcfg->Size seems to fix it, but difficult to say if its correct. I fear sooner or later we'll need test for those security cookies. :/
https://bugs.winehq.org/show_bug.cgi?id=39040
--- Comment #4 from Martin Storsjö wine@martin.st --- What are the values of loadcfg_size and loadcfg->Size for the case that breaks now?
For ucrtbase.dll, which was fixed by the referenced commit, loadcfg_size is 64, while loadcfg->Size is 72.
Are things fixed if you add an "loadcfg->Size >= offsetof(IMAGE_LOAD_CONFIG_DIRECTORY, SecurityCookie) + sizeof(loadcfg->SecurityCookie) &&" to the condition?
https://bugs.winehq.org/show_bug.cgi?id=39040
--- Comment #5 from Sebastian Lackner sebastian@fds-team.de --- (In reply to Martin Storsjö from comment #4)
What are the values of loadcfg_size and loadcfg->Size for the case that breaks now?
For ucrtbase.dll, which was fixed by the referenced commit, loadcfg_size is 64, while loadcfg->Size is 72.
Its exactly the same for the Office 2010 executables.
Are things fixed if you add an "loadcfg->Size >= offsetof(IMAGE_LOAD_CONFIG_DIRECTORY, SecurityCookie) + sizeof(loadcfg->SecurityCookie) &&" to the condition?
No, that doesn't seem to be sufficient.
https://bugs.winehq.org/show_bug.cgi?id=39040
--- Comment #6 from Sebastian Lackner sebastian@fds-team.de --- I did a couple more tests, and when using a Windows version Vista or Windows 8, the app still works fine here (without any patches). Could it maybe be related to the fact that Windows XP didn't have kernel support for SecurityCookies yet (as far as I know), and the app somehow explicitly checks that?
https://bugs.winehq.org/show_bug.cgi?id=39040
--- Comment #7 from Sebastian Lackner sebastian@fds-team.de --- Created attachment 52038 --> https://bugs.winehq.org/attachment.cgi?id=52038 ntdll: Move cookie initialization code from memory management to loader.
Proposed patch.
The reason seems to be that Office manually maps a couple of files, and security cookie initialization should only happen in the loader, not in the virtual memory management.
Before submitting it to wine-patches, I would like to make sure that it doesn't break any of the other things which were fixed before. Those security cookie changes already have caused way too many regressions. ;)
https://bugs.winehq.org/show_bug.cgi?id=39040
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #52038|0 |1 is obsolete| |
--- Comment #8 from Sebastian Lackner sebastian@fds-team.de --- Created attachment 52039 --> https://bugs.winehq.org/attachment.cgi?id=52039 ntdll: Move cookie initialization code from memory management to loader. (v2)
Oops, small typo fixed.
https://bugs.winehq.org/show_bug.cgi?id=39040
Sebastian Lackner sebastian@fds-team.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv@dawncrow.de
https://bugs.winehq.org/show_bug.cgi?id=39040
--- Comment #9 from Martin Storsjö wine@martin.st --- This fix seems to work fine (i.e. not breaking anything) for loading ucrtbase.dll - thanks!
https://bugs.winehq.org/show_bug.cgi?id=39040
--- Comment #10 from Caron caron@codeweavers.com --- (In reply to Sebastian Lackner from comment #8)
Created attachment 52039 [details] ntdll: Move cookie initialization code from memory management to loader. (v2)
This fixes Office 2010's installation and the configuration on launch issue. It returns functionality to Office 2010 applications installed in a winxp prefix; a necessary workaround for bug 38838.
https://bugs.winehq.org/show_bug.cgi?id=39040
Ronan ronisbr@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ronisbr@gmail.com
--- Comment #11 from Ronan ronisbr@gmail.com --- Hi guys,
I installed wine 1.7.49 and my existing Office installation does not work anymore. I am having this bug. I think that this patch was already applied to 1.7.49 as we can see in http://www.wine-staging.com/news/2015-08-09-release-1.7.49.html
Can anyone help me?
https://bugs.winehq.org/show_bug.cgi?id=39040
--- Comment #12 from Caron caron@codeweavers.com --- (In reply to Ronan from comment #11)
Hi guys,
I installed wine 1.7.49 and my existing Office installation does not work anymore. I am having this bug. I think that this patch was already applied to 1.7.49 as we can see in http://www.wine-staging.com/news/2015-08-09-release-1.7.49.html
Can anyone help me?
That's Wine-Staging, not pure Wine. Helping with this really depends on how you installed Wine. It would be better to seek help in the forums:
or on irc:
https://bugs.winehq.org/show_bug.cgi?id=39040
Marcus Meissner marcus@jet.franken.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |marcus@jet.franken.de
https://bugs.winehq.org/show_bug.cgi?id=39040
Rosanne DiMesio dimesio@earthlink.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |38076fa63308417429617f959ce | |44315b604424c Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #13 from Rosanne DiMesio dimesio@earthlink.net --- The patch was committed, 38076fa63308417429617f959ce44315b604424c.
https://bugs.winehq.org/show_bug.cgi?id=39040
tomasvandenooijevaer@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tomasvandenooijevaer@gmail. | |com
--- Comment #14 from tomasvandenooijevaer@gmail.com --- *** Bug 39102 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=39040
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #15 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.50.
-
wine-bugs＠winehq.org