https://bugs.winehq.org/show_bug.cgi?id=48923
Bug ID: 48923 Summary: [REGRESSION] Heroes 4 crashes on start Product: Wine Version: 5.5 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: hi-angel@yandex.ru Distribution: ---
Created attachment 66883 --> https://bugs.winehq.org/attachment.cgi?id=66883 wine5.5 heroes4 crash
Heroes 4 crashes on start. It happens in 5.5 and 5.6. Last known working version is 5.4, it works upon downgrading.
This confirmed to be happening on two computers with 2 distros: Fedora and Archlinux.
Stacktrace for 5.5 version is attached
https://bugs.winehq.org/show_bug.cgi?id=48923
joaopa jeremielapuree@yahoo.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree@yahoo.fr
--- Comment #1 from joaopa jeremielapuree@yahoo.fr --- Here is a link to learn how to do a regression test: https://wiki.winehq.org/Regression_Testing
Thanks in advance for helping wine project.
https://bugs.winehq.org/show_bug.cgi?id=48923
Jeff Zaroyko jeffz@jeffz.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Summary|[REGRESSION] Heroes 4 |Heroes of Might and Magic |crashes on start |IV crashes on start
https://bugs.winehq.org/show_bug.cgi?id=48923
Michael McGuire spoon0042@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gofmanp@gmail.com, | |spoon0042@hotmail.com
--- Comment #2 from Michael McGuire spoon0042@hotmail.com --- For me it only seemed to crash in full screen. It also seemed to refuse to set window mode until I used a virtual desktop. I think. Anyway:
530a3d94de949030f8d74bacd6c20986b32f1a31 is the first bad commit commit 530a3d94de949030f8d74bacd6c20986b32f1a31 Author: Paul Gofman gofmanp@gmail.com Date: Thu Mar 26 16:09:41 2020 +0300
ddraw: Deny locking lost surfaces.
Signed-off-by: Paul Gofman gofmanp@gmail.com Signed-off-by: Henri Verbeet hverbeet@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
:040000 040000 27ec92735d9f52c9653f8988c237f065740f38ba 4063e6e17d501a0a09b727ae4c15ae294c526b5b M dlls
https://bugs.winehq.org/show_bug.cgi?id=48923
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |530a3d94de949030f8d74bacd6c | |20986b32f1a31
https://bugs.winehq.org/show_bug.cgi?id=48923
--- Comment #3 from Paul Gofman gofmanp@gmail.com --- Created attachment 66885 --> https://bugs.winehq.org/attachment.cgi?id=66885 Never consider system memory surface lost
The game locks system memory offscreen surface while device is lost. The blamed commit has triggered the problem (locking lost surfaces previously succeded), but it seems that actual bug is that Wine ddraw can consider system memory surface lost. The attached patch should be fixing the issue.
https://bugs.winehq.org/show_bug.cgi?id=48923
--- Comment #4 from Konstantin hi-angel@yandex.ru --- (In reply to Paul Gofman from comment #3)
Created attachment 66885 [details] Never consider system memory surface lost
The game locks system memory offscreen surface while device is lost. The blamed commit has triggered the problem (locking lost surfaces previously succeded), but it seems that actual bug is that Wine ddraw can consider system memory surface lost. The attached patch should be fixing the issue.
Thank you! That was quick!
I confirm that applying this patches fixes the problem.
https://bugs.winehq.org/show_bug.cgi?id=48923
--- Comment #5 from Konstantin hi-angel@yandex.ru --- Michael, btw thank you for the bisect! The discussion here was just happening so fast that by the time I still was checking whether bisect results are reproducible for me a patch got posted already :)
https://bugs.winehq.org/show_bug.cgi?id=48923
Paul Gofman pgofman@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pgofman@codeweavers.com
--- Comment #6 from Paul Gofman pgofman@codeweavers.com --- Should be fixed by https://source.winehq.org/git/wine.git/commit/3acc26dc22ada3f24fcd094f5a6648...
https://bugs.winehq.org/show_bug.cgi?id=48923
--- Comment #7 from Michael McGuire spoon0042@hotmail.com --- Works as far as I can tell, thanks.
(Changing resolution or full screen setting is wonky but that could be nothing to do with wine.)
https://bugs.winehq.org/show_bug.cgi?id=48923
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |3acc26dc22ada3f24fcd094f5a6 | |64898b4ba6e74 Status|UNCONFIRMED |RESOLVED
--- Comment #8 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- Report as fixed.
https://bugs.winehq.org/show_bug.cgi?id=48923
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #9 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 5.7.