[Bug 29759] New: In exclusive mode/non fullscreen app, moving the cursor can result in resizing window if cursor is "virtually" on an window border

http://bugs.winehq.org/show_bug.cgi?id=29759

Bug #: 29759
           Summary: In exclusive mode/non fullscreen app, moving the
                    cursor can result in resizing window if cursor is
                    "virtually" on an window border
           Product: Wine
           Version: 1.4-rc1
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-dinput
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 38639
  --> http://bugs.winehq.org/attachment.cgi?id=38639
Attached is a capture when the problem is happening, I just fired after turning
right, and the window is now in "resize mode"

Tested on Skulltag 0.98d (windows version), but I guess similar behavior could
happen on other windowed app in exclusive mode.

For example, in windowed mode, when I move the mouse to the right (turning the
player right) and click (to fire), it will result in the window trying to
resize to the right instead of firing, and then doing garbage (firing
automatically, that sort of things).

I tested in "Virtual screen" mode of winecfg, I don't know if it happens in non
virtual screen mode.

I "guess" this bug is linked to this new feature :
"dinput: Clip the mouse to the entire window instead of a 1x1 rectangle in
exclusive mode."
Maybe the new rectangle should be 1 pixel smaller than the window size in order
to avoid system from catching the resize event.

I tried downgrading to the default ubuntu 11.10 version (1.3.28) and the bug
disappear.

Attached is a capture when the problem is happening, I just fired after turning
right, and the window is now in "resize mode"

[Bug 29759] In exclusive mode/non fullscreen app, moving the cursor can result in resizing window if cursor is "virtually" on an window border

http://bugs.winehq.org/show_bug.cgi?id=29759

--- Comment #1 from Alexandre Julliard  2012-02-01 06:40:48 CST ---
The rectangle is already one pixel smaller. If the window manager starts a
resize at that point it's a bug. What do you mean by "virtual screen"? Are you
using a desktop window? Is the app itself in windowed mode or is that the
desktop?

[Bug 29759] In exclusive mode/non fullscreen app, moving the cursor can result in resizing window if cursor is "virtually" on an window border

http://bugs.winehq.org/show_bug.cgi?id=29759

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor

--- Comment #2 from [e-mail] 2012-02-01 06:59:14 CST ---
I am using both :
- windowed mode in my game
- "Emulate a virtual desktop" in winecfg > Graphics (sorry, I first translated
the name from french without checking if it was correct)

I did some more testing, I have finally been able to test without virtual
desktop (I had problems without this option as only one direct draw resolution
is reported to the game : 2960x1050, which is not very well supported by it)

And the bug does not happen in non virtual desktop mode.

So this bug is related to the virtual desktop mode only.

Just to make things clear, the window which is receiving the resize event is
the game window, not the virtual desktop window.
This doesn't happen if the game is in fullscreen mode, which makes the bug
quite rare and not very important (I've switched importance to minor).

[Bug 29759] In exclusive mode/non fullscreen app, moving the cursor can result in resizing window if cursor is "virtually" on an window border

http://bugs.winehq.org/show_bug.cgi?id=29759

--- Comment #3 from [e-mail] 2012-02-01 07:07:36 CST ---
Created attachment 38640
  --> http://bugs.winehq.org/attachment.cgi?id=38640
Better capture, with window mode / virtual desktop / and the resize event
triggered

[Bug 29759] In exclusive mode/non fullscreen app, moving the cursor can result in resizing window if cursor is "virtually" on an window border

http://bugs.winehq.org/show_bug.cgi?id=29759

--- Comment #4 from [e-mail] 2012-02-01 07:14:37 CST ---
I also tried with zdaemon 10801, same problem in the same conditions (window
mode, virtual desktop).
I did not find another game to try yet

[Bug 29759] In exclusive mode/non fullscreen app, moving the cursor can result in resizing window if cursor is "virtually" on an window border

http://bugs.winehq.org/show_bug.cgi?id=29759

--- Comment #5 from Alexandre Julliard  2012-02-01 07:24:15 CST ---
Created attachment 38642
  --> http://bugs.winehq.org/attachment.cgi?id=38642
Clip cursor to client area

OK, I see what you mean now. We should probably limit clipping to the client
area, something like this patch.

[Bug 29759] In exclusive mode/non fullscreen app, moving the cursor can result in resizing window if cursor is "virtually" on an window border

http://bugs.winehq.org/show_bug.cgi?id=29759

--- Comment #6 from [e-mail] 2012-02-01 08:37:30 CST ---
Tested and approved :)

I've download 1.4-rc1 sources, just changed these two lines, compiled, and it
works now in virtual desktop + windowed mode.
Of course I don't know if there are any side effects...

I did not change the status, as I am not sure what to put there, and if I am
really supposed to change anything...

[Bug 29759] In exclusive mode/non fullscreen app, moving the cursor can result in resizing window if cursor is "virtually" on an window border

http://bugs.winehq.org/show_bug.cgi?id=29759

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |a1580bba704d0bbf7a6353a4144
                   |                            |2f8886ea5a113
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Alexandre Julliard  2012-02-01 11:23:55 CST ---
Fixed by a1580bba704d0bbf7a6353a41442f8886ea5a113.

[Bug 29759] In exclusive mode/non fullscreen app, moving the cursor can result in resizing window if cursor is "virtually" on an window border

http://bugs.winehq.org/show_bug.cgi?id=29759

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  2012-02-02 13:37:30 CST ---
Closing bugs fixed in 1.4-rc2.