[Bug 28298] New: riched20/editor.ok cursort position test flaky

http://bugs.winehq.org/show_bug.cgi?id=28298

Summary: riched20/editor.ok cursort position test flaky
           Product: Wine
           Version: 1.3.27
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: richedit
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

I just had a test fail (under WINEDEBUG=warn+heap, but I doubt that matters)
like this:

../../../tools/runtest -q -P wine -M riched20.dll -T ../../.. -p
riched20_test.exe.so editor.c && touch editor.ok
...
editor.c:6026: Test failed: Cursor is at 0 instead of 8

That's not a new problem; it was mentioned back in
http://www.winehq.org/pipermail/wine-devel/2008-September/069299.html
and showed up here:
http://www.winehq.org/pipermail/wine-devel/2010-December/088198.html

[Bug 28298] riched20/editor.ok cursor position test flaky

http://bugs.winehq.org/show_bug.cgi?id=28298

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|riched20/editor.ok cursort  |riched20/editor.ok cursor
                   |position test flaky         |position test flaky

[Bug 28298] riched20/editor.ok cursor position test flaky

http://bugs.winehq.org/show_bug.cgi?id=28298

--- Comment #1 from Dan Kegel  2011-09-08 12:23:44 CDT ---
There's some chance this only happens when the user touches
the keyboard or mouse during the test.  I just saw this again
on one machine, so I'll try running it in a loop for a while.

[Bug 28298] riched20/editor.ok cursor position test flaky

http://bugs.winehq.org/show_bug.cgi?id=28298

Dylan Smith  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Dylan Smith  2011-09-26 01:34:27 CDT ---
I sent a patch to wine-patches that I think will fix the issue.

riched20/tests: Avoid using flaky method of simulating typing.
http://www.winehq.org/pipermail/wine-patches/2011-September/107243.html

Hopefully after this gets applied it shouldn't be possible for the user to
break the riched20 tests by doing something while running them.

[Bug 28298] riched20/editor.ok cursor position test flaky

http://bugs.winehq.org/show_bug.cgi?id=28298

--- Comment #3 from Dylan Smith  2011-09-27 00:58:12 CDT ---
(In reply to comment #2)
> I sent a patch to wine-patches that I think will fix the issue.
>
> riched20/tests: Avoid using flaky method of simulating typing.
> http://www.winehq.org/pipermail/wine-patches/2011-September/107243.html

Patch accepted as commit 4e53a7071533f34bd3769af4550bb4e23cf5954c

[Bug 28298] riched20/editor.ok cursor position test flaky

http://bugs.winehq.org/show_bug.cgi?id=28298

--- Comment #4 from Dylan Smith  2011-09-27 01:00:08 CDT ---
(In reply to comment #3)
> Patch accepted as commit 4e53a7071533f34bd3769af4550bb4e23cf5954c

Oops, wrong commit hash. That should be
fdb2bc4be99ca9f98a283d1b61d48753b1558ecd

[Bug 28298] riched20/editor.ok cursor position test flaky

https://bugs.winehq.org/show_bug.cgi?id=28298

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |testcase
      Fixed by SHA1|                            |fdb2bc4be99ca9f98a283d1b61d
                   |                            |48753b1558ecd
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Austin English  ---
(In reply to Dylan Smith from comment #4)
> (In reply to comment #3)
> > Patch accepted as commit 4e53a7071533f34bd3769af4550bb4e23cf5954c
>
> Oops, wrong commit hash. That should be
> fdb2bc4be99ca9f98a283d1b61d48753b1558ecd

No reply, assuming fixed.

[Bug 28298] riched20/editor.ok cursor position test flaky

https://bugs.winehq.org/show_bug.cgi?id=28298

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.37.

[Bug 28298] riched20/editor.ok cursor position test flaky

https://bugs.winehq.org/show_bug.cgi?id=28298

Saulius K.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]