[Bug 9917] New: Add X11 child window for client area

http://bugs.winehq.org/show_bug.cgi?id=9917

Summary: Add X11 child window for client area
           Product: Wine
           Version: 0.9.46.
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P1
         Component: wine-x11driver
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

The number of pixel formats which can be used in OpenGL is limited due to
constraints of the Wine X11 Driver. At Wine startup an X visual is selected
which is used for creating an X11 Window. This Window is in general reused for
OpenGL. In Windows OpenGL the pixel format is set when you want to use OpenGL.
(So in case of Wine we select a pixel format before actually setting up OpenGL;
second Windows OpenGL doesn't allow changing the pixel format).

Now thanks to the xcomposite/pixmap backends for child window rendering we can
enable multiple pixel formats. The use of those backends has performance
limitations, so far that reason only 1 pixel format is still offered.

We need to readd an X11 child window for the client area of the toplevel
window. This will help fullscreen OpenGL/D3D programs. For apps that use child
windows we use the xcomposite/pixmap backend.

[Bug 9917] Add X11 child window for client area

http://bugs.winehq.org/show_bug.cgi?id=9917

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.0.0

--- Comment #1 from Roderick Colenbrander   2007-10-06 07:19:34 ---
This bug should be fixed for Wine 1.0

[Bug 9917] Add X11 child window for client area

http://bugs.winehq.org/show_bug.cgi?id=9917

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |7866

[Bug 9917] Add X11 child window for client area

http://bugs.winehq.org/show_bug.cgi?id=9917

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |9898

[Bug 9917] Add X11 child window for client area

http://bugs.winehq.org/show_bug.cgi?id=9917

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |4935

[Bug 9917] Add X11 child window for client area

http://bugs.winehq.org/show_bug.cgi?id=9917

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |8694

[Bug 9917] Add X11 child window for client area

http://bugs.winehq.org/show_bug.cgi?id=9917

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |9920

[Bug 9917] Add X11 child window for client area

http://bugs.winehq.org/show_bug.cgi?id=9917

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|4935                        |

[Bug 9917] Add X11 child window for client area

http://bugs.winehq.org/show_bug.cgi?id=9917

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|7866                        |

[Bug 9917] Add X11 child window for client area

http://bugs.winehq.org/show_bug.cgi?id=9917

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|8694                        |

[Bug 9917] Add X11 child window for client area

http://bugs.winehq.org/show_bug.cgi?id=9917

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|9898                        |

[Bug 9917] Add X11 child window for client area

http://bugs.winehq.org/show_bug.cgi?id=9917

Jaime Rave  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 9917] Add X11 child window for client area

http://bugs.winehq.org/show_bug.cgi?id=9917

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Roderick Colenbrander   2008-02-21 07:51:32 ---
This bug has been fixed.

[Bug 9917] Add X11 child window for client area

http://bugs.winehq.org/show_bug.cgi?id=9917

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Dan Kegel   2008-02-21 18:25:16 ---
What apps does this improve?

[Bug 9917] Add X11 child window for client area

http://bugs.winehq.org/show_bug.cgi?id=9917

--- Comment #4 from Roderick Colenbrander   2008-02-22 02:27:01 ---
Roughly speaking the client area of an application is the area below the
'menu'. The 3d view of applications without a menu or with just a filemenu is a
real X11 window now. Applications like Google Earth use 'child windows'.

The patch fixes a lot of Direct3D and OpenGL which only have a menu with a 3d
view. Examples are Direct3D samples, Weatherscope and others.

Further right now there is a limit on the opengl pixel formats. This is the
first step in lifting that limit. That will fix most remaining opengl bugs (a
lot of apps are picky about the opengl formats, e.g. Sketchup). Second the
proper format can improve performance upto 20% in some cases.

[Bug 9917] Add X11 child window for client area

http://bugs.winehq.org/show_bug.cgi?id=9917

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Dan Kegel   2008-02-22 11:39:43 ---
0.9.56 released, so closing all bugs marked as RESOLVED FIXED.

[Bug 9917] Add X11 child window for client area

http://bugs.winehq.org/show_bug.cgi?id=9917

Mateus César Gröess  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Mateus César Gröess   2008-02-24 07:18:32 ---
With Wine 0.9.56, the NES emulator "Nestopia"
(http://nestopia.sourceforge.net), D3D9 application, now correctly shows the
top menu. Horever, the behavior of the status bar is still not right,
disappearing or partially displayed sometimes (eg: when switching from File to
Machine menu). Should this change also fix the problem with status bar?

Free NES ROMs to test: http://www.zophar.net/roms/nes.html

This may be a problem with my setup, see why (sorry for long explanation):

My video card currently is an ancient Voodoo3 3000 16MB and this app
crashes at startup when DRI is active. Changing X11 color depth from 16bit to
24bit disables DRI (the tdfx driver only allows it with 16bit, because of
hardware limitation) then I could run without crashes. If I comment out the
line where the crash occurs (dlls/wined3d/device.c:6885), I can run the
application with DRI enabled, but when load a ROM on it, lots of
GL_INVALID_ENUM errors are displayed at shell output and when exit the app
there is a crash (glibc detected *** free(): invalid pointer). If I exit the
app without load a ROM, no crash happens. Also, with DRI enabled or disabled,
messages like the following are displayed when a ROM is playing:

err:d3d_surface:surface_prepare_system_memory Surface without memory or pbo has
SFLAG_INSYSMEM set!

[Bug 9917] Add X11 child window for client area

http://bugs.winehq.org/show_bug.cgi?id=9917

--- Comment #7 from Mateus César Gröess   2008-03-10 09:02:30 ---
Created an attachment (id=11298)
 --> (http://bugs.winehq.org/attachment.cgi?id=11298)
Problems to display status bar correctly.

Now I'm using a PC at work to test Wine 0.9.57, with an integrated Intel 865G
video chipset able to do DRI with large textures. The problem I reported about
the D3D window and status bar also happens on this computer. The status bar
disappears when the menu is accessed. If I alternate between windows and the
Nestopia window stay behind other apps, then when I switch back to Nestopia the
status bar reappears. If I minimize Nestopia window, then restore it to its
previous size, the entire window doesn't redraw itself anymore and the menu
becomes inaccessible, but I'm able to close the app normally.

If these problems are related with the "X11 child window for client area",
should this bugzilla entry be reopened? If no, are there another bugzilla
reports about these problems?

I am really not worried about this app in particular, but about other apps that
may suffer these issues.

[Bug 9917] Add X11 child window for client area

http://bugs.winehq.org/show_bug.cgi?id=9917

--- Comment #8 from Roderick Colenbrander   2008-03-10 14:42:40 ---
Alexandre said that most of the time the status bar is a child window, so it
isn't this bug. Personally I think it is likely some d3d child window bug.

[Bug 9917] Add X11 child window for client area

http://bugs.winehq.org/show_bug.cgi?id=9917

--- Comment #9 from Mateus César Gröess   2008-03-10 20:56:44 ---
Thanks Roderick, I reported this problem as bug 11985.

[Bug 9917] Add X11 child window for client area

http://bugs.winehq.org/show_bug.cgi?id=9917

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|All                         |Other
         OS/Version|All                         |other

--- Comment #10 from Austin English  2012-02-23 15:11:07 CST ---
Removing deprecated 'All' Platform/OS.