[Bug 32490] New: Graphical issues in Inquisitor (red squares painted on the screen)

http://bugs.winehq.org/show_bug.cgi?id=32490

Bug #: 32490
           Summary: Graphical issues in Inquisitor (red squares painted on
                    the screen)
           Product: Wine
           Version: 1.5.19
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 42861
  --> http://bugs.winehq.org/attachment.cgi?id=42861
terminal output

Inquisitor is an RPG released in 2012. I guess it uses DirectX8 (or DX7?)
because only +d3d8 produces output, not +d3d9.

Red squares are present on the screen while in the menus as well as in the main
game. This makes the game unplayable. I tested this bug with a Nvidia gfx card:
both the open source Nouveau and the binary drivers show the same problem.
Wine 1.2.3, 1.4.1, 1.5.19 etc. have the reported problem.
No demo available. Let me know if you need a debug log.

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

http://bugs.winehq.org/show_bug.cgi?id=32490

--- Comment #1 from GyB  2012-12-19 14:37:01 CST ---
Created attachment 42862
  --> http://bugs.winehq.org/attachment.cgi?id=42862
screenshot

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

http://bugs.winehq.org/show_bug.cgi?id=32490

Emmanuel Anne  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Emmanuel Anne  2012-12-20 17:22:11 CST ---
After testing the bug is still here in 1.5.19, making the game totally
unplayable.
The odd thing is that there are 2 ini files and you can edit them for
interesting results :
(in the game directory in program files /GameData)

d3dparams.ini : with this one you can set the resolution, handy with lcd
screens which do not like 1024x768
gfx.ini : with the one you can set
CreateLogFile=1

to get a log file, then start the game and exit with f4 when you reach the
title screen full of red squares.
You'll get in the log file a lot of textures which could not be read !
I tried to follow it with strace, and it doesn't even seem to try to read the
textures from its data files, it opens them, polls them with epoll_wait (?),
but it never reads from them, so it tries to read the textures directly from
the file system, and of course it doesn't find them.

The errors reported in the log file do not appear when the game runs normally
(either from a native windows installation or from a virtualbox machine).

I hope it helps to fix this, very annoying bug !

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

http://bugs.winehq.org/show_bug.cgi?id=32490

--- Comment #3 from John  2013-01-05 12:44:26 CST ---
Created attachment 43095
  --> http://bugs.winehq.org/attachment.cgi?id=43095
Game's log file

Log file from Inquisitor showing it's errors loading textures.

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

http://bugs.winehq.org/show_bug.cgi?id=32490

Paul The Tall  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Paul The Tall  2013-03-12 16:30:29 CDT ---
Problem is still in 1.5.25 someone can take a look?

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

http://bugs.winehq.org/show_bug.cgi?id=32490

Sean Broadhurst  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Sean Broadhurst  2013-08-11 06:19:51 CDT ---
The bug is still present in 1.7.0, and affects the Steam version of the game as
well.

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

http://bugs.winehq.org/show_bug.cgi?id=32490

Christopher Larson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

https://bugs.winehq.org/show_bug.cgi?id=32490

Lucian Poston  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

https://bugs.winehq.org/show_bug.cgi?id=32490

--- Comment #6 from Lucian Poston  ---
Reproducible in wine 1.7.29

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

https://bugs.winehq.org/show_bug.cgi?id=32490

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

https://bugs.winehq.org/show_bug.cgi?id=32490

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|directx-d3d                 |kernel32

--- Comment #7 from Béla Gyebrószki  ---
Still present in wine-1.7.34-60-gd6450cf.
This bug makes the game unplayable.

What seemed to be a graphical problem is actually a bug in Wine's kernel32
module.
The following patch from wine-staging fixes the problem for me:
https://github.com/wine-compholio/wine-staging/blob/master/patches/libs-Unic...

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

https://bugs.winehq.org/show_bug.cgi?id=32490

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #8 from Béla Gyebrószki  ---
Still present in 1.7.51, tested with the GOG.com version.

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

https://bugs.winehq.org/show_bug.cgi?id=32490

Michael Müller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |STAGED
                 CC|                            |[e-mail]
    Staged patchset|                            |https://github.com/wine-com
                   |                            |pholio/wine-staging/tree/ma
                   |                            |ster/patches/libs-Unicode_C
                   |                            |ollation

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

https://bugs.winehq.org/show_bug.cgi?id=32490

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from [e-mail] ---
Created attachment 52690
  --> https://bugs.winehq.org/attachment.cgi?id=52690
Red squares in main menu

This issue still occurs in WINE 1.7.53 with version 1.10.17 EN from GOG.

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

https://bugs.winehq.org/show_bug.cgi?id=32490

--- Comment #10 from [e-mail] ---
Created attachment 52691
  --> https://bugs.winehq.org/attachment.cgi?id=52691
Terminal output from 32-bit WINE 1.7.53

[Bug 32490] Graphical issues in Inquisitor ( red squares painted on the screen)

https://bugs.winehq.org/show_bug.cgi?id=32490

--- Comment #11 from Béla Gyebrószki  ---
Still present in 1.9.22.

[Bug 32490] Graphical issues in Inquisitor ( red squares painted on the screen)

https://bugs.winehq.org/show_bug.cgi?id=32490

Jan Havran  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Jan Havran  ---
This issue still occurs in Wine 2.6 with version 1.10.17 EN from GOG.
I can confirm that in Wine Staging (2.5) it is fixed.

Some related discusion about the red squares:
-https://www.gog.com/forum/inquisitor/many_hours_in_and_now_the_game_will_not...
-https://www.gog.com/forum/inquisitor/corrupted_saves
-https://steamcommunity.com/app/241620/discussions/0/558753804320836723/

Also some Windows users are experiencing this after few hours (memory leak?)

[Bug 32490] Graphical issues in Inquisitor ( red squares painted on the screen)

https://bugs.winehq.org/show_bug.cgi?id=32490

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
    Staged patchset|https://github.com/wine-com |https://github.com/wine-sta
                   |pholio/wine-staging/tree/ma |ging/wine-staging/tree/mast
                   |ster/patches/libs-Unicode_C |er/patches/libs-Unicode_Col
                   |ollation                    |lation

[Bug 32490] Graphical issues in Inquisitor ( red squares painted on the screen)

https://bugs.winehq.org/show_bug.cgi?id=32490

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from joaopa  ---
Does the bug still occur with wine-4.7?

[Bug 32490] Graphical issues in Inquisitor ( red squares painted on the screen)

https://bugs.winehq.org/show_bug.cgi?id=32490

--- Comment #14 from Béla Gyebrószki  ---
(In reply to joaopa from comment #13)
> Does the bug still occur with wine-4.7?

Yes it does.

wine-4.7-66-g8039941c52

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32490

--- Comment #15 from Béla Gyebrószki  ---
Upstream commit 098e71ad61e0112389bf5f214b531311005f5cbe
somehow breaks the staging patch so it no longer fixes the problem.

Wine-5.0-rc1

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32490

--- Comment #16 from Alistair Leslie-Hughes  ---
(In reply to Béla Gyebrószki from comment #15)
> Upstream commit 098e71ad61e0112389bf5f214b531311005f5cbe
> somehow breaks the staging patch so it no longer fixes the problem.
>
> Wine-5.0-rc1

Just confirming that wine and wine-staging both display the same issue now?

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32490

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://store.steampowered.
                   |                            |com/app/241620/Inquisitor/

--- Comment #17 from Béla Gyebrószki  ---
(In reply to Alistair Leslie-Hughes from comment #16)
> (In reply to Béla Gyebrószki from comment #15)
> > Upstream commit 098e71ad61e0112389bf5f214b531311005f5cbe
> > somehow breaks the staging patch so it no longer fixes the problem.
> >
> > Wine-5.0-rc1
>
> Just confirming that wine and wine-staging both display the same issue now?

Yep, that's exactly what happened.

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32490

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #18 from Zebediah Figura  ---
(In reply to Béla Gyebrószki from comment #15)
> Upstream commit 098e71ad61e0112389bf5f214b531311005f5cbe
> somehow breaks the staging patch so it no longer fixes the problem.
>
> Wine-5.0-rc1

This should be addressed by
https://github.com/wine-staging/wine-staging/commit/db1f94bae4e9cb591ba962f1d0d7ca21cfd87d8f.

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32490

--- Comment #19 from Béla Gyebrószki  ---
(In reply to Zebediah Figura from comment #18)
> This should be addressed by
> https://github.com/wine-staging/wine-staging/commit/
> db1f94bae4e9cb591ba962f1d0d7ca21cfd87d8f.

Fixed indeed, thanks for taking care of the problem.

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32490

--- Comment #20 from joaopa  ---
Is Dmitry's patch uncorrect. It was created in 2003 and has not been merged
yet.

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32490

--- Comment #21 from Dmitry Timoshkov  ---
(In reply to joaopa from comment #20)
> Is Dmitry's patch uncorrect. It was created in 2003 and has not been merged
> yet.

The staged patch has been hijacked from internal Codeweavers source tracker by
someone without the author (me) or the owner of the patch (Codeweavers)
informed in any form. It's not clear how to proceed further in this case.

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32490

--- Comment #22 from Austin English  ---
(In reply to Dmitry Timoshkov from comment #21)
> (In reply to joaopa from comment #20)
> > Is Dmitry's patch uncorrect. It was created in 2003 and has not been merged
> > yet.
>
> The staged patch has been hijacked from internal Codeweavers source tracker
> by someone without the author (me) or the owner of the patch (Codeweavers)
> informed in any form. It's not clear how to proceed further in this case.

Given that the code is LGPL licensed, I don't think considering it 'hijacked'
is appropriate.

It's publicly available here:
https://media.codeweavers.com/pub/crossover/source/

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32490

--- Comment #23 from Dmitry Timoshkov  ---
(In reply to Austin English from comment #22)
> (In reply to Dmitry Timoshkov from comment #21)
> > (In reply to joaopa from comment #20)
> > > Is Dmitry's patch uncorrect. It was created in 2003 and has not been merged
> > > yet.
> >
> > The staged patch has been hijacked from internal Codeweavers source tracker
> > by someone without the author (me) or the owner of the patch (Codeweavers)
> > informed in any form. It's not clear how to proceed further in this case.
>
> Given that the code is LGPL licensed, I don't think considering it
> 'hijacked' is appropriate.
>
> It's publicly available here:
> https://media.codeweavers.com/pub/crossover/source/

I'm not talking about the source tarball which obviously should comply with
Wine license, I'm talking about particular commit that can't be retrieved
without direct access to internal source tracker.

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32490

--- Comment #24 from Austin English  ---
(In reply to Dmitry Timoshkov from comment #23)
> (In reply to Austin English from comment #22)
> > (In reply to Dmitry Timoshkov from comment #21)
> > > (In reply to joaopa from comment #20)
> > > > Is Dmitry's patch uncorrect. It was created in 2003 and has not been merged
> > > > yet.
> > >
> > > The staged patch has been hijacked from internal Codeweavers source tracker
> > > by someone without the author (me) or the owner of the patch (Codeweavers)
> > > informed in any form. It's not clear how to proceed further in this case.
> >
> > Given that the code is LGPL licensed, I don't think considering it
> > 'hijacked' is appropriate.
> >
> > It's publicly available here:
> > https://media.codeweavers.com/pub/crossover/source/
>
> I'm not talking about the source tarball which obviously should comply with
> Wine license, I'm talking about particular commit that can't be retrieved
> without direct access to internal source tracker.

The commit is dated 'Date: Mon, 28 Jul 2003 07:39:25 -0500'

The first git tag was in 2005:
https://git-scm.com/book/en/v2/Getting-Started-A-Short-History-of-Git
https://git.kernel.org/pub/scm/git/git.git/commit/?h=v0.99&id=a3eb250f99...

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32490

--- Comment #25 from joaopa  ---
Dmitry: Maybe you could sent it again at wine-devel list and receive some
feedback about it?

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32490

--- Comment #26 from Zebediah Figura  ---
The commit was presumably migrated from CVS. The commit message is mostly the
same as 9e49a9d43361fd1b08407a7efd4b6ae0e8f60825 still in the codeweavers git
tree.

The patch was added to wine-staging in August 2014 by Sebastian Lackner. Given
Dmitry's de facto status as a member of the Staging team, I would have thought
that its presence in wine-staging was endorsed by the author. Of course,
perhaps that has changed now that wine-staging has changed maintainership and
project goals. Regardless of legal rights, the patch has been nonfunctional and
disabled in Staging for some time, and so I believe the wine-staging
maintainers would not object to removing the patch in any case, if the author
wishes it.

The patch does not represent the correct way to solve the bug, in any case. The
collation tables are generated and thus should not be manually edited. Fabian
Maurer had been working on a patch set, which was last I heard incomplete, that
solved the problem in a more correct way. I have not heard news from Fabian in
several months, however.

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32490

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|STAGED                      |NEW

--- Comment #27 from Gijs Vermeulen  ---
The staging patchset has been disabled for a while, removing STAGED status.

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32490

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |STAGED

--- Comment #28 from Zebediah Figura  ---
The patch has been replaced.

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32490

--- Comment #29 from joaopa  ---
Any news for Fabian's patch?

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32490

--- Comment #30 from Zeb Figura  ---
This was implemented upstream some time ago; it needs retesting.

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32490

--- Comment #31 from joaopa  ---
Created attachment 74316
  --> https://bugs.winehq.org/attachment.cgi?id=74316
Screenshot showing everything is fixed

Indeed, the bug is fixed in wine-8.5 (see screenshot). Can an administrator
close this bug as FIXED?

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32490

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |d8c973ad95ba5e8a9a51df0dd9b
                   |                            |e587950179ec3
         Resolution|---                         |FIXED
             Status|STAGED                      |RESOLVED

--- Comment #32 from André H.  ---
Likely fixed by d8c973ad95ba5e8a9a51df0dd9be587950179ec3

[Bug 32490] Graphical issues in Inquisitor (red squares painted on the screen)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=32490

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #33 from Alexandre Julliard  ---
Closing bugs fixed in 8.6.