[Bug 34945] New: AppleWin 1.23.0: CPU usage is very high when should be minimal

http://bugs.winehq.org/show_bug.cgi?id=34945

Bug #: 34945
           Summary: AppleWin 1.23.0: CPU usage is very high when should be
                    minimal
           Product: Wine
           Version: 1.7.6
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 46567
  --> http://bugs.winehq.org/attachment.cgi?id=46567
htop showing CPU usage

A performance issue where Wine puts an excessive load upon the CPU; CPU usage
should be marginal.

Both of my cores in my dual-core computer run at nearly 100% when I run
AppleWin 1.23.0, a self-contained Apple II emulator.

Mentioning this issue to the AppleWin developers, they say this is how AppleWin
is functioning internally, which may be of help:
> > >

During *normal* emulation, the emulator will:
i) Start a 1ms timer
ii) Execute AppleII for 1ms of emulated time
iii) Wait for 1ms timer to expire

So assuming you have a sufficiently fast PC (ie. any PC from the past 10 years)
then the wait at step-(iii) will dominate the above sequence.

Also, Applewin is single-threaded, so on your dual-core, it will at most
consume 50% of the CPU capacity. 
<<<

To replicate:
Just run Applewin.exe, and when the main window appears, press F2 to start the
emulator. A flashing prompt appears and the Applewin.exe CPU usage runs at, for
example, 72% and wineserver is at 66% (see attached screenshot from htop).

Download link:
http://download.berlios.de/applewin/AppleWin1.23.0.0.zip

51cbe8790d5fdbd3809a17a5b8b66923e676605b  AppleWin1.23.0.0.zip

[Bug 34945] AppleWin 1.23.0: CPU usage is very high when should be minimal

http://bugs.winehq.org/show_bug.cgi?id=34945

--- Comment #1 from [e-mail] 2013-11-19 04:24:39 CST ---
Created attachment 46568
  --> http://bugs.winehq.org/attachment.cgi?id=46568
Output

[Bug 34945] AppleWin 1.23.0: CPU usage is very high when should be minimal

http://bugs.winehq.org/show_bug.cgi?id=34945

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, performance
                URL|                            |http://download.berlios.de/
                   |                            |applewin/AppleWin1.23.0.0.z
                   |                            |ip

[Bug 34945] AppleWin 1.23.0: CPU usage is very high when should be minimal

https://bugs.winehq.org/show_bug.cgi?id=34945

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Sebastian Lackner  ---
Does the change explained in
https://www.winehq.org/pipermail/wine-devel/2015-June/107754.html help to
reduce the CPU usage?

[Bug 34945] AppleWin 1.23.0: CPU usage is very high when should be minimal

https://bugs.winehq.org/show_bug.cgi?id=34945

--- Comment #3 from [e-mail] ---
Hello Sebastian,

Sorry, I cannot test this patch. I am running wine-1.7.38 via
http://ppa.launchpad.net/ubuntu-wine/ppa/ubuntu. When this emerges in my
packages, I can and will test it, unless there are development binaries
packages I can install.

[Bug 34945] AppleWin 1.23.0: CPU usage is very high when should be minimal

https://bugs.winehq.org/show_bug.cgi?id=34945

--- Comment #4 from [e-mail] ---
Wait, I now have wine-staging 1.7.44 and will be able to test this sooner than
I thought. Just need to wait until this patch gets rolled into the next staging
point release.

[Bug 34945] AppleWin 1.23.0: CPU usage is very high when should be minimal

https://bugs.winehq.org/show_bug.cgi?id=34945

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from [e-mail] ---
> Does the change explained in https://www.winehq.org/pipermail/wine-devel/2015-June/107754.html 
> help to reduce the CPU usage?

YES! It works! Now the CPU usage in AppleWin is much, much lower, around 6% CPU
load whereas before is was around 80%.

Very good, thank you!

I've marked this as Fixed :)

[Bug 34945] AppleWin 1.23.0: CPU usage is very high when should be minimal

https://bugs.winehq.org/show_bug.cgi?id=34945

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |b513e07c55504f623baf8d838d0
                   |                            |0ac628eac7614
          Component|-unknown                    |quartz

[Bug 34945] AppleWin 1.23.0: CPU usage is very high when should be minimal

https://bugs.winehq.org/show_bug.cgi?id=34945

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.47.