https://bugs.winehq.org/show_bug.cgi?id=39516
Bug ID: 39516 Summary: Listview tests consistently fail Product: Wine Version: 1.7.53 Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: comctl32 Assignee: wine-bugs@winehq.org Reporter: bunglehead@gmail.com Distribution: ---
After commit http://source.winehq.org/git/wine.git/commit/4dd26ee814abb66731d075eb871f636...
From 4dd26ee814abb66731d075eb871f6367994f2682 Mon Sep 17 00:00:00 2001
From: Piotr Caban piotr@codeweavers.com Date: Tue, 6 Oct 2015 16:19:42 +0200 Subject: [PATCH] comctl32: Don't ask for WM_MOUSEHOVER messages when LVS_EX_TRACKSELECT was not specified.
Signed-off-by: Piotr Caban piotr@codeweavers.com
make listview.ok fails on every run for me, errors are:
--- ../../../../wine-git/tools/runtest -q -P wine -T ../../.. -M comctl32.dll -p comctl32_test.exe.so listview && touch listview.ok listview.c:5804: Test failed: hwndTrack != hwnd listview.c:5805: Test failed: dwFlags = 0 Makefile:525: recipe for target 'listview.ok' failed make: *** [listview.ok] Error 2 ---
reverting this patch helps.
https://bugs.winehq.org/show_bug.cgi?id=39516
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |piotr@codeweavers.com Regression SHA1| |4dd26ee814abb66731d075eb871 | |f6367994f2682
https://bugs.winehq.org/show_bug.cgi?id=39516
Piotr Caban piotr.caban@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr.caban@gmail.com
--- Comment #1 from Piotr Caban piotr.caban@gmail.com --- Could you please attach a log with win,msg debug channels?
https://bugs.winehq.org/show_bug.cgi?id=39516
--- Comment #2 from Nikolay Sivov bunglehead@gmail.com --- Created attachment 52671 --> https://bugs.winehq.org/attachment.cgi?id=52671 +win,+msg log
Log attached.
https://bugs.winehq.org/show_bug.cgi?id=39516
--- Comment #3 from Piotr Caban piotr.caban@gmail.com --- I'm seeing something strange related to cursor position and screen coordinates. On my computer (under wine) the mouse is always moved 3 pixels off comparing to screen coordinates. For example following code moves mouse to upper left corner of the screen: SetCursorPos(0, 3);
On the other hand following code: SetCursorPos(0, 0); GetCursorPos(&pt); claims to set cursor position to 0,0 but the cursor is not really moved.
This causes mismatch between coordinates returned by GetWindowRect and set by SetCursorPos. Something like this may cause test failures but I don't know if this is the case on your machine.
https://bugs.winehq.org/show_bug.cgi?id=39516
--- Comment #4 from Nikolay Sivov bunglehead@gmail.com --- It's not just mine system, it happens for all cw-* and fg-* boxes as well, as test page shows. Could it help to use larger increments instead of 3, or adding waits somewhere?
https://bugs.winehq.org/show_bug.cgi?id=39516
--- Comment #5 from Piotr Caban piotr.caban@gmail.com --- Created attachment 52702 --> https://bugs.winehq.org/attachment.cgi?id=52702 flush events after SetForegroundWindow call
This patch should fix the test failures, could you please give it a try?
https://bugs.winehq.org/show_bug.cgi?id=39516
--- Comment #6 from Nikolay Sivov bunglehead@gmail.com --- (In reply to Piotr Caban from comment #5)
Created attachment 52702 [details] flush events after SetForegroundWindow call
This patch should fix the test failures, could you please give it a try?
Works fine here. No failures after 10 runs in a row. Without this flush it fails every time. Thank you.
https://bugs.winehq.org/show_bug.cgi?id=39516
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |7d6ca63154e2d36390f60949bb4 | |a41ce23c53748 Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #7 from Nikolay Sivov bunglehead@gmail.com --- Should be fixed now with 7d6ca63154e2d36390f60949bb4a41ce23c53748, thanks again.
https://bugs.winehq.org/show_bug.cgi?id=39516
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #8 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.55.