http://bugs.winehq.org/show_bug.cgi?id=20503
Summary: ref counting bug in crypt32 Product: Wine Version: 1.1.32 Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: crypt32 AssignedTo: wine-bugs@winehq.org ReportedBy: juan_lang@yahoo.com
Created an attachment (id=24412) --> (http://bugs.winehq.org/attachment.cgi?id=24412) Show presence of ref counting bug
crypt32 uses ref counting to keep track of certificates, CRLs, and CTLs. The ref counting isn't done correctly, which can be seen by running 'WINEDEBUG=crypt make store.ok' in the tests. Looking through the output you'll find instances where the ref count becomes negative.
I'm attaching a patch which adds an assert that the ref count is positive before decrementing it. Applying the patch and running 'make store.ok' produces an assertion failure: context.c:150: Context_Release: Assertion `base->ref > 0' failed.
http://bugs.winehq.org/show_bug.cgi?id=20503
--- Comment #1 from Juan Lang juan_lang@yahoo.com 2009-10-28 11:47:01 --- Created an attachment (id=24413) --> (http://bugs.winehq.org/attachment.cgi?id=24413) Backtrace with ref counting patch applied
http://bugs.winehq.org/show_bug.cgi?id=20503
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, testcase
http://bugs.winehq.org/show_bug.cgi?id=20503
Juan Lang juan_lang@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
--- Comment #2 from Juan Lang juan_lang@yahoo.com 2009-10-29 13:01:46 --- Patch sent: http://www.winehq.org/pipermail/wine-patches/2009-October/080719.html
http://bugs.winehq.org/show_bug.cgi?id=20503
Juan Lang juan_lang@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|patch |
--- Comment #3 from Juan Lang juan_lang@yahoo.com 2009-10-29 22:36:35 --- Removing the patch keyword, the patch introduced a leak. This one needs more though, unfortunately.
http://bugs.winehq.org/show_bug.cgi?id=20503
--- Comment #4 from Juan Lang juan_lang@yahoo.com 2009-11-03 19:36:07 --- Patches sent, beginning here: http://www.winehq.org/pipermail/wine-patches/2009-November/080891.html
http://bugs.winehq.org/show_bug.cgi?id=20503
Juan Lang juan_lang@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #5 from Juan Lang juan_lang@yahoo.com 2009-11-04 11:56:52 --- Fixed by commit 108f30bb7d4f466722f7af1fa8c9c9bcfb8e3a5b.
http://bugs.winehq.org/show_bug.cgi?id=20503
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Alexandre Julliard julliard@winehq.org 2009-11-13 12:44:45 --- Closing bugs fixed in 1.1.33.