[Bug 10284] New: No$gba doesn't load previous directory in rom select

http://bugs.winehq.org/show_bug.cgi?id=10284

Summary: No$gba doesn't load previous directory in rom select
           Product: Wine
           Version: 0.9.48.
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: trivial
          Priority: P2
         Component: wine-files
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

When the dialog for loading a ROM is used, it never remembers the last
directory you were in. It remembers in Windows.

fixme:commdlg:GetFileName95 Flags 0x00800000 not yet implemented

That's the error it gives in the console, which is the cause of the problem.

To reproduce: 
-Start NO$GBA.exe
-Watch as the bug occurs

[Bug 10284] No$gba doesn't load previous directory in rom select

http://bugs.winehq.org/show_bug.cgi?id=10284

--- Comment #1 from Juan Lang   2007-11-02 14:40:06 ---
Well, that isn't the _cause_ of the problem.  0x00800000 is OFN_CREATEPROMPT,
which is not the same thing.

[Bug 10284] No$gba doesn't load previous directory in rom select

http://bugs.winehq.org/show_bug.cgi?id=10284

--- Comment #2 from Juan Lang   2007-11-02 15:01:10 ---
Whoops, my bad, that's actually OFN_EXPLORER.  That might have something to do
with it after all.

[Bug 10284] No$gba doesn't load previous directory in rom select

http://bugs.winehq.org/show_bug.cgi?id=10284

--- Comment #3 from Jonathan   2007-11-02 15:13:38 ---
Well I don't profess to know exactly the cause, I'm not a good programmer.
Perhaps I should have said I was speculating with a high degree of suspicion.
:P

[Bug 10284] No$gba doesn't load previous directory in rom select

http://bugs.winehq.org/show_bug.cgi?id=10284

--- Comment #4 from Jonathan   2007-11-10 12:24:34 ---
Actually, I think it's OFN_ENABLESIZING. I think you miscounted your zeros. ;)
I found a list online that said that it was OFN_ENABLESIZING.

I also looked through the No$gba changelog since I remember him adding resizing
to the emulator. The version before where he implements OFN_ENABLESIZING (2.4b)
doesn't give the fixme. So this fixme is related to a totally different bug.

[Bug 10284] No$gba doesn't load previous directory in rom select

http://bugs.winehq.org/show_bug.cgi?id=10284

Jonathan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         OS/Version|other                       |Linux
           Platform|Other                       |PC

[Bug 10284] No$gba doesn't load previous directory in rom select

http://bugs.winehq.org/show_bug.cgi?id=10284

Jonathan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

--- Comment #5 from Jonathan   2007-12-17 10:27:04 ---
Here's how No$gba handles loading the last directory you were in:
When the emulator is closed, it writes the full path to the last directory you
were in to a binary file called NO$GBA.INP. It then loads that directory when
the emulator is next run.
The emulator is writing to the file just fine. When it comes to reading,
though, it seems to fail without a fixme.

[Bug 10284] No$gba doesn't load previous directory in rom select

http://bugs.winehq.org/show_bug.cgi?id=10284

James Hawkins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|_obsolete_files             |-unknown

[Bug 10284] No$gba doesn't load previous directory in rom select

http://bugs.winehq.org/show_bug.cgi?id=10284

Vincent Beers  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Vincent Beers   2008-10-29 17:30:32 ---
Reviving bug.
This problem persists in the latest release of Wine (1.1.7). No$gba always
reverts to the SLOT directory rather than the last one.

[Bug 10284] No$gba doesn't load previous directory in rom select

http://bugs.winehq.org/show_bug.cgi?id=10284

--- Comment #7 from Vincent Beers   2009-05-24 15:36:07 ---
In Wine 1.1.21, no$gba only remembers the last opened directory until the
program's closed. If the program is restarted it defaults back to the SLOT
directory while the Windows behaviour is to stay in the previous directory.

[Bug 10284] No$gba doesn't load previous directory in rom select

http://bugs.winehq.org/show_bug.cgi?id=10284

--- Comment #8 from Nikolay Sivov   2009-12-29 15:29:37 ---
Could you try with native comdlg32.dll?

[Bug 10284] No$gba doesn't load previous directory in rom select

http://bugs.winehq.org/show_bug.cgi?id=10284

--- Comment #9 from Jonathan   2009-12-31 12:05:50 ---
With a native comdlg32.dll I get the same behavior as in comment #7. I get the
same behavior without the native comdlg32.dll too.

[Bug 10284] No$gba doesn't load previous directory in rom select

http://bugs.winehq.org/show_bug.cgi?id=10284

Andrew Eikum  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #10 from Andrew Eikum   2010-06-21 09:39:50 ---
The .INP file is a red herring.  This bug actually occurs because the builtin
comdlg32 open and save dialogs don't save Most Recently Used data in the
registry, as native does.

Native stores this information in a couple of keys in:
HKCU/Software/Microsoft/Windows/CurrentVersion/Explorer/ComDlg32

We need to implement this feature in our comdlg32 to fix this bug.

Marking as NEW and since the problem is identified.

[Bug 10284] No$gba doesn't load previous directory in rom select

http://bugs.winehq.org/show_bug.cgi?id=10284

--- Comment #11 from Andrew Eikum   2010-06-23 15:26:43 ---
Created an attachment (id=29086)
 --> (http://bugs.winehq.org/attachment.cgi?id=29086)
Patches to implement MRU data for save/open dialogs

These patches should fix the problem.  I will submit them after the 1.2 freeze
is over.

[Bug 10284] No$gba doesn't load previous directory in rom select

http://bugs.winehq.org/show_bug.cgi?id=10284

Andrew Eikum  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 10284] No$gba doesn't load previous directory in rom select

http://bugs.winehq.org/show_bug.cgi?id=10284

--- Comment #12 from Andrew Eikum   2010-07-26 14:32:28 ---
This is fixed by this commit in today's git:

commit 4b93548df1578d4345d89ae978207cebb0366a00
Author: Andrew Eikum 
Date:   Fri Jul 23 13:13:04 2010 -0500

comdlg32: Store and use save/open dialogs' most-recently-used data.

Please retest to confirm.

[Bug 10284] No$gba doesn't load previous directory in rom select

http://bugs.winehq.org/show_bug.cgi?id=10284

--- Comment #13 from Vincent Beers   2010-07-27 12:36:27 ---
(In reply to comment #12)
> This is fixed by this commit in today's git:
>
> commit 4b93548df1578d4345d89ae978207cebb0366a00
> Author: Andrew Eikum 
> Date:   Fri Jul 23 13:13:04 2010 -0500
> comdlg32: Store and use save/open dialogs' most-recently-used data.
>
> Please retest to confirm.

I just compiled and tested, it works. I load up a game in a different
directory, then open the file open dialog again, and it's now in that different
directory instead of no$gba's default initial directory.

[Bug 10284] No$gba doesn't load previous directory in rom select

http://bugs.winehq.org/show_bug.cgi?id=10284

Andrew Eikum  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Andrew Eikum   2010-07-27 12:54:46 ---
Marking as fixed.  Thanks for retesting!

[Bug 10284] No$gba doesn't load previous directory in rom select

http://bugs.winehq.org/show_bug.cgi?id=10284

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #15 from Alexandre Julliard   2010-07-30 12:54:51 ---
Closing bugs fixed in 1.3.0.