http://bugs.winehq.org/show_bug.cgi?id=15387
Summary: VB6 Format error in wine 1.1.4 Product: Wine Version: 1.1.4 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: oleaut32 AssignedTo: wine-bugs@winehq.org ReportedBy: gabmoa@yahoo.it
Created an attachment (id=16235) --> (http://bugs.winehq.org/attachment.cgi?id=16235) two minus is not better than one
Format is a very used function in VB6 programs. In the wine 1.1.4 I think the following fix had changed the right behaviour of VB6 format function: in the example the negative values have 2 minus instead of 1 (ex. --0.001 instead of -0.001!).
wine git: 2008-08-25 Damjan Jovanovic oleaut32: Fix negative number handling in VarFormat.
Wine 1.1.2 doesn't have such problem.
http://bugs.winehq.org/show_bug.cgi?id=15387
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
--- Comment #1 from Austin English austinenglish@gmail.com 2008-09-23 10:19:00 --- Please run a regression test: http://wiki.winehq.org/RegressionTesting
or try reverting that commit to check to see if it's the cause.
http://bugs.winehq.org/show_bug.cgi?id=15387
Damjan Jovanovic damjan.jov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |damjan.jov@gmail.com Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #2 from Damjan Jovanovic damjan.jov@gmail.com 2008-09-24 10:19:54 --- Hello
Next time you find a regression, please add the author to the CC, otherwise how are people supposed to know they caused a regression?
I see there are no tests for this multiple format thing (with ";" in the format). I'll try add some when I make the patch.
http://bugs.winehq.org/show_bug.cgi?id=15387
Damjan Jovanovic damjan.jov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|wine-bugs@winehq.org |damjan.jov@gmail.com Status|NEW |ASSIGNED
--- Comment #3 from Damjan Jovanovic damjan.jov@gmail.com 2008-09-24 11:53:32 --- Created an attachment (id=16252) --> (http://bugs.winehq.org/attachment.cgi?id=16252) do not print a negative sign when using a negative format
Here's a patch, I've already mailed it to wine-patches.
Sorry about the regression. I realize Format() is important in VB, that's why I was trying to fix it.
If you were using a "0.0;-0.0" style format to work around the fact that a "0.0" format didn't print a - for negative numbers in Wine, you'll be happy to know it now does.
http://bugs.winehq.org/show_bug.cgi?id=15387
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
http://bugs.winehq.org/show_bug.cgi?id=15387
--- Comment #4 from Gabriele Moabiti gabmoa@yahoo.it 2008-09-25 04:25:56 ---
If you were using a "0.0;-0.0" style format to work around the fact that a "0.0" format didn't print a - for negative numbers in Wine, you'll be happy to know it now does.
Fixed. Thank you for improving the vb6 applications compatibility!
http://bugs.winehq.org/show_bug.cgi?id=15387
Damjan Jovanovic damjan.jov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED
--- Comment #5 from Damjan Jovanovic damjan.jov@gmail.com 2008-09-25 07:31:21 --- My patch is in latest GIT -> resolving fixed.
http://bugs.winehq.org/show_bug.cgi?id=15387
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Alexandre Julliard julliard@winehq.org 2008-10-10 10:11:08 --- Closing bugs fixed in 1.1.6.
-
wine-bugs＠winehq.org