https://bugs.winehq.org/show_bug.cgi?id=53474
Bug ID: 53474 Summary: Change in memory handling gives crash in Framemaker 8 Product: Wine Version: 7.14 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: kernel32 Assignee: wine-bugs@winehq.org Reporter: ulrich.gemkow@ikr.uni-stuttgart.de Distribution: ---
The following commit
commit a4966b6690b31c4884d07a8a745017adb6363834 Author: Rémi Bernon rbernon@codeweavers.com Date: Thu Jun 9 14:13:53 2022 +0200
kernelbase: Cleanup and simplify (Global|Local)ReAlloc.
Signed-off-by: Rémi Bernon rbernon@codeweavers.com
dlls/kernel32/heap.c | 22 ++++++++- dlls/kernel32/tests/heap.c | 15 ------- dlls/kernelbase/memory.c | 108 +++++++++++++++------------------------------ 3 files changed, 56 insertions(+), 89 deletions(-)
leads to a crash in Framemaker 8. Reverting the patch on top of wine-7.14 solves the problem.
To reproduce (simplest way):
- Start Framemaker and create a new document
- Open the print dialog (Ctrl-P)
- Select another printer (lower part of the dialog)
- Framemaker crashes with an internal error
Framemaker generates a log file (which is IMHO useless but attached anyway)
I can provide a demo version of framemaker if this would help.
https://bugs.winehq.org/show_bug.cgi?id=53474
Ulrich Gemkow ulrich.gemkow@ikr.uni-stuttgart.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Regression SHA1| |a4966b6690b31c4884d07a8a745 | |017adb6363834
https://bugs.winehq.org/show_bug.cgi?id=53474
--- Comment #1 from Ulrich Gemkow ulrich.gemkow@ikr.uni-stuttgart.de --- Created attachment 72840 --> https://bugs.winehq.org/attachment.cgi?id=72840 Log File of Framemaker created after crash
https://bugs.winehq.org/show_bug.cgi?id=53474
Ulrich Gemkow ulrich.gemkow@ikr.uni-stuttgart.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rbernon@codeweavers.com
https://bugs.winehq.org/show_bug.cgi?id=53474
--- Comment #2 from Rémi Bernon rbernon@codeweavers.com --- Would you mind testing again after fe3c5e93e21d72789a98a3d9ab8031146e56b058 (for instance today's upstream HEAD)?
If it still doesn't work, a log file with WINEDEBUG=+pid,+globalmem could possibly be helpful.
https://bugs.winehq.org/show_bug.cgi?id=53474
--- Comment #3 from Ulrich Gemkow ulrich.gemkow@ikr.uni-stuttgart.de --- Created attachment 73464 --> https://bugs.winehq.org/attachment.cgi?id=73464 Log File of Framemaker created after crash with +pid,+globalmem
https://bugs.winehq.org/show_bug.cgi?id=53474
--- Comment #4 from Ulrich Gemkow ulrich.gemkow@ikr.uni-stuttgart.de --- Thanks for looking into this! Unfortunately the mentioned changes to the memory handling did not solve the problem.
I attached the log file using latest wine 7.21 from yesterday.
Please tell me when more info would help
https://bugs.winehq.org/show_bug.cgi?id=53474
--- Comment #5 from Rémi Bernon rbernon@codeweavers.com --- Created attachment 73525 --> https://bugs.winehq.org/attachment.cgi?id=73525 GlobalReAlloc/LocalReAlloc fixes
Would mind trying the attached patch, see if it fixes the issue?
https://bugs.winehq.org/show_bug.cgi?id=53474
--- Comment #6 from Ulrich Gemkow ulrich.gemkow@ikr.uni-stuttgart.de --- Your patch indeed fixes the issue. Thanks again!
https://bugs.winehq.org/show_bug.cgi?id=53474
Rémi Bernon rbernon@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |03ad9474201b0ea20ec2282320c | |19bfe944788e8 Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED
--- Comment #7 from Rémi Bernon rbernon@codeweavers.com --- This should be fixed after 03ad9474201b0ea20ec2282320c19bfe944788e8.
https://bugs.winehq.org/show_bug.cgi?id=53474
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #8 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 7.22.
https://bugs.winehq.org/show_bug.cgi?id=53474
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4@web.de
--- Comment #9 from Fabian Maurer dark.shadow4@web.de --- Since part of those changes got reverted, does the program still work?
https://bugs.winehq.org/show_bug.cgi?id=53474
--- Comment #10 from Ulrich Gemkow ulrich.gemkow@ikr.uni-stuttgart.de --- With current git of today (wine-7.22-223-g4febd9d880a) there are no crashes in this area. After the mentioned "fixed by" patch there were several changes in memory handling (if I understand this correctly) and more tests. Maybe in the end memory handling got improved.
Please tell me if you need more info!
https://bugs.winehq.org/show_bug.cgi?id=53474
--- Comment #11 from Fabian Maurer dark.shadow4@web.de --- No, if it works everything is great :)