[Bug 31145] New: WinDirStat right clicking on a directory and selecting properties says "invalid parameter"

http://bugs.winehq.org/show_bug.cgi?id=31145

Bug #: 31145
           Summary: WinDirStat right clicking on a directory and selecting
                    properties says "invalid parameter"
           Product: Wine
           Version: 1.5.8
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

After analysis of a directory, right clicking on a directory (doesn't matter
which, as long it's in the "scope" of the analysis) and selecting properties
shows the error message "invalid parameter".

[Bug 31145] WinDirStat right clicking on a directory and selecting properties says "invalid parameter"

http://bugs.winehq.org/show_bug.cgi?id=31145

Geoffrey  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 31145] WinDirStat right clicking on a directory and selecting properties says "invalid parameter"

http://bugs.winehq.org/show_bug.cgi?id=31145

--- Comment #1 from Austin English  2012-07-06 12:01:22 CDT ---
Please attach terminal output.

[Bug 31145] WinDirStat right clicking on a directory and selecting properties says "invalid parameter"

http://bugs.winehq.org/show_bug.cgi?id=31145

--- Comment #2 from Geoffrey  2012-07-06 12:20:08 CDT ---
Created attachment 40894
  --> http://bugs.winehq.org/attachment.cgi?id=40894
Only last line is important I think

[Bug 31145] WinDirStat right clicking on a directory and selecting properties says "invalid parameter"

http://bugs.winehq.org/show_bug.cgi?id=31145

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40894|application/octet-stream    |text/plain
          mime type|                            |

[Bug 31145] WinDirStat right clicking on a directory and selecting properties says "invalid parameter"

http://bugs.winehq.org/show_bug.cgi?id=31145

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
             Status|UNCONFIRMED                 |NEW
                URL|                            |http://windirstat.info/
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #3 from Bruno Jesus  2012-07-06 19:16:06 CDT ---
Wine does not support showing directory properties (am I correct?). That
message is not from the program, is from wine itself:
http://source.winehq.org/source/dlls/shell32/shlexec.c#L1927

1927     if (retval <= 32 && !(sei_tmp.fMask & SEE_MASK_FLAG_NO_UI))
1928         do_error_dialog(retval, sei_tmp.hwnd);

WINEDEBUG=+exec shows this:
...
trace:exec:SHELL_FindExecutable L""
trace:exec:SHELL_FindExecutable found L"" via App Paths
trace:exec:SHELL_quote_and_execute L""/L"properties" => L""""/L""
trace:exec:SHELL_ExecuteW Execute L"""" from directory L""
trace:exec:SHELL_ExecuteW CreateProcess returned error 87
trace:exec:SHELL_ExecuteW returning 11
trace:exec:SHELL_execute retval 11

[Bug 31145] WinDirStat right clicking on a directory and selecting properties says "invalid parameter"

http://bugs.winehq.org/show_bug.cgi?id=31145

--- Comment #4 from Bruno Jesus  2012-07-06 20:14:55 CDT ---
Created attachment 40900
  --> http://bugs.winehq.org/attachment.cgi?id=40900
hack

The attached patch is a hack that will make it open the explorer instead of
showing an error.

The application sets the SEE_MASK_IDLIST but does not set a list in lpIDList so
wine clears the lpFile variable in SHGetPathFromIDListW and then there is the
exec fail.

[Bug 31145] WinDirStat right clicking on a directory and selecting properties says "invalid parameter"

http://bugs.winehq.org/show_bug.cgi?id=31145

--- Comment #5 from Geoffrey  2012-07-08 13:03:32 CDT ---
(In reply to comment #4)
> Created attachment 40900 [details]
> hack
>
> The attached patch is a hack that will make it open the explorer instead of
> showing an error.
>
> The application sets the SEE_MASK_IDLIST but does not set a list in lpIDList so
> wine clears the lpFile variable in SHGetPathFromIDListW and then there is the
> exec fail.

Is this a desired behaviour? And isn't it possible to implement properties of a
directory / file?

[Bug 31145] WinDirStat right clicking on a directory and selecting properties says "invalid parameter"

http://bugs.winehq.org/show_bug.cgi?id=31145

--- Comment #6 from Bruno Jesus  2012-07-08 13:39:08 CDT ---
(In reply to comment #5)
> Is this a desired behaviour? And isn't it possible to implement properties of a
> directory / file?

The patch is simply intended to show where the problem may be. I don't have the
knowledge to fix this bug (by creating the properties page), we will have to
wait for someone more experienced to work in it.

[Bug 31145] WinDirStat right clicking on a directory and selecting properties says "invalid parameter"

http://bugs.winehq.org/show_bug.cgi?id=31145

--- Comment #7 from Geoffrey  2012-07-09 08:54:18 CDT ---
Okay, thanks for your effort :) At least it's better than nothing.

[Bug 31145] WinDirStat right clicking on a directory and selecting properties says "invalid parameter"

https://bugs.winehq.org/show_bug.cgi?id=31145

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Abandoned?

--- Comment #8 from Ken Sharp  ---
Is this still an issue in Wine 1.7.45 or later?

[Bug 31145] WinDirStat right clicking on a directory and selecting properties says "invalid parameter"

https://bugs.winehq.org/show_bug.cgi?id=31145

--- Comment #9 from Geoffrey De Belie  ---
(In reply to Ken Sharp from comment #8)
> Is this still an issue in Wine 1.7.45 or later?

Yes.

[Bug 31145] WinDirStat right clicking on a directory and selecting properties says "invalid parameter"

https://bugs.winehq.org/show_bug.cgi?id=31145

Geoffrey De Belie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|Abandoned?                  |

[Bug 31145] WinDirStat right clicking on a directory and selecting properties says "invalid parameter"

https://bugs.winehq.org/show_bug.cgi?id=31145

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from [e-mail] ---
It's still an issue I tried to dig into this too.

trace:exec:SHELL_ExecuteW CreateProcess returned error 87

I used that as starting to point where to search a bug.

wine 1.7.50

[Bug 31145] WinDirStat right clicking on a directory and selecting properties says "invalid parameter"

https://bugs.winehq.org/show_bug.cgi?id=31145

Jeff D. Hanson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Jeff D. Hanson  ---
The hack/patch failed to apply to current Wine 1.9 git (HEAD d7e4193).

[Bug 31145] WinDirStat right clicking on a directory and selecting properties says "invalid parameter"

https://bugs.winehq.org/show_bug.cgi?id=31145

--- Comment #12 from [e-mail] ---
I thought Muller's patch could help here, but it clearly fixes another area of
wine. Still valid 1.9.7.

[Bug 31145] WinDirStat right clicking on a directory and selecting properties says " invalid parameter"

https://bugs.winehq.org/show_bug.cgi?id=31145

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from [e-mail] ---
Still valid 1.9.21-git.

[Bug 31145] WinDirStat right clicking on a directory and selecting properties says "invalid parameter"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=31145

exposight  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #14 from exposight  ---
still the case in wine 4.18

[Bug 31145] WinDirStat right clicking on a directory and selecting properties says "invalid parameter"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=31145

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 31145] WinDirStat right clicking on a directory and selecting properties says "invalid parameter"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=31145

Damjan Jovanovic  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source

--- Comment #15 from Damjan Jovanovic  ---
It's a dogfood bug.

[Bug 31145] WinDirStat right clicking on a directory and selecting properties says "invalid parameter"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=31145

--- Comment #16 from Damjan Jovanovic  ---
A +shell trace isn't very revealing, but we can use the fact that the
MessageBox is modal, making the stack trace to it visible. "bt all" in winedbg
gives us:

---snip---
  9 0x6ed6c3cf MessageBoxW+0x5e(text=<couldn't compute location>,
title=<couldn't compute location>, type=<couldn't compute location>)
[Z:\Wine\wine\dlls\user32\msgbox.c:441] in user32 (0x0021d118)
  10 0x6354314a in shell32 (+0x83149) (0x0021e158)
  11 0x63544343 in shell32 (+0x84342) (0x0021f938)
  12 0x6354468b in shell32 (+0x8468a) (0x0021f958)
  13 0x00406a4e EntryPoint+0xffffffff() in windirstat (0x0021f9dc)
---snip---

So the MessageBox is called from somewhere in shell32. A grep through there,
and eliminates the places that place a hardcoded string as the message, leaves
us with few candidates. Hacking the remaining places to log a FIXME before each
MessageBox, we find it's called from:

do_error_dialog()
which is called in the "out:" part of SHELL_execute()

It looks like some kind of bug in SHELL_execute(), in handling the variation of
parameters passed by WinDirStat.

[Bug 31145] WinDirStat right clicking on a directory and selecting properties says "invalid parameter"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=31145

Bernhard Übelacker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from Bernhard Übelacker  ---
Created attachment 71558
  --> https://bugs.winehq.org/attachment.cgi?id=71558
trace with +exec and some more backtraces

Still valid with wine-7.0-rc4.

ShellExecuteEx gets called with not yet supported SEE_MASK_INVOKEIDLIST.
And with null sei.lpIDList, thefore sei.lpFile gets initialized in
SHGetPathFromIDList, therefore the path lost.
The workaround from Bruno is still valid. (Manually applied.)

[Bug 31145] WinDirStat right clicking on a directory and selecting properties says "invalid parameter"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=31145

--- Comment #18 from Austin English  ---
Still present in 9.0.

6fa92dd2ca691c11dfbfc0a239e34369897a7fab  windirstat1_1_2_setup.exe