[Bug 52128] New: Hog4PC 3.17 installer VBScript custom action wants scrrun:filesys_MoveFolder implementation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52128

Bug ID: 52128
           Summary: Hog4PC 3.17 installer VBScript custom action wants
                    scrrun:filesys_MoveFolder implementation
           Product: Wine
           Version: 6.22
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: scrrun
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Hello folks,

as it says.

--- snip ---
$ wine msiexec -i Hog_4_PC_3.17.0.3327.msi
...
0184:trace:scrrun:filesys_FolderExists 0362A084
L"C:\users\focht\AppData\Roaming" 02F0F970 
...
0184:fixme:scrrun:filesys_MoveFolder 0362A084
L"C:\users\focht\AppData\Roaming" L"C:\users\focht\AppData\Roaming" 
...
0184:err:msi:MsiActiveScriptSite_OnScriptError script error: L"Object doesn't
support this action" 
...
0184:trace:msi:ScriptThread custom action (184) returned 1603 
--- snip ---

VBScript custom action scriptlet:

--- snip ---
Function renamePersistentDir()
    Dim appDataEnv
    appDataEnv = shell.expandEnvironmentStrings("%APPDATA%")

Dim roamingDir
    roamingDir = appDataEnv + "\Flying Pig Systems"

If ( fso.FolderExists(roamingDir) ) Then
        fso.MoveFolder roamingDir, appDataEnv + "\High End Systems"
        fso.MoveFolder appDataEnv + "\High End Systems\Hog 4PC", appDataEnv +
"\High End Systems\Hog 4 PC"
    End If
End Function
--- snip ---

Wine source:

https://source.winehq.org/git/wine.git/blob/f03933fbb73152c7a54383fba411a611...

--- snip ---
3616 static HRESULT WINAPI filesys_MoveFolder(IFileSystem3 *iface,BSTR Source,
3617                                             BSTR Destination)
3618 {
3619     FIXME("%p %s %s\n", iface, debugstr_w(Source),
debugstr_w(Destination));
3620 
3621     return E_NOTIMPL;
3622 }
--- snip ---

Stable download link via Internet Archive:

https://web.archive.org/web/20211128125004/https://cdn.etcconnect.com/Hog_4_...

$ sha1sum Hog_4_PC_3.17.0.3327.msi.zip 
f98421bbbb0590df0e65ac18903471dd5fb61b6a  Hog_4_PC_3.17.0.3327.msi.zip

$ du -sh Hog_4_PC_3.17.0.3327.msi.zip 
361M    Hog_4_PC_3.17.0.3327.msi.zip

$ sha1sum Hog_4_PC_3.17.0.3327.msi
0d22bf13c5a9bb682820ee6f690a866c1b320d9b  Hog_4_PC_3.17.0.3327.msi

$ wine --version
wine-6.22-204-gf03933fbb73

Regards

[Bug 52128] Hog4PC 3.17 installer VBScript custom action needs scrrun:filesys_MoveFolder implementation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52128

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://web.archive.org/web
                   |                            |/20211128125004/https://cdn
                   |                            |.etcconnect.com/Hog_4_PC_3.
                   |                            |17.0.3327.msi.zip
            Summary|Hog4PC 3.17 installer       |Hog4PC 3.17 installer
                   |VBScript custom action      |VBScript custom action
                   |wants                       |needs
                   |scrrun:filesys_MoveFolder   |scrrun:filesys_MoveFolder
                   |implementation              |implementation
           Keywords|                            |download, Installer

[Bug 52128] Hog4PC 3.17 installer VBScript custom action needs scrrun:filesys_MoveFolder implementation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52128

Robert Wilhelm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Robert Wilhelm  ---
Created attachment 71213
  --> https://bugs.winehq.org/attachment.cgi?id=71213
Implement filesys_MoveFolder

[Bug 52128] Hog4PC 3.17 installer VBScript custom action needs scrrun:filesys_MoveFolder implementation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52128

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from [e-mail] ---
this bug might already be fixed.

https://gitlab.winehq.org/wine/wine/-/merge_requests/343/diffs?commit_id=91a...

[Bug 52128] Hog4PC 3.17 installer VBScript custom action needs scrrun:filesys_MoveFolder implementation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52128

Robert Wilhelm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #3 from Robert Wilhelm  ---

Updated patches are in
https://gitlab.winehq.org/wine/wine/-/merge_requests/391

But currently they are not yet approved and therefore not merged to main
branch.

[Bug 52128] Hog4PC 3.17 installer VBScript custom action needs scrrun:filesys_MoveFolder implementation

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52128

Robert Wilhelm  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |53542