https://bugs.winehq.org/show_bug.cgi?id=48723
Bug ID: 48723 Summary: Torchlight - Loading times are excessively long Product: Wine Version: 4.5 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: msvcrt Assignee: wine-bugs@winehq.org Reporter: vv221+winehq@dotslashplay.it Distribution: ---
Created attachment 66598 --> https://bugs.winehq.org/attachment.cgi?id=66598 revert the faulty commit
This bug has been spotted on version 1.15 of Torchlight, as sold on gog.com. It has been reproduced reliably on a Debian Sid and an Arch Linux.
The symptoms are: - the game takes a long time to launch - switching between characters in the menu takes several seconds - transition between zones in game takes much longer than it should
The issue is present starting with WINE 4.5, and is still present in latest release (5.3) and current master (wine-5.3-181-geb63713f60). WINE 4.4 is the latest non-affected release.
I did a bisect and identified the following commit as the faulty one: f48ea297268e832c93a22fb5b92f73620c717280 "msvcrt: Use _strnicmp instead of strncasecmp."
The attached patch reverts this commit, it applies cleanly on both 5.3 and current master, and restore normal loading times in the game.
You can see more information about this issue in the original bug report in the issues tracker of ./play.it: https://forge.dotslashplay.it/play.it/games/issues/342
https://bugs.winehq.org/show_bug.cgi?id=48723
vv221 vv221+winehq@dotslashplay.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |f48ea297268e832c93a22fb5b92 | |f73620c717280
https://bugs.winehq.org/show_bug.cgi?id=48723
vv221 vv221+winehq@dotslashplay.it changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vv221+winehq@dotslashplay.i | |t
https://bugs.winehq.org/show_bug.cgi?id=48723
Jeff Zaroyko jeffz@jeffz.name changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr@codeweavers.com Keywords| |regression
https://bugs.winehq.org/show_bug.cgi?id=48723
--- Comment #1 from Piotr Caban piotr.caban@gmail.com --- Created attachment 66600 --> https://bugs.winehq.org/attachment.cgi?id=66600 optimize _strnicmp_l function
Is this patch fixing the bug?
https://bugs.winehq.org/show_bug.cgi?id=48723
--- Comment #2 from vv221 vv221+winehq@dotslashplay.it --- (In reply to Piotr Caban from comment #1)
Created attachment 66600 [details] optimize _strnicmp_l function
Is this patch fixing the bug?
Yes, it seems to fix all the symptoms I listed in the bug description.
https://bugs.winehq.org/show_bug.cgi?id=48723
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
https://bugs.winehq.org/show_bug.cgi?id=48723
Piotr Caban piotr.caban@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr.caban@gmail.com Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |471425c16d66af6421a43c2ea8b | |54bbc2dccc0be
--- Comment #3 from Piotr Caban piotr.caban@gmail.com --- The patch is in wine. Marking as fixed.
https://bugs.winehq.org/show_bug.cgi?id=48723
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #4 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 5.4.
https://bugs.winehq.org/show_bug.cgi?id=48723
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |5.0.x
https://bugs.winehq.org/show_bug.cgi?id=48723
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|5.0.x |---
--- Comment #5 from Michael Stefaniuc mstefani@winehq.org --- Removing the 5.0.x milestone from bug fixes included in 5.0.1.