[Bug 26434] New: gamestop downloader has an infinite loop error in msxml3

http://bugs.winehq.org/show_bug.cgi?id=26434

Summary: gamestop downloader has an infinite loop error in
                    msxml3
           Product: Wine
           Version: 1.3.15
          Platform: x86
               URL: http://www.gamestop.com/pc/games/carnivores-2/62431
        OS/Version: Linux
            Status: NEW
          Keywords: download
          Severity: minor
          Priority: P2
         Component: msxml3
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=33653)
 --> (http://bugs.winehq.org/attachment.cgi?id=33653)
+msxml,+tid trace

See bug 25518 for original bug. Now, it loops:
err:msxml:doparse XML declaration allowed only at the start of the document

endlessly. +msxml,+tid attached.

Nicolay, it seems to be loading an url?
0020:trace:msxml:domdoc_loadXML (0x160e70)->(L"\n<?xml version=\"1.0\"
encoding=\"UTF-16\"?>\n<dm>\n  <files>\n    <file execute="yes"
stamp="yes">\n     
<url>http://cdn.dli.trymedia.com/r/release/infogrames/30m_d_61/Carnivores2Setup.e...</url>\n
   </file>\n  </files>\n</dm>" 0x66e958)
0020:err:msxml:doparse XML declaration allowed only at the start of the
document

The other current problem is bug 26425.

[Bug 26434] gamestop downloader has an infinite loop error in msxml3

http://bugs.winehq.org/show_bug.cgi?id=26434

--- Comment #1 from Nikolay Sivov  2011-03-15 15:11:02 CDT ---
The problem is a leading \n most likely.

---
L"\n<?xml version="1.0"...
---

Specification explicitly says that document prolog should be exactly at the
start:

http://www.w3.org/TR/xml/#NT-prolog

[22]       prolog       ::=       XMLDecl? Misc* (doctypedecl Misc*)?
[23]       XMLDecl       ::=       '<?xml' VersionInfo EncodingDecl? SDDecl? S?
'?>'

so no space characters is allowed before it.

I'll add a test for that, but before that please try that native one really
eats such input, cause it could be a problem somewhere else.

[Bug 26434] gamestop downloader has an infinite loop error in msxml3

http://bugs.winehq.org/show_bug.cgi?id=26434

--- Comment #2 from Austin English  2011-03-15 16:20:02 CDT ---
(In reply to comment #1)
> I'll add a test for that, but before that please try that native one really
> eats such input, cause it could be a problem somewhere else.

Currently, with plain wine and nothing native, doing:
$ wine Carnivores2Setup-dm.exe

will spew:
fixme:wininet:CommitUrlCacheEntryInternal entry already in cache - don't know
what to do!
err:msxml:doparse XML declaration allowed only at the start of the document

endlessly.

if I do:
$ winetricks -q msxml3

those errors go away, but nothing seems to happen (bug 26425). Doing:
$ winetricks -q ie7

gets a window to appear. So, I tried:
$ rm -rf .wine ; winetricks -q ie7 && wine Carnivores2Setup-dm.exe

which gets a window, but those errors/fixmes do not show up, so yes, the
problem may be elsewhere.

Let's get the testcase added, and go from there.

[Bug 26434] gamestop downloader has an infinite loop error in msxml3

http://bugs.winehq.org/show_bug.cgi?id=26434

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]

--- Comment #3 from Nikolay Sivov  2011-11-05 02:27:42 CDT ---
Ok, I'll add a test for that.

[Bug 26434] gamestop downloader has an infinite loop error in msxml3

http://bugs.winehq.org/show_bug.cgi?id=26434

--- Comment #4 from Nikolay Sivov  2011-11-05 04:11:54 CDT ---
Tests show that leading spaces like \n,\r,\t or ' ' are not allowed at xml
stream start. So the problem must be in network layer or anywhere we get this
stream from.

[Bug 26434] gamestop downloader has an infinite loop error in msxml3

http://bugs.winehq.org/show_bug.cgi?id=26434

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|download                    |
                URL|http://www.gamestop.com/pc/ |
                   |games/carnivores-2/62431    |

--- Comment #5 from Nikolay Sivov  2011-11-05 04:12:32 CDT ---
Update download link please.

[Bug 26434] gamestop downloader has an infinite loop error in msxml3

http://bugs.winehq.org/show_bug.cgi?id=26434

--- Comment #6 from Nikolay Sivov  2011-11-07 13:56:13 CST ---
Patch with a test sent
http://www.winehq.org/pipermail/wine-patches/2011-November/108584.html.

[Bug 26434] gamestop downloader has an infinite loop error in msxml3

http://bugs.winehq.org/show_bug.cgi?id=26434

--- Comment #7 from Nikolay Sivov  2011-11-09 12:23:12 CST ---
(In reply to comment #2)
> Let's get the testcase added, and go from there.

Test that shows it should fail with stream like that committed as
674fb3c096b2be0e5976575efa7cc5c3e27297d4.

So now we should probably detach this from msxml* component. Austin?

[Bug 26434] gamestop downloader has an infinite loop error in msxml3

http://bugs.winehq.org/show_bug.cgi?id=26434

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]

[Bug 26434] gamestop downloader has an infinite loop error in msxml3

http://bugs.winehq.org/show_bug.cgi?id=26434

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|msxml3                      |-unknown

--- Comment #8 from Austin English  2011-11-09 12:25:58 CST ---
(In reply to comment #7)
> (In reply to comment #2)
> > Let's get the testcase added, and go from there.
>
> Test that shows it should fail with stream like that committed as
> 674fb3c096b2be0e5976575efa7cc5c3e27297d4.
>
> So now we should probably detach this from msxml* component. Austin?

Sure, thanks.

[Bug 26434] gamestop downloader has an infinite loop error in msxml3

http://bugs.winehq.org/show_bug.cgi?id=26434

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |msxml3
           Severity|minor                       |normal

--- Comment #9 from Nikolay Sivov  2011-12-17 15:38:52 CST ---
After more testing it's a msxml3 problem. Please try this patch
http://bugs.winehq.org/attachment.cgi?id=38007

[Bug 26434] gamestop downloader has an infinite loop error in msxml3

http://bugs.winehq.org/show_bug.cgi?id=26434

--- Comment #10 from Nikolay Sivov  2011-12-19 13:46:05 CST ---
Should be fixed with e736c3e9837fc818ad5154e14be56fb09f11eef5. Please confirm.

[Bug 26434] gamestop downloader has an infinite loop error in msxml3

http://bugs.winehq.org/show_bug.cgi?id=26434

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |e736c3e9837fc818ad5154e14be
                   |                            |56fb09f11eef5
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Austin English  2011-12-20 14:22:20 CST ---
I can't find a copy of it online anymore, and it's not in my old bug cache, so
assuming fixed.

[Bug 26434] gamestop downloader has an infinite loop error in msxml3

http://bugs.winehq.org/show_bug.cgi?id=26434

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard  2011-12-30 12:57:17 CST ---
Closing bugs fixed in 1.3.36.