[Bug 47834] New: Borderlands 1 (version 1.5.0) doesn't capture mouse

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47834

Bug ID: 47834
           Summary: Borderlands 1 (version 1.5.0) doesn't capture mouse
           Product: Wine-staging
           Version: 4.17
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail], [e-mail]
      Distribution: ---

Borderlands 1 (version 1.5.0) doesn't capture mouse - full 360 degree view with
mouse is not possible. There is no this problem at previous version of Wine
Staging (4.16) and Wine Devel of last version (4.17)

[Bug 47834] Borderlands 1 (version 1.5.0) doesn't capture mouse

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47834

--- Comment #1 from Shlykov Andrey (Шлыков Андрей)  ---
The problem is present in many games. Only one game does not have this problem
- Unreal Tournament (1999) with Software Rendering

[Bug 47834] Borderlands 1 (version 1.5.0) doesn't capture mouse

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47834

--- Comment #2 from Alistair Leslie-Hughes  ---
I've just updated the raw-input patchset in staging.  Does this help?

[Bug 47834] Borderlands 1 (version 1.5.0) doesn't capture mouse

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47834

Nikolay Borodin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Nikolay Borodin  ---
(In reply to Shlykov Andrey (Шлыков Андрей) from comment #0)
> Borderlands 1 (version 1.5.0) doesn't capture mouse - full 360 degree view
> with mouse is not possible.

I have same issue in Warframe (wine 4.17) which is not present in wine 4.16.

[Bug 47834] Borderlands 1 (version 1.5.0) doesn't capture mouse

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47834

2155X  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from 2155X  ---
Same issue in several Unity games. The camera does not capture the mouse and
can only move with arrow keys. Worked fine on Wine-Staging (4.16), but does not
work on latest Wine-Staging (4.17).

The games in question: 
コイカツ (Koikatsu),
AI*少女 (AI-Shoujo)

*Both games are NSFW, care when googling.

[Bug 47834] Borderlands 1 (version 1.5.0) doesn't capture mouse

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47834

kolAflash  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from kolAflash  ---
(In reply to Alistair Leslie-Hughes from comment #2)
> I've just updated the raw-input patchset in staging.  Does this help?

No, at least not in StarCraft II :-/

https://github.com/wine-staging/wine-staging/commit/0c7512f5f53deb168d3508bd...

Everything was fine wine-staging-4.16.

[Bug 47834] Borderlands 1 (version 1.5.0) doesn't capture mouse

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47834

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Alistair Leslie-Hughes  ---
(In reply to kolAflash from comment #5)
> (In reply to Alistair Leslie-Hughes from comment #2)
> > I've just updated the raw-input patchset in staging.  Does this help?
>
> No, at least not in StarCraft II :-/
>
> https://github.com/wine-staging/wine-staging/commit/
> 0c7512f5f53deb168d3508bdd1f1107ecee774c6
>
> Everything was fine wine-staging-4.16.

We know its the user32-rawinput patchset.  Are you able to track down which of
these patches is causing the issue?

[Bug 47834] Borderlands 1 (version 1.5.0) doesn't capture mouse

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47834

--- Comment #7 from kolAflash  ---
Some additional information:
My OS: openSUSE-15.1
And I don't got the xf86-input-libinput package installed.
Also I got "Automatically capture the mouse in full-screen windows" enabled in
winecfg.

Some (In reply to Alistair Leslie-Hughes from comment #6)
> [...]
> We know its the user32-rawinput patchset.  Are you able to track down which
> of these patches is causing the issue?

Sure, it's 0007-winex11.drv-Implement-native-mouse-movement-raw-inpu.patch
But you can't compile it because of a syntax bug.
There's a ")" missing before "return".

+++ b/dlls/winex11.drv/mouse.c
[...]
@@ -1801,16 +1828,20 @@ static BOOL X11DRV_RawMotion( XGenericEventCookie *xev
)
[...]
+    if ((thread_data->x_rel_valuator.number < 0 ||
thread_data->y_rel_valuator.number < 0) &&
+        (thread_data->x_abs_valuator.number < 0 ||
thread_data->y_abs_valuator.number < 0) return FALSE;

The syntax bug is fixed by the succeeding
0008-winex11.drv-Implement-native-mouse-button-raw-input-.patch
But if you add the ")" and compile, the bug already appears with
triple-o-seven.

These lines also look odd, because they now have XI_DeviceChanged twice.

+++ b/dlls/winex11.drv/mouse.c
[...]
@@ -324,8 +336,8 @@ static void enable_xinput2(void)
     mask.mask_len = sizeof(mask_bits);
     mask.deviceid = XIAllMasterDevices;
     memset( mask_bits, 0, sizeof(mask_bits) );
+    XISetMask( mask_bits, XI_DeviceChanged );
     XISetMask( mask_bits, XI_RawMotion );
-    XISetMask( mask_bits, XI_ButtonPress );
     XISetMask( mask_bits, XI_DeviceChanged );

[Bug 47834] Borderlands 1 (version 1.5.0) doesn't capture mouse

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47834

Olivier F. R. Dierick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Olivier F. R. Dierick  ---
*** Bug 47863 has been marked as a duplicate of this bug. ***

[Bug 47834] Borderlands 1 (version 1.5.0) doesn't capture mouse

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47834

TOM  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from TOM  ---
Skyrim also effect, Mouse is not working in 4.17

[Bug 47834] wine-staging 4.17 regression: Not capturing mouse in multiple apps (borderland 1, warframe, starcraft 2, TES Skyrim, unity games, etc.)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47834

Olivier F. R. Dierick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Keywords|                            |regression
            Summary|Borderlands 1 (version      |wine-staging 4.17
                   |1.5.0) doesn't capture      |regression: Not capturing
                   |mouse                       |mouse in multiple apps
                   |                            |(borderland 1, warframe,
                   |                            |starcraft 2, TES Skyrim,
                   |                            |unity games, etc.)

[Bug 47834] wine-staging 4.17 regression: Not capturing mouse in multiple apps (borderland 1, warframe, starcraft 2, TES Skyrim, unity games, etc.)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47834

amednyy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 47834] wine-staging 4.17 regression: Not capturing mouse in multiple apps (borderland 1, warframe, starcraft 2, TES Skyrim, unity games, etc.)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47834

--- Comment #10 from Alistair Leslie-Hughes  ---
I've disabled the patchset in staging.

Thanks everyone for reporting the issue involved with this patchset.

[Bug 47834] wine-staging 4.17 regression: Not capturing mouse in multiple apps (borderland 1, warframe, starcraft 2, TES Skyrim, unity games, etc.)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47834

hexchain  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 47834] wine-staging 4.17 regression: Not capturing mouse in multiple apps (borderland 1, warframe, starcraft 2, TES Skyrim, unity games, etc.)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47834

Witold Baryluk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |witold.baryluk+winehq@gmail
                   |                            |.com

[Bug 47834] wine-staging 4.17 regression: Not capturing mouse in multiple apps (borderland 1, warframe, starcraft 2, TES Skyrim, unity games, etc.)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47834

Shlykov Andrey (Шлыков Андрей)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Shlykov Andrey (Шлыков Андрей)  ---
There is no this bug at current versions of Wine. Good job.

[Bug 47834] wine-staging 4.17 regression: Not capturing mouse in multiple apps (borderland 1, warframe, starcraft 2, TES Skyrim, unity games, etc.)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47834

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alistair Leslie-Hughes  ---
Closing Fixed wine-staging.