http://bugs.winehq.org/show_bug.cgi?id=24406
Summary: Certain objects invisible in Recettear:An Item Shop's Tale Product: Wine Version: 1.3.2 Platform: x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: karl.r.ernst@gmail.com
Created an attachment (id=30764) --> (http://bugs.winehq.org/attachment.cgi?id=30764) WINEDEBUG=warn+all of a dungeon run
This only seem to affect the following objects in dungeons: - treasure chests - doors of returning - some bosses
As far as I know, it seems to be 100 % reproducable for everyone, including the free demo versions (which can be downloaded at http://www.carpefulgur.com/recettear/downloads.htm, in case you want to reproduce this).
Also attaching a WINEDEBUG=warn+all log for a dungeon run in the hope it may be usefull.
http://bugs.winehq.org/show_bug.cgi?id=24406
--- Comment #1 from Karl-Robert Ernst karl.r.ernst@gmail.com 2010-09-15 08:59:46 CDT --- It seems that all invisble objects are in fact 3D-Modells (and all 3D modells are invisble), only objects which are rendered as sprites are visible.
http://bugs.winehq.org/show_bug.cgi?id=24406
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://www.carpefulgur.com/ | |recettear/downloads.htm
http://bugs.winehq.org/show_bug.cgi?id=24406
Marc Hartstein marcmagus@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #2 from Marc Hartstein marcmagus@gmail.com 2010-09-16 10:42:20 CDT --- *** This bug has been confirmed by popular vote. ***
http://bugs.winehq.org/show_bug.cgi?id=24406
Marc Hartstein marcmagus@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |marcmagus@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=24406
Jeremy Chin winehq@rekless.fastmail.fm changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |winehq@rekless.fastmail.fm
--- Comment #3 from Jeremy Chin winehq@rekless.fastmail.fm 2010-11-22 05:01:44 CST --- I've done some poking around with this bug, but haven't yet found a fix.
First, there's a minor bug in the wine d3dxof implementation, where IDirectXFileDataImpl_GetName fails if pstrNameBuf is NULL. Fixing this causes the errors to match regardless of whether the native or builtin version of the file is used.
In the demo there are a bunch of message boxes when you attempt to load the dungeon. The first is "5", then "6 2", then "6 8" a few times, then a message in Japanese ("データを読み込んで、フレームにがんがん発録していく"). The full version doesn't display these messages, but has the same symptoms
The message and bug appear to be caused when Recettear tries to load an animated .x model. The non-animated models are clearly fine, as the dungeon floors and walls render fine. It tries to do something, recurses too deeply (the "5" message for 5 levels, the message is something about frames while loading the model) before giving up. As the bug occurs with both native and builtin d3dxof.dll I'm guessing the bug is in a related d3d call, but I haven't been able to determine what.
The problematic models for the demo are xfiles/tree/takarabako.x and xfiles/tree/obj_door.x - the invisible treasure chests and exit door.
I've tried various workaround fixes: -Simplifying the model to cut down the number of frames. Reduces the "6 8" errors, but the "5" still appears. -Cutting the animation out of the models. No effect. This seems to indicate the animated and non-animated models have different loaders. -Patching out the recursion check. I got one of them, but there's a second one I can't track down that spits out more of the same errors.
http://bugs.winehq.org/show_bug.cgi?id=24406
--- Comment #4 from Jeremy Chin winehq@rekless.fastmail.fm 2010-12-11 00:06:58 CST --- I've done a little more investigation into this bug. It looks like my previous statement about recursion depth is incorrect. It looks like the actual issue is the code is calling D3DXLoadSkinMeshFromXof or something similar (d3dx is statically linked), and for some reason it's returning D3DXERR_SKINNINGNOTSUPPORTED . I can't find any useful documentation on this error.
I also came across a D3D tutorial that looks very similar to the code in Recettear, http://www.t-pot.com/program/44_motion/motion.html . The sample code doesn't work either, though I haven't determined if it's for the same reason.
http://bugs.winehq.org/show_bug.cgi?id=24406
--- Comment #5 from Jeremy Chin winehq@rekless.fastmail.fm 2010-12-11 05:14:00 CST --- Created an attachment (id=32443) --> (http://bugs.winehq.org/attachment.cgi?id=32443) Report number of vertex blend units correctly.
http://bugs.winehq.org/show_bug.cgi?id=24406
--- Comment #6 from Jeremy Chin winehq@rekless.fastmail.fm 2010-12-11 05:15:21 CST --- I've found what causes this bug. In order to see if the system is capable of doing animated meshes, d3d calls GetDeviceCaps and makes sure MaxVertexBlendMatrices is at least 2. Wine reports this number by checking if the video card has ARB_VERTEX_BLEND, then reports GL_MAX_VERTEX_UNITS. The problem is newer video cards don't report ARB_VERTEX_BLEND, only ARB_VERTEX_PROGRAM[1].
I'll attached a patch that just makes this change, against wine 1.3.9. It assumes a card that support ARB_VERTEX_PROGRAM will support multiple vertex units, but as far as I know that's a fairly safe assumption.
It also fixes the other bug I mentioned before. When IDirectXFileObject::GetName is called with a null buffer it's meant to provide only the length of the data and return DXFILE_OK. Wine currently reports DXFILEERR_BADVALUE.
[1]http://developer.nvidia.com/forums/index.php?s=1bda5c9c604dcbe8177f7e9bc324e... [2]http://msdn.microsoft.com/en-us/library/bb174505(v=VS.85).aspx
http://bugs.winehq.org/show_bug.cgi?id=24406
tyle7@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tyle7@hotmail.com
--- Comment #7 from tyle7@hotmail.com 2010-12-11 14:05:42 CST --- (In reply to comment #5)
Created an attachment (id=32443)
--> (http://bugs.winehq.org/attachment.cgi?id=32443) [details]
Report number of vertex blend units correctly.
Can confirm that the patch fixes the bug. Treasure chests etc. are now visible.
http://bugs.winehq.org/show_bug.cgi?id=24406
Jayesh.Coupland@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |Jayesh.Coupland@gmail.com
--- Comment #8 from Jayesh.Coupland@gmail.com 2010-12-12 06:13:34 CST --- I can also confirm that the patch fixes the bug.(In reply to comment #7)
(In reply to comment #5)
Created an attachment (id=32443)
--> (http://bugs.winehq.org/attachment.cgi?id=32443) [details] [details]
Report number of vertex blend units correctly.
Can confirm that the patch fixes the bug. Treasure chests etc. are now visible.
Same here
http://bugs.winehq.org/show_bug.cgi?id=24406
--- Comment #9 from Marc Hartstein marcmagus@gmail.com 2010-12-13 12:05:16 CST --- (In reply to comment #6)
Excellent work, thanks!
Patch applies cleanly against 1.3.8, and I can confirm treasure chests and doors appear. The infamous Electrojelly now appears with its hit boxes, and can be defeated, meaning late-game content is now unlocked.
Unfortunately, upon using a door of returning immediately after fighting the Electrojelly, the game crashed on me with a page fault. I don't know if this is a regression introduced by this patch or the upgrade to 1.3.8 or a previously unknown bug uncovered. I'll try to gather more information and open a new bug.
http://bugs.winehq.org/show_bug.cgi?id=24406
A Wine user RandomAccountName@mail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |RandomAccountName@mail.com
http://bugs.winehq.org/show_bug.cgi?id=24406
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |adys.wh@gmail.com
--- Comment #10 from Jerome Leclanche adys.wh@gmail.com 2011-02-04 23:57:51 CST --- Should be fixed by f41fdb225cf1e1df494237664ce92e51179f3725, please retest.
http://bugs.winehq.org/show_bug.cgi?id=24406
--- Comment #11 from Jeremy Chin winehq@rekless.fastmail.fm 2011-02-05 00:51:17 CST --- (In reply to comment #10)
Should be fixed by f41fdb225cf1e1df494237664ce92e51179f3725, please retest.
It does fix it, but was reverted because it's the wrong way to fix this bug and may cause other problems.
http://bugs.winehq.org/show_bug.cgi?id=24406
Coffee on Mars coffeeonmars@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |coffeeonmars@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=24406
Alex Bradbury asb@asbradbury.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |asb@asbradbury.org
http://bugs.winehq.org/show_bug.cgi?id=24406
--- Comment #12 from Coffee on Mars coffeeonmars@gmail.com 2011-05-12 15:59:46 CDT --- I still see the invisible chests bug in 1.3.9.
Has some other work been done on the IDirectXFileObject::GetName problem, since the rejection of the patch above?
http://bugs.winehq.org/show_bug.cgi?id=24406
xangel1@mail.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |xangel1@mail.ru
http://bugs.winehq.org/show_bug.cgi?id=24406
Christian Costa titan.costa@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |titan.costa@gmail.com
--- Comment #13 from Christian Costa titan.costa@gmail.com 2012-02-20 04:34:22 CST --- GetName is corretly implemented now. See http://source.winehq.org/git/wine.git/commit/8cae5c23121ffbf76cce42947ac22a3...
http://bugs.winehq.org/show_bug.cgi?id=24406
GyB gyebro69@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gyebro69@gmail.com
--- Comment #14 from GyB gyebro69@gmail.com 2012-03-16 01:54:21 CDT --- Those objects in the dungeons are still invisible with wine-1.4-284-gc5faf15.
http://bugs.winehq.org/show_bug.cgi?id=24406
Taylor Gresser taylor.gresser@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |taylor.gresser@gmail.com
--- Comment #15 from Taylor Gresser taylor.gresser@gmail.com 2012-07-02 05:13:53 CDT --- These items are still invisible in 1.5.6.
http://bugs.winehq.org/show_bug.cgi?id=24406
--- Comment #16 from Christian Costa titan.costa@gmail.com 2013-06-20 16:52:25 CDT --- Is this issue still happens with latest git?
http://bugs.winehq.org/show_bug.cgi?id=24406
Jari Vetoniemi mailRoxas@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mailRoxas@gmail.com
--- Comment #17 from Jari Vetoniemi mailRoxas@gmail.com 2013-06-23 05:17:05 CDT --- Happens still with latest git.
http://bugs.winehq.org/show_bug.cgi?id=24406
--- Comment #18 from Jari Vetoniemi mailRoxas@gmail.com 2013-06-23 06:04:59 CDT --- Cherry-picking the reverted "f41fdb225cf1e1df494237664ce92e51179f3725" "fixes" the issue.
Looking at the diff, the issue is still that modern cards don't report ARB_VERTEX_BLEND extension, even if they support it(?).
Think this issue is duplicate of #6955
http://bugs.winehq.org/show_bug.cgi?id=24406
Matteo Bruni matteo.mystral@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |matteo.mystral@gmail.com
--- Comment #19 from Matteo Bruni matteo.mystral@gmail.com 2013-06-25 09:27:07 CDT --- (In reply to comment #18)
Think this issue is duplicate of #6955
Yes, it looks like that.
http://bugs.winehq.org/show_bug.cgi?id=24406
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |DUPLICATE
--- Comment #20 from Austin English austinenglish@gmail.com 2013-06-25 13:05:13 CDT --- (In reply to comment #19)
(In reply to comment #18)
Think this issue is duplicate of #6955
Yes, it looks like that.
Dupe.
*** This bug has been marked as a duplicate of bug 6955 ***
http://bugs.winehq.org/show_bug.cgi?id=24406
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #21 from Austin English austinenglish@gmail.com 2013-06-26 13:27:02 CDT --- Closing.
-
wine-bugs＠winehq.org