[Bug 57057] New: battle.net: invalid tray icon

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57057

Bug ID: 57057
           Summary: battle.net: invalid tray icon
           Product: Wine
           Version: 9.15
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

After upgrading from wine 9.14 to wine 9.15, battle.net application tray icon
got invalid image. Examples are in attachment.

I did git bisect, here are my results:

$ git bisect good
59f74560e95b0f78028f40b3759256a3c47660d4 is the first bad commit
commit 59f74560e95b0f78028f40b3759256a3c47660d4
Author: Esme Povirk 
Date:   Sat Jul 20 20:45:16 2024 +0000

win32u: Implement EVENT_SYSTEM_CAPTURESTART/END.

dlls/user32/tests/msg.c | 47 +++++++++++++++++++++++++----------------------
 dlls/win32u/input.c     |  6 ++++++
 2 files changed, 31 insertions(+), 22 deletions(-)

$ git bisect log
# bad: [ad8b2870312a373fb0ab0ff2cbf6d42b3f08c15a] Release 9.15.
# good: [dcd1eeb256c2258bf7610a32f0c676979dd71f35] Release 9.14.
git bisect start 'wine-9.15' 'wine-9.14'
# good: [35630dbdc308b66271fb9d694cf81bf0b7b67567] include: Add video encoder
color defines.
git bisect good 35630dbdc308b66271fb9d694cf81bf0b7b67567
# bad: [aad72aee08bf7a85dfe754f40395ebcd3f54f763] d3dx9: Return success in
D3DXLoadSurfaceFromMemory() for multisampled destination surfaces.
git bisect bad aad72aee08bf7a85dfe754f40395ebcd3f54f763
# bad: [57564c6b4be378738b584255b7f3b1dedc424f31] wined3d: Feed the precomputed
normal matrix through a push constant buffer.
git bisect bad 57564c6b4be378738b584255b7f3b1dedc424f31
# bad: [15f9e88a0a59aabf9c06c8381a61c6f78ca313ec] mshtml: Use host constructor
script bindings for Image constructor object.
git bisect bad 15f9e88a0a59aabf9c06c8381a61c6f78ca313ec
# bad: [94e9d4cd8345ee11bb7af0e9095254680261baea] kernel32: Implement
QueryIdleProcessorCycleTime[Ex]().
git bisect bad 94e9d4cd8345ee11bb7af0e9095254680261baea
# bad: [59f74560e95b0f78028f40b3759256a3c47660d4] win32u: Implement
EVENT_SYSTEM_CAPTURESTART/END.
git bisect bad 59f74560e95b0f78028f40b3759256a3c47660d4
# good: [30e88f6e0e221dbca2b3be881d6fbb55d4baa518] comctl32/propsheet: Create
pages with PSP_PREMATURE on initialization.
git bisect good 30e88f6e0e221dbca2b3be881d6fbb55d4baa518
# first bad commit: [59f74560e95b0f78028f40b3759256a3c47660d4] win32u:
Implement EVENT_SYSTEM_CAPTURESTART/END.

System: Gentoo Linux amd64, KDE6/X11.

[Bug 57057] battle.net: invalid tray icon

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57057

Esme Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 57057] battle.net: invalid tray icon

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57057

--- Comment #1 from i.Dark_Templar  ---
Created attachment 76919
  --> https://bugs.winehq.org/attachment.cgi?id=76919
tray.png

[Bug 57057] battle.net: invalid tray icon

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57057

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |59f74560e95b0f78028f40b3759
                   |                            |256a3c47660d4
           Keywords|                            |regression

[Bug 57057] battle.net: invalid tray icon

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57057

--- Comment #2 from Esme Povirk  ---
I checked a +hook log, and I didn't see any calls to NtUserSetWinEventHook, so
it shouldn't be possible for that patch to make any difference.

[Bug 57057] battle.net: invalid tray icon

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57057

--- Comment #3 from i.Dark_Templar  ---
You're right. I've rechecked, and it still reproduces on previous commit. Maybe
something went wrong due to not building from scratch and not using clean
prefix each time. I'll try bisecting again.

[Bug 57057] battle.net: invalid tray icon

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57057

i.Dark_Templar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|59f74560e95b0f78028f40b3759 |
                   |256a3c47660d4               |

--- Comment #4 from i.Dark_Templar  ---
I ran bisect again, and result wasn't much better. I can only assume that
something else causes this issue to appear sporadically.

[Bug 57057] battle.net: invalid tray icon

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57057

--- Comment #5 from Sven Baars  ---
Does this bug still occur with wine 10.0-rc3? I don't see any tray icon with
with wine 9.15 (different from the issue reported here, but still an issue),
but the tray icon seems to work fine for me with wine 10.0-rc3.

[Bug 57057] battle.net: invalid tray icon

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57057

--- Comment #6 from i.Dark_Templar  ---
No, it currently doesn't reproduce for me. But as I wrote earlier, it
reproduces somewhat spuriously, and I have no idea yet what causes it when it
appears.