[Bug 5725] Code for undocumented SwitchToThisWindow function does not reflect empirical evidence

[Wine Bugs]

http://bugs.winehq.org/show_bug.cgi?id=5725

------- Additional Comments From [e-mail]  2006-09-10 04:22 -------
(In reply to comment #34)
> win.c:3980: Test failed: [8] foreground window did not get sent to back

Well at least that's progress; although it looks like wine does something odd
with minimized windows it makes it pretty clear that the (previous) foreground
window has to be sent to the back. Please can you see if this helps:
     for (i = 0; i < sizeof(sttw_tests) / sizeof(sttw_test); ++i)
     {
-        hwnds[0] = CreateWindow( "static", "", WS_OVERLAPPEDWINDOW | WS_VISIBLE,
+        hwnds[0] = CreateWindow( "static", "", WS_OVERLAPPEDWINDOW | WS_VISIBLE,
                                  CW_USEDEFAULT, CW_USEDEFAULT,
                                  CW_USEDEFAULT, CW_USEDEFAULT,
                                  NULL, NULL, NULL, NULL );
-        ShowWindow( hwnds[0], sttw_tests[i].show );
         hwnds[1] = CreateWindowEx( exstyle[sttw_tests[i].topmost],
-                                   "static", "", WS_OVERLAPPEDWINDOW,
+                                   "static", "", WS_OVERLAPPEDWINDOW | WS_VISIBLE,
                                    CW_USEDEFAULT, CW_USEDEFAULT,
                                    CW_USEDEFAULT, CW_USEDEFAULT,
                                    NULL, NULL, NULL, NULL );
-        ShowWindow( hwnds[1], sttw_tests[i].show );
+        hwnd = hwnds[sttw_tests[i].which];
+        ShowWindow( hwnd, sttw_tests[i].show );
         SetActiveWindow( hwnds[1] );
         SetForegroundWindow( hwnds[1] );
-        hwnd = hwnds[sttw_tests[i].which];
+        ok( GetWindow(GetWindow(hwnds[1], GW_HWNDNEXT), GW_HWNDNEXT) != NULL,
+            "[%d] foreground window unexpectedly got sent to the back\n", i);
         SwitchToThisWindow( hwnd, sttw_tests[i].flag );
         /* On Windows, restoring a window is asynchronous. Give it 100ms */
[This is a hand-edited diff, so sorry if it doesn't apply to attachment 3547]