[Bug 10472] New: File open dialog buffer too short for multiple file selection

http://bugs.winehq.org/show_bug.cgi?id=10472

Summary: File open dialog buffer too short for multiple file
                    selection
           Product: Wine
           Version: 0.9.49.
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: wine-comctl32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

The file open dialog seems to be using a buffer which is too short for multiple
file selection. While Windows itself has this bug/feature, wine's version is
much more annoying since I'm unable to select over 6 files usually (using long
but not excessive names).
A dynamic buffer (with a reasonable limit for security reasons perhaps) would
be preferrable, but even a bigger buffer would help. 
I think windows' buffer is 4k.

[Bug 10472] File open dialog buffer too short for multiple file selection

http://bugs.winehq.org/show_bug.cgi?id=10472

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID

--- Comment #1 from Juan Lang   2007-11-16 15:37:28 ---
I'm afraid I can't confirm this.  dlls/comdlg32/filedlg.c's GetOpenFileNameA/W
use the OPENFILENAME structure that's passed in, and use its nMaxFile value to
allocate a dynamic buffer.

If you have an application that demonstrates the problem, and you're certain
the Windows behavior is different, please update the URL with an app we can
download and try it, and reopen.

[Bug 10472] File open dialog buffer too short for multiple file selection

http://bugs.winehq.org/show_bug.cgi?id=10472

--- Comment #2 from Claudio Freire   2007-11-25 19:46:40 ---
Created an attachment (id=9345)
 --> (http://bugs.winehq.org/attachment.cgi?id=9345)
AC3 codec

AC3 codec application that exhibits the bug (source and compiled binary)
It doesn't use libwine in any form, you must compile it with MSVC 6.0 (if you
wish to compile it)
Just click "Agregar" (add) and select many files of any kind, you'll notice
that you can't select more than 10 files usually (depends on filename length),
but on Windows you can usually select a lot more.
You'll need a lot of dependencies, libraries from Intel (freely available last
time I checked - Intel's Singal processing library).

[Bug 10472] File open dialog buffer too short for multiple file selection

http://bugs.winehq.org/show_bug.cgi?id=10472

Claudio Freire  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|INVALID                     |

--- Comment #3 from Claudio Freire   2007-11-25 19:53:08 ---
Oh... just another comment - I've noticed several other small bugs triggered by
this application. I'll try to document them all when I can properly identify
them.
I'm also checking the source to see if this is indeed bad API usage (and
Windows somehow lets me get away with it).

[Bug 10472] File open dialog buffer too short for multiple file selection

http://bugs.winehq.org/show_bug.cgi?id=10472

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, testcase

--- Comment #4 from Austin English   2008-06-12 12:58:09 ---
Is this still an issue in current (1.0-rc4 or newer) wine?

[Bug 10472] File open dialog buffer too short for multiple file selection

http://bugs.winehq.org/show_bug.cgi?id=10472

--- Comment #5 from Austin English   2008-12-10 00:58:55 ---
App doesn't run here:
austin@austin-desktop:~$ wine ac3codec.exe 
err:module:import_dll Library nsp.dll (which is needed by
L"Z:\home\austin\ac3codec.exe") not found
err:module:LdrInitializeThunk Main exe initialization for
L"Z:\home\austin\ac3codec.exe" failed, status c0000135

Where are you getting that dll from? Why didn't you bundle it?

[Bug 10472] File open dialog buffer too short for multiple file selection

http://bugs.winehq.org/show_bug.cgi?id=10472

--- Comment #6 from Claudio Freire   2008-12-10 05:54:37 ---
Created an attachment (id=17797)
 --> (http://bugs.winehq.org/attachment.cgi?id=17797)
required dll

[Bug 10472] File open dialog buffer too short for multiple file selection

http://bugs.winehq.org/show_bug.cgi?id=10472

--- Comment #7 from Claudio Freire   2008-12-10 06:25:01 ---
"nsp.dll" is part of Intel's signal processing library, along with several
other dlls. You can download it from intel's page, however, the library has
been largely overhauled since the application was developed and is now called
"Intel Integrated Performance Primitives",
http://www.intel.com/cd/software/products/asmo-na/eng/302910.htm

I don't know how compatible those two are (perhaps source-level compatible, but
I truly doubt they're binary compatible), so I'll be uploading the dlls as
well, however the attachment system doesn't let me do this (they are several
MBs in length), so I'll be posting a link to an FTP shortly.

To follow up on this bug, the latest versions of wine have fixes some of the
minor bugs I was referring to (many related to sound output and thread
synchronization issues), but I'll have to check with the latest to confirm
whether this specific bug is still there (I haven't tried the latest latest
wine yet).

[Bug 10472] File open dialog buffer too short for multiple file selection

http://bugs.winehq.org/show_bug.cgi?id=10472

Michael  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wine.8.madblock@spamgourmet
                   |                            |.com

--- Comment #8 from Michael   2009-06-26 09:37:49 ---
gentoo amd64, wine 1.1.24 here.

I also download mfc42.dll from dll-files.com to make this work, winetricks did
not help for some reason.

A messagebox appears:
No SPLib DLL was found in the waterfall procedure.

and wine reports:
# wine ac3codec.exe
err:module:attach_process_dlls "nsp.dll" failed to initialize, aborting
err:module:LdrInitializeThunk Main exe initialization for L"C:\Program
Files\test\ac3codec\Release\ac3codec.exe" failed, status c0000142

Could not get any further.

While trying to find another application, I stumbled over the following
problem:
VirtualDub 1.8.8 stable (http://virtualdub.sourceforge.net/) uses also the
common dialog. When resizing it and then selecting a different folder, the
file-view jumps back to default size, causing a large gray margin around it.

[Bug 10472] File open dialog buffer too short for multiple file selection

http://bugs.winehq.org/show_bug.cgi?id=10472

--- Comment #9 from Nikolay Sivov   2009-07-19 01:12:41 ---
Am I right this is a common dialog issue?

[Bug 10472] File open dialog buffer too short for multiple file selection

http://bugs.winehq.org/show_bug.cgi?id=10472

--- Comment #10 from Claudio Freire   2009-07-20 16:33:56 ---
Ok folks, this RAR has all the dependencies I believe:

http://www.deeplayer.com/claudio/orfeo/nsplib.rar

I could not test any of it with Wine 1.1.26, I'll try to build it at home and
give it a try, and then report any changes regarding the original behavior.

In any case, I tracked the behavior to MFC code, so I'm not sure why Windows
behaves better than wine, but wine seems to behave as advertised on Patform SDK
docs.

Perhaps windows stores relative paths and thus consumes less of the small
buffer than wine? Or perhaps wine under linux has longer paths than usual in
windows?

[Bug 10472] File open dialog buffer too short for multiple file selection

http://bugs.winehq.org/show_bug.cgi?id=10472

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|comctl32                    |comdlg32

[Bug 10472] File open dialog buffer too short for multiple file selection

http://bugs.winehq.org/show_bug.cgi?id=10472

Ian Berke  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Ian Berke   2009-12-16 08:53:56 ---
I have this problem as well using the scientific software sedfit or sedphat. 
In order to process my data I need to select hundreds of files at once.  The
dialog hangs for minutes when I select by holding down the shift key.  Don't
know if this is related but here is the output in the terminal when I select:

fixme:shell:ShellView_OnNotify LVN_KEYDOWN key=0x00000010
fixme:service:EnumServicesStatusW 0x148700 type=30 state=3 (nil) 0 0x87e7d0
0x87e7dc 0x87e7d8

This is a real killer and may force me to use the programs in a virtual box
where I know I don't have this problem.

[Bug 10472] File open dialog buffer too short for multiple file selection

http://bugs.winehq.org/show_bug.cgi?id=10472

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from [e-mail] 2012-05-16 14:07:44 CDT ---
No download, no update from OP or others for three years. Is this still an
issue in 1.5.4 or should this be closed as abandoned ?

[Bug 10472] File open dialog buffer too short for multiple file selection

http://bugs.winehq.org/show_bug.cgi?id=10472

--- Comment #13 from Claudio Freire  2012-05-16 17:15:38 CDT ---
What do you mean by "no download"? I linked a RAR with all the dependencies and
the link is still alive (I just checked).

My last comment of 2009 is as far as I've gotten regarding this. Wine's
behavior is as advertised on the Platform SDK, so the reason for the different
behavior is probably not directly related to the dialog but by how paths differ
between wine and real windows, probably being longer in linux.

I could suggest to make the dialog choose the shortest path from all the
possible ways of representing them: absolute vs relative, and different ways of
reaching the file from different drives. In my case, I always have C/D pointing
to real windows partitions, X: pointing to my linux home, and Z: pointing to
linux's root FS.

But, since behavior is correct regarding the Platform SDK, if you were to close
the bug, I'd close it as invalid.

[Bug 10472] File open dialog buffer too short for multiple file selection

http://bugs.winehq.org/show_bug.cgi?id=10472

--- Comment #14 from [e-mail] 2012-05-18 07:08:58 CDT ---
Sorry about the donwload bit, you are correct :)

[Bug 10472] File open dialog buffer too short for multiple file selection

http://bugs.winehq.org/show_bug.cgi?id=10472

--- Comment #15 from Bruno Jesus  ---
Unfortunately the URL to download the dependencies is no longer working
(http://www.deeplayer.com/claudio/orfeo/nsplib.rar), I tried 3 different
versions of the DLL but each time other DLLs are required and when I got all of
them there was a function missing in one of the DLLs. For some reason with the
same DLLs the application works in wine and it's possible to see the issue, I
would like to test in different versions of windows to check.

[Bug 10472] File open dialog buffer too short for multiple file selection

http://bugs.winehq.org/show_bug.cgi?id=10472

--- Comment #16 from Bruno Jesus  ---
This runtime looked promising:
http://www.satsignal.eu/software/runtime.html#LibraryBundle

But didn't work too.

[Bug 10472] File open dialog buffer too short for multiple file selection

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=10472

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from Fabian Maurer  ---
Is this still an issue? If so, is there a way to reproduce as of 2024?