[Bug 51616] New: Unravel Two crashes on intro

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51616

Bug ID: 51616
           Summary: Unravel Two crashes on intro
           Product: Wine
           Version: 6.15
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Assertion failed!

Program: C:\Program Files
(x86)\Steam\steamapps\common\UnravelTwo\UnravelTwo.exe
File: ../wine/dlls/quartz/memallocator.c
Line: 346

Expression: "ms->ref == 0"

Renaming 'V' folder in 'GameFolder\D3D11' is a workaround.

[Bug 51616] Unravel Two crashes on intro

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51616

--- Comment #1 from Gijs Vermeulen  ---
Could you attach a +quartz log?

[Bug 51616] Unravel Two crashes on intro

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51616

--- Comment #2 from Andrey Gusev  ---
Created attachment 70474
  --> https://bugs.winehq.org/attachment.cgi?id=70474
+quartz

[Bug 51616] Unravel Two crashes on intro

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51616

Brendan McGrath  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Brendan McGrath  ---
Created attachment 72697
  --> https://bugs.winehq.org/attachment.cgi?id=72697
Fix "Assertion failed!"

This patch fixes the "Assertion failed!" error.

The issue is that the "ugly" work-around assumes that if a reference is added
during the callback, then it has been leaked. So the work-around takes
responsibility for freeing it up.

However, in Unravel Two, the "leaked" reference is also freed by the
application, resulting in the reference count being decremented below zero
(resulting in a negative overflow).

This results in the assertion failure at dlls/quartz/memallocator.c:346;
because instead of being zero, the reference has a value of 4294967295 (or
minus one).

[Bug 51616] Unravel Two crashes on intro

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51616

--- Comment #4 from Brendan McGrath  ---
I've submitted this patch to the mailing list.

https://source.winehq.org/patches/data/241639

[Bug 51616] Unravel Two crashes on intro

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51616

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |1113f42aa748d9e0a27c4663b9d
                   |                            |8de1237f95e73
         Resolution|---                         |FIXED
          Component|-unknown                    |quartz

--- Comment #5 from Andrey Gusev  ---
Fixed by
https://source.winehq.org/git/wine.git/commit/1113f42aa748d9e0a27c4663b9d8de...

[Bug 51616] Unravel Two crashes on intro

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51616

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 7.14.