[Bug 23952] New: wine can't launch fullscreen DirectX applications with enabled dri

http://bugs.winehq.org/show_bug.cgi?id=23952

Summary: wine can't launch fullscreen DirectX applications with
                    enabled dri
           Product: Wine
           Version: 1.2
          Platform: x86
        OS/Version: FreeBSD
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=30069)
 --> (http://bugs.winehq.org/attachment.cgi?id=30069)
Xorg log file

When I launch any full-screen DirectX windows application, I get following
error:
> wine fallout2.exe

X Error of failed request:  BadMatch (invalid parameter attributes)
  Major opcode of failed request:  1 (X_CreateWindow)
  Serial number of failed request:  397
  Current serial number in output stream:  399

However, when I disable DRI, most of my Windows games works.  I have ATI Radeon
1600 Pro video adapter. X logs and config are attached.

[Bug 23952] wine can't launch fullscreen DirectX applications with enabled dri

http://bugs.winehq.org/show_bug.cgi?id=23952

--- Comment #1 from Alexander Pyhalov   2010-08-09 10:40:50 ---
Created an attachment (id=30070)
 --> (http://bugs.winehq.org/attachment.cgi?id=30070)
xorg.conf

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

http://bugs.winehq.org/show_bug.cgi?id=23952

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|wine can't launch           |Fullscreen DirectX
                   |fullscreen DirectX          |applications with enabled
                   |applications with enabled   |DRI won't start
                   |dri                         |

--- Comment #2 from Dmitry Timoshkov   2010-08-11 01:41:05 ---
Probably a video driver bug. What driver are you using? Is that a 64-bit OS?

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

http://bugs.winehq.org/show_bug.cgi?id=23952

--- Comment #3 from Alexander Pyhalov   2010-08-11 01:54:57 ---
(In reply to comment #2)
> Probably a video driver bug. What driver are you using? Is that a 64-bit OS?

I use "radeon" driver. It's 32bit OS. I'll try it with radeonhd and respond
later.

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

http://bugs.winehq.org/show_bug.cgi?id=23952

--- Comment #4 from Henri Verbeet   2010-08-11 04:37:59 ---
(In reply to comment #3)
> I use "radeon" driver. It's 32bit OS. I'll try it with radeonhd and respond
> later.

Please don't use radeonhd, it's not going to make things better. You should
probably try filing a bug at bugs.freedesktop.org, but I suspect this is a
configuration issue, like mismatched GL libraries. For example, the following
lines look suspect to me:
> (II) AIGLX: Loaded and initialized /usr/local/lib/dri/swrast_dri.so
> (II) GLX: Initialized DRISWRAST GL provider for screen 0

I think X1600 Pro is r500 series, so you'd want that to be r300_dri.so or
r300g_dri.so.

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

http://bugs.winehq.org/show_bug.cgi?id=23952

--- Comment #5 from Alexander Pyhalov   2010-08-11 09:55:27 ---
Created an attachment (id=30102)
 --> (http://bugs.winehq.org/attachment.cgi?id=30102)
Xorg log, AIGLX enabled

Turned on AIGLX support in Xorg. X logs changed, wine behavior is the same:
wine fallout2.exe 
X Error of failed request:  BadMatch (invalid parameter attributes)
  Major opcode of failed request:  1 (X_CreateWindow)
  Serial number of failed request:  397
  Current serial number in output stream:  399

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

http://bugs.winehq.org/show_bug.cgi?id=23952

--- Comment #6 from Alexander Pyhalov   2010-08-19 23:34:21 ---
I've just found out that wine-1.1.30 doesn't have this particular bug when it
is running with DRI enabled.

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

http://bugs.winehq.org/show_bug.cgi?id=23952

Alexander Pyhalov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

http://bugs.winehq.org/show_bug.cgi?id=23952

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Austin English   2010-08-20 08:17:05 ---
Fixed then.

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

http://bugs.winehq.org/show_bug.cgi?id=23952

--- Comment #8 from Alexander Pyhalov   2010-08-20 09:17:16 ---
(In reply to comment #7)
> Fixed then.

I must have misunderstood you. I've written that the bug exists in wine-1.2,
but there is no this bug in 1.1.30. This looks like a regression. Why have you
marked as fixed?

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

http://bugs.winehq.org/show_bug.cgi?id=23952

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |

--- Comment #9 from Austin English   2010-08-20 10:18:05 ---
(In reply to comment #8)
> (In reply to comment #7)
> > Fixed then.
>
> I must have misunderstood you. I've written that the bug exists in wine-1.2,
> but there is no this bug in 1.1.30. This looks like a regression. Why have you
> marked as fixed?

Because I misread that as 1.3, sorry.

Please run a regression test:
http://wiki.winehq.org/RegressionTesting

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

http://bugs.winehq.org/show_bug.cgi?id=23952

--- Comment #10 from Alexander Pyhalov   2010-08-20 17:39:45 ---
> Please run a regression test:
> http://wiki.winehq.org/RegressionTesting

I've just spent some time on testing. Results are the following:

works [5b0de0d569f9621967fc38bf8b686f4ae9d0962a] cmd: Remove variable useinput
which is not really used from WCMD_more. (1.1.43-547-g5b0de0d)

works [5eedf51df69219ab44e2878ddacf6e002cdb08dc] comctl32/rebar: Try to center
child rectangle only if cyChild height is not zero. (1.1.43-583-g5eedf51)

works [e45926d582ea3887f8ade611365654174cdd754f] wined3d: Don't crash during
initialization if the adapter doesn't have full GL info (1.1.43-592-ge45926d)

doesn't work [d367314b463e47aa24dea801f0789f459b3dcf4d] msvcrt: Added
_mbstrlen_l implementation (1.1.43-594-gd367314)

doesn't work [7352ee844e98d03561fe31c9cc7b6d9e625b56c6] msvcrt: Added
mbstowcs(_s_l) implementation (1.1.43-595-g7352ee8)

doesn't work [2eb4b694a7256c4a5c418363501ef1b8122b84a4] msvcrt: Added mbstowcs
and wcstombs tests

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

http://bugs.winehq.org/show_bug.cgi?id=23952

--- Comment #11 from Alexander Pyhalov   2010-08-20 18:40:42 ---
(In reply to comment #10)
> > Please run a regression test:
> > http://wiki.winehq.org/RegressionTesting
>
> I've just spent some time on testing. Results are the following:
>
> works [5b0de0d569f9621967fc38bf8b686f4ae9d0962a] cmd: Remove variable useinput

I've made some more tests and not sure about previous results.
When I do 
"git reset 6c0e61cd65c5a9bacb46608c116d99e81bd12131",
configure, gmake clean, gmake , rm -fr ~/.wine and run compiled wine I get the
same error... However when I did git bisect this revision worked. What am I
doing wrong? :)

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

http://bugs.winehq.org/show_bug.cgi?id=23952

--- Comment #12 from Alexander Pyhalov   2010-08-20 19:25:17 ---
> I've made some more tests and not sure about previous results.
> When I do 
> "git reset 6c0e61cd65c5a9bacb46608c116d99e81bd12131",
> configure, gmake clean, gmake , rm -fr ~/.wine and run compiled wine I get the
> same error... However when I did git bisect this revision worked. What am I
> doing wrong? :)

It seems, results are right. At least, revision
"6c0e61cd65c5a9bacb46608c116d99e81bd12131" is working... I really rare work
with git....

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

http://bugs.winehq.org/show_bug.cgi?id=23952

--- Comment #13 from Alexander Pyhalov   2010-08-21 02:14:03 ---
(In reply to comment #12)
> It seems, results are right. At least, revision
> "6c0e61cd65c5a9bacb46608c116d99e81bd12131" is working... I really rare work
> with git....

So, I've checked my test results. Offending commit is
df6cd82ccf5dd03b0362a7ea571e14d66bbc5d72 winex11: Create a window of the
appropriate visual to initialize GL info.

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

http://bugs.winehq.org/show_bug.cgi?id=23952

--- Comment #14 from Nicholas Niro  2011-02-14 22:45:59 CST ---
Created an attachment (id=33297)
 --> (http://bugs.winehq.org/attachment.cgi?id=33297)
Patch that might fix this issue.

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

http://bugs.winehq.org/show_bug.cgi?id=23952

--- Comment #15 from Alexander Pyhalov  2011-02-16 14:18:21 CST ---
(In reply to comment #14)
> Created an attachment (id=33297)

--> (http://bugs.winehq.org/attachment.cgi?id=33297) [details]
> Patch that might fix this issue.

Thank you, this really works!

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

http://bugs.winehq.org/show_bug.cgi?id=23952

Michal Suchanek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from Michal Suchanek  2011-03-16 16:59:44 CDT ---
I had this issue with radeon r300 driver but it seems gone with Mesa 7.11 or X
1.9.4.901.
Never noticed this with r600 driver.

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

http://bugs.winehq.org/show_bug.cgi?id=23952

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |df6cd82ccf5dd03b0362a7ea571
                   |                            |e14d66bbc5d72

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

http://bugs.winehq.org/show_bug.cgi?id=23952

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from André H.  2011-08-13 16:00:27 CDT ---
(In reply to comment #14)
> Created an attachment (id=33297)

--> (http://bugs.winehq.org/attachment.cgi?id=33297) [details]
> Patch that might fix this issue.

Nicholas, could you please try again sending it to wine-patches?

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

http://bugs.winehq.org/show_bug.cgi?id=23952

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #18 from Alexandre Julliard  2011-08-26 07:35:44 CDT ---
Fix committed.

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

http://bugs.winehq.org/show_bug.cgi?id=23952

--- Comment #19 from Austin English  2011-08-26 13:23:05 CDT ---
(In reply to comment #18)
> Fix committed.

http://source.winehq.org/git/wine.git/commitdiff/7aff865e8e1890929c15bc91a39...

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

http://bugs.winehq.org/show_bug.cgi?id=23952

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #20 from Alexandre Julliard  2011-08-26 13:24:18 CDT ---
Closing bugs fixed in 1.3.27.

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

http://bugs.winehq.org/show_bug.cgi?id=23952

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #21 from Alexandre Julliard  2011-10-17 17:10:07 CDT ---
*** Bug 23771 has been marked as a duplicate of this bug. ***

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

https://bugs.winehq.org/show_bug.cgi?id=23952

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |7aff865e8e1890929c15bc91a39
                   |                            |f4fb11a46d9eb

[Bug 23952] Fullscreen DirectX applications with enabled DRI won't start

https://bugs.winehq.org/show_bug.cgi?id=23952

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|-unknown                    |winex11.drv