[Bug 12486] New: Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

Summary: Microsoft Office Standard 2007 installation failure
           Product: Wine
           Version: 0.9.58.
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=12047)
 --> (http://bugs.winehq.org/attachment.cgi?id=12047)
console error messages

The installation does not crash, but does not continue with an error message
about missing or corrupted files. The message is in (Brazilian) Portuguese, bt
says something like:
-----
Installation Error(Window Title)

Installation cannot continue because a required file is corrupted or
unavailable. Execute the installation again from the source disk or download
place(?or site?).
-----
Tested on Ubuntu Hardy Heron Beta with wine 0.9.59. strangely, bugzilla only
lists up to 0.9.58.

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

Tiago Freire  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
            Version|0.9.58.                     |unspecified

--- Comment #1 from Tiago Freire   2008-04-10 13:45:03 ---
Additionally: the splash window show up briefly  before the dialog with the
error message shows up.

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

Andras Kovacs  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Andras Kovacs   2008-04-11 18:43:46 ---
this is a builtin msxml3 bug (unimplemented interface), with native it goes
further, then crashes in builtin rpcrt4.

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |msxml3

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

--- Comment #3 from Alistair Leslie-Hughes   2008-04-25 09:01:55 ---
What interfaces are not implemented?

The only ones I see are
{6d5140c1-7436-11ce-8034-00aa006009fa} = IServiceProvider
{79eac9e4-baf9-11ce-8c82-00aa004ba90b} = IInternetProtocol

Can you provide a +msxml log please?

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

--- Comment #4 from Jaime Rave   2008-04-25 13:38:03 ---
Created an attachment (id=12471)
 --> (http://bugs.winehq.org/attachment.cgi?id=12471)
+msxml Console Output

+msxml Log

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

Rob Shearman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #5 from Rob Shearman   2008-04-26 03:36:15 ---
Huw looked into this bug briefly and thought that it could be due to the
xmlnode_get_xml call not returning exactly the same text as with native. It
could be that Office 2007's setup depends on the whitespace being a certain way
in the returned string.

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

--- Comment #6 from James Hawkins   2008-04-26 03:40:13 ---
The problem is that libxml2 strips \r\l from the original file, while msxml
keeps them.

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

--- Comment #7 from Austin English   2008-06-12 17:05:47 ---
Still present in 1.0-rc4.

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

joao.eiras  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

joao.eiras  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Alistair Leslie-Hughes   2008-06-25 00:59:46 ---
Created an attachment (id=14338)
 --> (http://bugs.winehq.org/attachment.cgi?id=14338)
Attempt to keep formating when dumping xml

Can someone try this patch to see if it helps, I don't have access to office
2007.

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

--- Comment #9 from Austin English   2008-06-27 01:06:43 ---
(In reply to comment #8)
> Created an attachment (id=14338)

--> (http://bugs.winehq.org/attachment.cgi?id=14338) [details]
> Attempt to keep formating when dumping xml
>
> Can someone try this patch to see if it helps, I don't have access to office
> 2007.

Doesn't work for me. I'll attach a new +msxml log for you.

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

--- Comment #10 from Austin English   2008-06-27 01:08:31 ---
Created an attachment (id=14385)
 --> (http://bugs.winehq.org/attachment.cgi?id=14385)
+msxml log (with patch) in git

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

--- Comment #11 from joao.eiras   2008-06-27 02:55:04 ---
I recall the msxml log telling me that it did not support nodes with node type
8 (comments node), and the installation failed thereafter, but that was some
time ago. I don't know if our msxml was updated since then. The Office
installer stores a digital signature in a xml file inside a comment. I think
that the installer then reads the sig and validates something.

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

--- Comment #12 from James Hawkins   2008-06-27 10:33:31 ---
(In reply to comment #11)
> I recall the msxml log telling me that it did not support nodes with node type
> 8 (comments node), and the installation failed thereafter, but that was some
> time ago. I don't know if our msxml was updated since then. The Office
> installer stores a digital signature in a xml file inside a comment. I think
> that the installer then reads the sig and validates something.

No, the exact problem is stated in comment #6.

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from James Hawkins   2008-06-27 10:33:31 ---
(In reply to comment #11)
> I recall the msxml log telling me that it did not support nodes with node type
> 8 (comments node), and the installation failed thereafter, but that was some
> time ago. I don't know if our msxml was updated since then. The Office
> installer stores a digital signature in a xml file inside a comment. I think
> that the installer then reads the sig and validates something.

No, the exact problem is stated in comment #6.

--- Comment #13 from Anastasius Focht   2008-07-02 05:10:02 ---
Hello,

is there any decision made yet to fork/replace/bugger libxml?
I don't see any argument to convince the libxml guys for incorporating such
breaking "feature".

The stripping of \r in \r\n sequences and handling of other format characters
when parsing is mandated by the XML specification - that's how they implemented
it.

http://www.w3.org/TR/2006/REC-xml-20060816/#sec-line-ends
http://www.w3.org/TR/2006/REC-xml-20060816/#sec-white-space

The office installer uses a custom variant of signed XML, calculating a hash of
document element and all child data (usually all stuff between
<Setup></Setup>).
As already pointed out, all the line ends and formatting have to be *kept* to
let the installer's XML verification succeed.

Just for illustration, the XML buffer dumps before being given to hash
calculation:

--- snip windows xml dump ---
+00  3C 00 53 00|65 00 74 00|75 00 70 00|20 00 49 00| <.S.e.t.u.p. .I.
+10  64 00 3D 00|22 00 45 00|78 00 63 00|65 00 6C 00| d.=.".E.x.c.e.l.
+20  2E 00 64 00|65 00 2D 00|64 00 65 00|22 00 20 00| ..d.e.-.d.e.". .
[phone]|70 00 65 00|3D 00 22 00|41 00 64 00| T.y.p.e.=.".A.d.
+40  64 00 4F 00|6E 00 22 00|20 00 4B 00|65 00 79 00| d.O.n.". .K.e.y.
+50  77 00 6F 00|72 00 64 00|3D 00 22 00|45 00 78 00| w.o.r.d.=.".E.x.
[phone]|6C 00 4D 00|55 00 49 00|22 00 20 00| c.e.l.M.U.I.". .
[phone]|6C 00 74 00|75 00 72 00|65 00 3D 00| C.u.l.t.u.r.e.=.
[phone]|65 00 2D 00|64 00 65 00|22 00 3E 00| ".d.e.-.d.e.".>.
+90  0D 00 0A 00|09 00 3C 00|4F 00 70 00|74 00 69 00| ......<.O.p.t.i.
..
--- snip windows xml dump ---

0x0D, 0x0A, 0x09, 0x20

This is what it looks like in libxml (keep format):
NOTE: the memory dump is from another XML file but it should give the idea:

--- snip wine xml dump ---
+00  3C 00 53 00|65 00 74 00|75 00 70 00|20 00 49 00| <.S.e.t.u.p. .I.
+10  64 00 3D 00|22 00 50 00|6F 00 77 00|65 00 72 00| d.=.".P.o.w.e.r.
+20  50 00 6F 00|69 00 6E 00|74 00 2E 00|64 00 65 00| P.o.i.n.t...d.e.
+30  2D 00 64 00|65 00 22 00|20 00 54 00|79 00 70 00| -.d.e.". .T.y.p.
+40  65 00 3D 00|22 00 41 00|64 00 64 00|4F 00 6E 00| e.=.".A.d.d.O.n.
[phone]|4B 00 65 00|79 00 77 00|6F 00 72 00| ". .K.e.y.w.o.r.
+60  64 00 3D 00|22 00 50 00|6F 00 77 00|65 00 72 00| d.=.".P.o.w.e.r.
+70  50 00 6F 00|69 00 6E 00|74 00 4D 00|55 00 49 00| P.o.i.n.t.M.U.I.
[phone]|43 00 75 00|6C 00 74 00|75 00 72 00| ". .C.u.l.t.u.r.
+90  65 00 3D 00|22 00 64 00|65 00 2D 00|64 00 65 00| e.=.".d.e.-.d.e.
+A0  22 00 3E 00|0A 00 20 00|20 00 3C 00|4F 00 70 00| ".>... . .<.O.p.
..
--- snip wine xml dump ---

0x0A, 0x20

Regards

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

--- Comment #14 from Austin English   2008-07-02 08:21:26 ---
Thanks, as always, for the analysis Anastastius. Alistair is working on a fix,
but apparently it's a doozie. I offered him my copy of office to borrow before
I go on vacation, but apparently he now has access to one. Hopefully we'll have
a fix soon, so I can file more Office 2007 bugs ;-).

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14338|0                           |1
        is obsolete|                            |

--- Comment #15 from Alistair Leslie-Hughes   2008-07-09 01:29:15 ---
Created an attachment (id=14686)
 --> (http://bugs.winehq.org/attachment.cgi?id=14686)
Correctly format the xml for office 2007

This patch will allow the Installer to validated each of the XML documents.

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

--- Comment #16 from joao.eiras   2008-07-09 02:40:30 ---
I'm sure your patch works, and you can go further on with the installer, but
this cannot be taken into the main tree, because:
1) this would afect all XML buffers, and not only office2007 ones, and could
break others. We really need is some sotr of costumization on the libxml side.
\r\n is the new line char sequence on windows, but you can have only \n or \r
too.
2) you're doing 2 O(n) cycles, looping byte by byte, which adds a performance
penalty

Good work though :)

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

--- Comment #17 from Austin English   2008-07-09 04:46:09 ---
(In reply to comment #15)
> Created an attachment (id=14686)

--> (http://bugs.winehq.org/attachment.cgi?id=14686) [details]
> Correctly format the xml for office 2007
> This patch will allow the Installer to validated each of the XML documents.

A testcase would be very helpful in these convulted situations.

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

--- Comment #18 from Alistair Leslie-Hughes   2008-07-09 05:48:58 ---
> A testcase would be very helpful in these convulted situations.

Hmmm, the basic scenario is, all \n are changed to \r\n\t.

Using this example.
<jjj>\n<HH>aa</HH><HH1>aa</HH1></jjj>

msxml3 produces
<jjj>
    <HH>aa</HH><HH1>aa</HH1></jjj>       <-- Note: all on one line

whereas libxml will produce
<jjj>
    <HH>aa</HH>
    <HH1>aa</HH1>
</jjj>

Using libxml we cannot reproduce formatting exactly.

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #19 from Alistair Leslie-Hughes   2008-07-28 17:37:47 ---
A patch has been accept to fix this issue.

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #20 from Alexandre Julliard   2008-08-22 10:46:19 ---
Closing bugs fixed in 1.1.3.

[Bug 12486] Microsoft Office Standard 2007 installation failure

http://bugs.winehq.org/show_bug.cgi?id=12486

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Installer
      Fixed by SHA1|                            |95660514d34709d89228ec84940
                   |                            |8f4205ea38f05
            Version|unspecified                 |0.9.59.