[Bug 21876] New: Demo Need for Speed Underground 1 crashes

http://bugs.winehq.org/show_bug.cgi?id=21876

Summary: Demo Need for Speed Underground 1 crashes
           Product: Wine
           Version: 1.1.38
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

This bug is about crashing, when intro is finished and game asks for "Press
enter to continue". Here you have to click left mouse (because keyboard is not
working due to unimplemented "EnumDevicesBySemantics & co") and game
immediately crashes instead of displaying the game menu.

Bisection between working 1.1.37 and crashing 1.1.38 reveals, that i need to
revert following two commits on top of 1.1.38:

* wine-1.1.37-304-g4a8f93b
     commit    4a8f93baded2cc56b1154d4c2c3d8d696441bd38
     wined3d: Handle a zero source value for WINED3DSIH_LOG.

* wine-1.1.37-306-gadf4ca2 (manually reverted)
     commit    adf4ca2e23873811a22fc82022f5d7753e9d569a
     wined3d: Handle a zero source value for WINED3DSIH_RSQ.

...and Demo of NFS 1 works again in 1.1.38. Maybe related with bug 21627
(WINED3DSIH_NRM) and bug 21641 (WINED3DSIH_RCP), i.e. both are different
commits.

Download link:
http://www.gamershell.com/download_4024.shtml

[Bug 21876] Demo Need for Speed Underground 1 crashes

http://bugs.winehq.org/show_bug.cgi?id=21876

--- Comment #1 from Wylda   2010-02-27 04:21:36 ---
Created an attachment (id=26514)
 --> (http://bugs.winehq.org/attachment.cgi?id=26514)
Diff between console output: crashing 1.1.38 and reverted working 1.1.38

[Bug 21876] Demo Need for Speed Underground 1 crashes

http://bugs.winehq.org/show_bug.cgi?id=21876

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression
                URL|                            |http://www.gamershell.com/d
                   |                            |ownload_4024.shtml

[Bug 21876] Demo Need for Speed Underground 1 crashes

http://bugs.winehq.org/show_bug.cgi?id=21876

NSLW  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                   |                            |m

--- Comment #2 from NSLW   2010-03-07 10:35:54 ---
I can confirm that full version of NFS Underground also crashes in the same
way.
The crash doesn't occur on Wine 1.1.37.

OS: Fedora 12 32 bit
GFX: NVIDIA 9xxx on 195.36.03 drivers version

It seems that no one bothers to fix regressions.

[Bug 21876] Demo Need for Speed Underground 1 crashes

http://bugs.winehq.org/show_bug.cgi?id=21876

--- Comment #3 from Henri Verbeet   2010-03-18 12:21:17 ---
Created an attachment (id=26876)
 --> (http://bugs.winehq.org/attachment.cgi?id=26876)
patch

This patch may help. Still need to write proper tests.

[Bug 21876] Demo Need for Speed Underground 1 crashes

http://bugs.winehq.org/show_bug.cgi?id=21876

--- Comment #4 from Wylda   2010-03-18 15:16:26 ---
(In reply to comment #3)
> This patch may help. Still need to write proper tests.

Henri, this one is total success :-D   Keep up the good work...

[Bug 21876] Demo Need for Speed Underground 1 crashes

http://bugs.winehq.org/show_bug.cgi?id=21876

Andras Kovacs  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Andras Kovacs   2010-03-18 20:14:28 ---
(In reply to comment #4)
> (In reply to comment #3)
> > This patch may help. Still need to write proper tests.
>
> Henri, this one is total success :-D   Keep up the good work...

It fixes most wanted, carbon, underground 1 & 2 random crashes.

[Bug 21876] Demo Need for Speed Underground 1 crashes

http://bugs.winehq.org/show_bug.cgi?id=21876

Andrew Nguyen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Andrew Nguyen   2010-04-05 06:03:56 ---
*** Bug 22275 has been marked as a duplicate of this bug. ***

[Bug 21876] Demo Need for Speed Underground 1 crashes

http://bugs.winehq.org/show_bug.cgi?id=21876

--- Comment #7 from NSLW   2010-05-09 14:02:44 ---
Created an attachment (id=27828)
 --> (http://bugs.winehq.org/attachment.cgi?id=27828)
patch for Wine 1.1.44

Old patch doesn't compile with Wine 1.1.44 so I updated it. I don't know if
it's correct but NFS Underground 2 runs without crash with it.

[Bug 21876] Demo Need for Speed Underground 1 crashes

http://bugs.winehq.org/show_bug.cgi?id=21876

--- Comment #8 from Wylda   2010-05-14 04:13:04 ---
(In reply to comment #3)
> This patch may help. Still need to write proper tests.

Hi Henri, would it be possible to apply this patch even without tests and write
the tests latter? Because 1.2 is knocking on the door and this patch fixes
quite a bunch of games.

I could test many games with this patch. I know it's not the same as tests
included in git, but as an additional value i offer free ;) cooperation and
regressions tests, if this causes some regression(reveals hidden bugs), so we
can quickly identify them.

[Bug 21876] Demo Need for Speed Underground 1 crashes

http://bugs.winehq.org/show_bug.cgi?id=21876

--- Comment #9 from Henri Verbeet   2010-05-14 11:10:11 ---
(In reply to comment #8)
> (In reply to comment #3)
> > This patch may help. Still need to write proper tests.
>
> Hi Henri, would it be possible to apply this patch even without tests and write
> the tests latter? Because 1.2 is knocking on the door and this patch fixes
> quite a bunch of games.

The tests are mostly needed to identify the correct place to change the FPU
control word. This patch effectively changes it for draw functions only, but
that's somewhat unlikely to be the correct place. I suspect all d3d8/d3d9
device functions should do this (depending on the create flags), similar to
ddraw.

[Bug 21876] Demo Need for Speed Underground 1 crashes

http://bugs.winehq.org/show_bug.cgi?id=21876

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26876|0                           |1
        is obsolete|                            |

--- Comment #10 from Henri Verbeet   2010-05-25 11:11:57 ---
Created an attachment (id=28273)
 --> (http://bugs.winehq.org/attachment.cgi?id=28273)
patch

How does this patch work? It seems d3d8 and d3d9 only set the FPU control word
when the device is created. In a quick test this seemed to be enough for NFSU,
haven't tested others.

[Bug 21876] Demo Need for Speed Underground 1 crashes

http://bugs.winehq.org/show_bug.cgi?id=21876

--- Comment #11 from Wylda   2010-05-25 11:24:17 ---
> How does this patch work? It seems d3d8 and d3d9 only set the FPU control word
> when the device is created. In a quick test this seemed to be enough for NFSU,
> haven't tested others.

Hi Henri, unfortunately i will be out of my machine till this Thursday, but
than i will gladly give it a try for a whole NFS series (which i own:)

[Bug 21876] Demo Need for Speed Underground 1 crashes

http://bugs.winehq.org/show_bug.cgi?id=21876

--- Comment #12 from Andrew Nguyen   2010-05-25 14:33:45 ---
(In reply to comment #10)
> Created an attachment (id=28273)

--> (http://bugs.winehq.org/attachment.cgi?id=28273) [details]
> patch
>
> How does this patch work? It seems d3d8 and d3d9 only set the FPU control word
> when the device is created. In a quick test this seemed to be enough for NFSU,
> haven't tested others.

The patch seems to be effective for the Need for Speed Underground Demo. I'll
have to reobtain other NFS demos for testing.

[Bug 21876] Demo Need for Speed Underground 1 crashes

http://bugs.winehq.org/show_bug.cgi?id=21876

--- Comment #13 from Henri Verbeet   2010-05-26 12:35:37 ---
Should be fixed by e6611e22fb037a879205f1330d1a3485f9f18705.

[Bug 21876] Demo Need for Speed Underground 1 crashes

http://bugs.winehq.org/show_bug.cgi?id=21876

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Wylda   2010-05-27 13:17:47 ---
(In reply to comment #13)
> Should be fixed by e6611e22fb037a879205f1330d1a3485f9f18705.

Hi Henri, yes it fixes the problem also for me. Thank you for this one!!

[Bug 21876] Demo Need for Speed Underground 1 crashes

http://bugs.winehq.org/show_bug.cgi?id=21876

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #15 from Alexandre Julliard   2010-05-28 12:51:21 ---
Closing bugs fixed in 1.2-rc2.