http://bugs.winehq.org/show_bug.cgi?id=30752
Bug #: 30752 Summary: Open/save file dialog "New Folder" button doesn't show new folder Product: Wine Version: 1.3.25 Platform: x86 OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: shell32 AssignedTo: wine-bugs@winehq.org ReportedBy: aeikum@codeweavers.com Classification: Unclassified
See the description from Bug 18606, which was fixed by 0a55ec2c9e1dc5fd0b99ad1202fd7849b0187808. The bug is back again, but no test failures show in <dlls/shell32/tests>.
Regression testing reveals:
cde4993d625decec31d25485c7a588a3b772ef8b is the first bad commit commit cde4993d625decec31d25485c7a588a3b772ef8b Author: Jay Yang jkelleyy@gmail.com Date: Mon Jul 11 17:35:35 2011 -0400
shell32: Have the default shell view call SHChangeNotifyRegister with unixfs pidls.
:040000 040000 833232977eb625754bef7c0d2f09c065574df0d9 cccb55d925c166ba3838b0179cbdd655a44ba26a M dlls
http://bugs.winehq.org/show_bug.cgi?id=30752
Andrew Eikum aeikum@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression, source CC| |jkelleyy@gmail.com Regression SHA1| |cccb55d925c166ba3838b0179cb | |dd655a44ba26a
http://bugs.winehq.org/show_bug.cgi?id=30752
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1|cccb55d925c166ba3838b0179cb |cde4993d625decec31d25485c7a |dd655a44ba26a |588a3b772ef8b
http://bugs.winehq.org/show_bug.cgi?id=30752
--- Comment #1 from Jay Yang jkelleyy@gmail.com 2012-05-22 16:25:18 CDT --- I originally submitted this patch to fixed a similar issue with SHFileOperation. I originally asked about this here http://www.winehq.org/pipermail/wine-devel/2011-June/090783.html . The core of the issue is that SHFileOperation notifies on unixfs PIDLs even when given a path like C:. And for whatever reason, it was impractical to try to get it a PIDL rooted in My Computer (can't quite remember what made it hard).
I could take another look at trying to convince SHFileOperation to notify on PIDLs rooted in My Computer. Or I could see if it is possible to rewrite the copy paste stuff I did last summer to use something other than SHFileOperation, which was probably not the best interface to use since it uses file names rather than PIDLs. Although since I had a hard time trying to do these last summer, I can't imagine it would be an easy fix.
In the end, it seems like it's best to have the shell view call SHChangeNotifyRegister with the PIDLs rooted in My Computer after all. But if we change it now, I think we will break notifications for copy and paste. It might be worthwhile to commit some tests though.
https://bugs.winehq.org/show_bug.cgi?id=30752
--- Comment #2 from Austin English austinenglish@gmail.com --- This is your friendly reminder that there has been no bug activity for two years. Is this still an issue in current (1.7.25 or newer) wine?
https://bugs.winehq.org/show_bug.cgi?id=30752
--- Comment #3 from Andrew Eikum aeikum@codeweavers.com --- Yep, still present in 1.7.25.
https://bugs.winehq.org/show_bug.cgi?id=30752
--- Comment #4 from Austin English austinenglish@gmail.com --- This is your friendly reminder that there has been no bug activity for over a year. Is this still an issue in current (1.7.51 or newer) wine?
https://bugs.winehq.org/show_bug.cgi?id=30752
--- Comment #5 from Andrew Eikum aeikum@codeweavers.com --- Still present in 1.7.55.
https://bugs.winehq.org/show_bug.cgi?id=30752
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4@web.de
--- Comment #6 from Fabian Maurer dark.shadow4@web.de --- Is this still an issue with wine 2.16?
https://bugs.winehq.org/show_bug.cgi?id=30752
Alistair Leslie-Hughes leslie_alistair@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |leslie_alistair@hotmail.com
--- Comment #7 from Alistair Leslie-Hughes leslie_alistair@hotmail.com --- The issue is still present. Here is the easiest test case
wine notepad Menu "File -> Open" select "My Computer" select "C:" select temp (or another folder) Click "New Folder"
Using the Previous saved location or "My Document" wont reproduce the issue.
https://bugs.winehq.org/show_bug.cgi?id=30752
--- Comment #8 from Fabian Maurer dark.shadow4@web.de --- Still present in wine-3.21
https://bugs.winehq.org/show_bug.cgi?id=30752
joaopa jeremielapuree@yahoo.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree@yahoo.fr
--- Comment #9 from joaopa jeremielapuree@yahoo.fr --- Bug still occurs with wine-4.20
https://bugs.winehq.org/show_bug.cgi?id=30752
Gautam Agrawal gautamnagrawal@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gautamnagrawal@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=30752
--- Comment #10 from joaopa jeremielapuree@yahoo.fr --- Looks like this bug is fixed with wine-7.0-rc2, isn't it?
https://bugs.winehq.org/show_bug.cgi?id=30752
Andrew Eikum aeikum@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED
--- Comment #11 from Andrew Eikum aeikum@codeweavers.com --- Yes! I confirmed it was broken in Wine 6.0 and is fixed in 7.0-rc3. I don't know what commit fixed it.
https://bugs.winehq.org/show_bug.cgi?id=30752
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #12 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 7.0-rc4.
-
wine-bugs＠winehq.org -
WineHQ Bugzilla