[Bug 24738] New: pdfedit crashes (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=24738

Summary: pdfedit crashes (dogfood)
           Product: Wine
           Version: 1.3.2
          Platform: x86
               URL: http://www.cadkas.com/pdfedit!.exe
        OS/Version: Linux
            Status: NEW
          Keywords: download
          Severity: normal
          Priority: P2
         Component: ntdll
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

The program crashes on start with:
err:seh:setup_exception_record stack overflow 880 bytes in thread 0009 eip
685caf82 esp 00230fc0 stack 0x230000-0x231000-0x330000

A relay log shows a million of calls to NtQuerySystemInformation just before
this happens.

A stupid hack like below makes the application start fine. So something must be
unexpectedly be delivered by NtQuerySystemInformation which makes pdfedit
unhappy

diff --git a/dlls/ntdll/nt.c b/dlls/ntdll/nt.c
index b323c23..e89df02 100644
--- a/dlls/ntdll/nt.c
+++ b/dlls/ntdll/nt.c
@@ -1321,7 +1321,7 @@ NTSTATUS WINAPI NtQuerySystemInformation(
        OUT PVOID SystemInformation,
        IN ULONG Length,
        OUT PULONG ResultLength)
-{
+{return E_NOTIMPL;
     NTSTATUS    ret = STATUS_SUCCESS;
     ULONG       len = 0;

[Bug 24738] pdfedit crashes (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=24738

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|ntdll                       |-unknown

--- Comment #1 from Dmitry Timoshkov  2010-10-14 04:17:00 CDT ---
Likely not a ntdll bug.

[Bug 24738] pdfedit crashes (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=24738

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Jerome Leclanche  2010-10-14 07:46:15 CDT ---
Dupe of bug 23965 ?

[Bug 24738] pdfedit crashes (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=24738

--- Comment #3 from Andrew Nguyen  2010-10-16 01:20:20 CDT ---
Created an attachment (id=31289)
 --> (http://bugs.winehq.org/attachment.cgi?id=31289)
ntdll: Initialize the IdleTime member of SYSTEM_PERFORMANCE_INFORMATION to a
non-zero value.

(In reply to comment #2)
> Dupe of bug 23965 ?

Probably not. I don't recall Steam asking for SystemPerformanceInformation
class from NtQuerySystemInformation when trying to display system information.

PDFEdit seems to expect the IdleTime member of SYSTEM_PERFORMANCE_INFORMATION
to be non-zero; otherwise, it continues its information query loop and
eventually incurs a stack overflow. I think the attached patch should resolve
the issue.

[Bug 24738] pdfedit crashes (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=24738

Andrew Nguyen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |ntdll

--- Comment #4 from Andrew Nguyen  2010-10-16 01:27:00 CDT ---
Changing component as it does seem to be an ntdll problem after all.

[Bug 24738] pdfedit crashes (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=24738

--- Comment #5 from Jerome Leclanche  2010-10-16 01:34:30 CDT ---
(In reply to comment #4)
> Changing component as it does seem to be an ntdll problem after all.

For the record, the patch doesn't fix the steam issue.

[Bug 24738] pdfedit crashes (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=24738

--- Comment #6 from Louis Lenders  2010-10-16 05:15:33 CDT ---
(In reply to comment #3)
> Created an attachment (id=31289)

--> (http://bugs.winehq.org/attachment.cgi?id=31289) [details]
> ntdll: Initialize the IdleTime member of SYSTEM_PERFORMANCE_INFORMATION to a
> non-zero value.

Hi Andrew, thanks for looking into this. If IdleTime is the problem, then  I
created probably a duplicate of http://bugs.winehq.org/show_bug.cgi?id=18705 ?
That bug is some interisting remarks aboutr this issue as well

[Bug 24738] pdfedit crashes (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=24738

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |DUPLICATE

--- Comment #7 from Louis Lenders  2010-11-19 12:22:50 CST ---
i've send a patch here
http://www.winehq.org/pipermail/wine-patches/attachments/20101119/8102c33e/a...
but actually this is a duplicate of
http://bugs.winehq.org/show_bug.cgi?id=18705

*** This bug has been marked as a duplicate of bug 18705 ***

[Bug 24738] pdfedit crashes (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=24738

--- Comment #8 from Louis Lenders  2010-11-19 12:23:23 CST ---
closing duplicate

[Bug 24738] pdfedit crashes (dogfood)

http://bugs.winehq.org/show_bug.cgi?id=24738

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Louis Lenders  2010-11-19 12:25:22 CST ---
now really closing