[Bug 30056] New: Feature request: Graphical scaler algorithms

http://bugs.winehq.org/show_bug.cgi?id=30056

Bug #: 30056
           Summary: Feature request: Graphical scaler algorithms
           Product: Wine
           Version: unspecified
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: gdi32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Projects like DosBOX or ScummVM allow choosing a scaler algorithm which
increases the size of fixed resolution games with beautiful results. Here's a
nice comparison picture of one of the algorithms:
http://en.wikipedia.org/wiki/Hqx

I'm aware that this slows Wine down as long as the feature is activated, but
this is only used for very old games anyway (newer ones run on different
resolutions anyway) with no 3D, like "classic" RPGs. Since this is not a
problem on modern PCs with e.g. DosBOX I thought this would be a very nice
addition for Wine as well.

What do you think?

[Bug 30056] Feature request: Graphical scaler algorithms

http://bugs.winehq.org/show_bug.cgi?id=30056

A. Fischl  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andreas.r.fischl.work@gmail
                   |                            |.com

[Bug 30056] Feature request: Graphical scaler algorithms

http://bugs.winehq.org/show_bug.cgi?id=30056

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 30056] Feature request: Graphical scaler algorithms

http://bugs.winehq.org/show_bug.cgi?id=30056

--- Comment #1 from Nikolay Sivov  2012-03-02 03:10:09 CST ---
I guess if Windows doesn't support that wine's gdi32 shouldn't try to do such
scaling interpolation. Application should implement this if it's needed.

[Bug 30056] Feature request: Graphical scaler algorithms

http://bugs.winehq.org/show_bug.cgi?id=30056

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|andreas.r.fischl.work@gmail |
                   |.com                        |
          Component|gdi32                       |-unknown

--- Comment #2 from Dmitry Timoshkov  2012-03-02 03:17:46 CST ---
This has nothing to do with gdi32, there are other ways to draw things.

[Bug 30056] Feature request: Graphical scaler algorithms

http://bugs.winehq.org/show_bug.cgi?id=30056

--- Comment #3 from Austin English  2012-03-02 13:08:03 CST ---
Well, the plan is to use DosBOX for DOS executables anyway..

[Bug 30056] Feature request: Graphical scaler algorithms

http://bugs.winehq.org/show_bug.cgi?id=30056

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |1.4-rc5

--- Comment #4 from Dmitry Timoshkov  2012-03-02 20:09:10 CST ---
Most likely a WONTFIX.

[Bug 30056] Feature request: Graphical scaler algorithms

http://bugs.winehq.org/show_bug.cgi?id=30056

--- Comment #5 from A. Fischl  2012-03-06 05:14:41 CST ---
DosBOX is for DOS applications, but there are nevertheless Windows games which
run only on 640x480 and obviously won't run in DosBOX.

[Bug 30056] Feature request: Graphical scaler algorithms

http://bugs.winehq.org/show_bug.cgi?id=30056

--- Comment #6 from Dmitry Timoshkov  2012-03-06 06:05:31 CST ---
(In reply to comment #5)
> DosBOX is for DOS applications, but there are nevertheless Windows games which
> run only on 640x480 and obviously won't run in DosBOX.

If the app doesn't change the screen resolution on its own what's wrong with

xrandr -s 640x480
wine your_old_game.exe
xrandr -s your_preferred_resulurion

?

[Bug 30056] Feature request: Graphical scaler algorithms

http://bugs.winehq.org/show_bug.cgi?id=30056

--- Comment #7 from A. Fischl  2012-03-07 02:34:51 CST ---
Have you taken a look at the link I posted above, Dmitry? There you'll see that
the point of the scalers (and that's why DosBOX and ScummVM have integrated
them) is that it looks great on large monitors.

Without it there are two options, both not desirable:
Either the original resolution is too tiny on modern LCDs
or enlarge it which makes it look extraordinarily pixelated.

Please take a second and look at the comparison picture I posted above.

[Bug 30056] Feature request: Graphical scaler algorithms

http://bugs.winehq.org/show_bug.cgi?id=30056

--- Comment #8 from Dmitry Timoshkov  2012-03-07 03:13:30 CST ---
(In reply to comment #7)
> Have you taken a look at the link I posted above, Dmitry? There you'll see that
> the point of the scalers (and that's why DosBOX and ScummVM have integrated
> them) is that it looks great on large monitors.

Both of them are emulators, and are able to scale the final picture unlike
Wine. You'll get better results with VNC or a dedicated X11 server.

[Bug 30056] Feature request: Graphical scaler algorithms

http://bugs.winehq.org/show_bug.cgi?id=30056

--- Comment #9 from A. Fischl  2012-03-07 13:09:09 CST ---
I admit that I haven't considered VNC or X11 for scaling. Nevertheless, the
problem just shifts from Wine not having an good scaling algorithm to a VNC
client not having a good scaling algorithm (they just use a larger box of
same-colored pixels for one original pixel, just like a LCD does when
upscaling).

You already mentioned that the GDI32 component is not the place for this to be
done. Is there another component which is more suited for this kind of work?
Like directx-d3d?

[Bug 30056] Feature request: Graphical scaler algorithms

http://bugs.winehq.org/show_bug.cgi?id=30056

--- Comment #10 from Dmitry Timoshkov  2012-03-07 23:07:34 CST ---
(In reply to comment #9)
> I admit that I haven't considered VNC or X11 for scaling. Nevertheless, the
> problem just shifts from Wine not having an good scaling algorithm to a VNC
> client not having a good scaling algorithm (they just use a larger box of
> same-colored pixels for one original pixel, just like a LCD does when
> upscaling).

Doing it badly is still better than doing nothing, it's the first step to do
what you want. Now just file a feature request at the proper project bugzilla.
> You already mentioned that the GDI32 component is not the place for this to be
> done. Is there another component which is more suited for this kind of work?
> Like directx-d3d?

No, "there are other ways to draw things." And Wine doesn't have a final
frame buffer picture to work on/scale in the first place. Wine does draw
on the screen via distinct API calls, drawing a line, an icon, a font glyph,
a curve, etc. at a time.

As I already said, most likely a WONTFIX.

[Bug 30056] Feature request: Graphical scaler algorithms

https://bugs.winehq.org/show_bug.cgi?id=30056

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #11 from Austin English  ---
(In reply to Dmitry Timoshkov from comment #10)
> (In reply to comment #9)
> > I admit that I haven't considered VNC or X11 for scaling. Nevertheless, the
> > problem just shifts from Wine not having an good scaling algorithm to a VNC
> > client not having a good scaling algorithm (they just use a larger box of
> > same-colored pixels for one original pixel, just like a LCD does when
> > upscaling).
>
> Doing it badly is still better than doing nothing, it's the first step to do
> what you want. Now just file a feature request at the proper project
> bugzilla.
> > You already mentioned that the GDI32 component is not the place for this to be
> > done. Is there another component which is more suited for this kind of work?
> > Like directx-d3d?
>
> No, "there are other ways to draw things." And Wine doesn't have a final
> frame buffer picture to work on/scale in the first place. Wine does draw
> on the screen via distinct API calls, drawing a line, an icon, a font glyph,
> a curve, etc. at a time.
>
> As I already said, most likely a WONTFIX.

Agreed.

[Bug 30056] Feature request: Graphical scaler algorithms

http://bugs.winehq.org/show_bug.cgi?id=30056

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Bruno Jesus  ---
Closing WONTFIX bugs.