http://bugs.winehq.org/show_bug.cgi?id=32314
Bug #: 32314 Summary: Pikachu Volleyball (English version) crashes on restart Product: Wine Version: 1.5.18 Platform: x86-64 URL: http://games.hotut.com/post/pikachu-volleyball/ OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: winmm&mci AssignedTo: wine-bugs@winehq.org ReportedBy: RandomAccountName@mail.com Classification: Unclassified Regression SHA1: 010019df064cfe1e9efee5ac6ee9e1e0954bd4f8
Created attachment 42654 --> http://bugs.winehq.org/attachment.cgi?id=42654 Terminal output
The English version of Pikachu Volleyball crashes if restarted after the beginning of a round. (No problem with the original Japanese version.) To reproduce:
- Start a game with either option at the title screen - Click Game -> Restart
It also restarts (and crashes) automatically at the end of the round.
Regression testing indicated: 010019df064cfe1e9efee5ac6ee9e1e0954bd4f8 is the first bad commit commit 010019df064cfe1e9efee5ac6ee9e1e0954bd4f8 Author: Jörg Höhle Joerg-Cyril.Hoehle@t-systems.com Date: Thu Oct 4 12:34:07 2012 +0200
mciseq: Create player thread in the synchronous case too.
:040000 040000 4fecac2de61d692b36b829591062060ce25e861b 66bc6ddfb6dd3eddd0179ac2c98e887a3046dd31 M dlls
Reverting that patch prevented the crash.
http://bugs.winehq.org/show_bug.cgi?id=32314
A Wine user RandomAccountName@mail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression CC| |hoehle@users.sourceforge.ne | |t
http://bugs.winehq.org/show_bug.cgi?id=32314
--- Comment #1 from Jörg Höhle hoehle@users.sourceforge.net 2012-12-07 14:52:43 CST --- The original Japanese pikachu is not affected because it uses the winmm:midiStream API, while the English versions uses the MCI sequencer.
It was not a good idea of Alexandre Julliard to stop applying my mciseq patch series after patch #6 this October. http://www.winehq.org/pipermail/wine-patches/2012-October/thread.html
The sequence was never expected to stop at patch #6. The only cut point that I defined was after patch #12, as I wrote in: http://www.winehq.org/pipermail/wine-patches/2012-October/118516.html
The set 2-12 implements the new thread design. It will be enough to fix e.g. bug #22978. The rest [...]
I pinpointed this particular problem in patch #4 (applied):
Waiting for the thread to finish guarantees that at CLOSE time, we can reliably shut down and free resources. That cannot be achieved with a final SetEvent from within the player thread: the driver could then exit while the player thread (is waiting to or) performs its last instructions.
That issue (which has always been present, just made worse with patch #4) was to be fixed only with patch #9: [PATCH 09/25] mciseq: Make sure MCI_WAIT waits for the player to terminate.
So all that's needed is to come to an agreement on the single writer - multiple reader threads protocol.
http://bugs.winehq.org/show_bug.cgi?id=32314
Brandon Corujo haku08879@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |haku08879@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=32314
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1
--- Comment #2 from Austin English austinenglish@gmail.com --- Still in 1.7.30.
bash-4.3$ sha1sum pikachuball.zip 8ee9de1a9e668aa7e0ab4503009682a294f0c238 pikachuball.zip bash-4.3$ du -h pikachuball.zip 152K pikachuball.zip bash-4.3$ wine --version wine-1.7.30
https://bugs.winehq.org/show_bug.cgi?id=32314
Béla Gyebrószki gyebro69@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.winehq.org/sho | |w_bug.cgi?id=34422
https://bugs.winehq.org/show_bug.cgi?id=32314
--- Comment #3 from Bruno Jesus 00cpxxx@gmail.com --- Seems fixed in 1.7.51, but I'm no longer able to reproduce in wine 1.6 so I guess my test is not valid. Can anyone else retest? I tested with the same version as Austin.
https://bugs.winehq.org/show_bug.cgi?id=32314
A Wine user RandomAccountName@mail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #4 from A Wine user RandomAccountName@mail.com --- It's no longer crashing for me with wine-1.9.5-198-gbd332f5.
https://bugs.winehq.org/show_bug.cgi?id=32314
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #5 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.9.6.
-
wine-bugs＠winehq.org