[Bug 18786] New: Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

Summary: Minitab doesn't run anymore
           Product: Wine
           Version: 1.1.22
          Platform: PC-x86-64
               URL: http://www.minitab.com
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

According to the App DB, Minitab 15.1 and Minitab 14.1 can be run with wine
0.9.54 or 0.9.55, installing dcom98 but it doesn't help anymore, in fact if you
install it then would not be able to install neither Minitab 14.1 nor Minitab
15.1. Both versions of Minitab install successfully with default settings but
they can't be run in any way. For Minitab 15.1 an error window from HASP
Alladin software is shown. This is a regression since it was possible to make
this two applications be run in an older version of wine.

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

--- Comment #1 from Jeff Zaroyko   2009-06-04 19:53:26 ---
please results of your regression test http://wiki.winehq.org/RegressionTesting

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|http://www.minitab.com      |http://fs1.minitab.com/stor
                   |                            |e/mtb15_standardsetup.exe

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

--- Comment #2 from Andrew Nguyen   2009-06-05 23:56:49 ---
The regression test revealed the bad commit to be:

c1f161a678e75f12b9378df9fba7a951c39cf242 is first bad commit
commit c1f161a678e75f12b9378df9fba7a951c39cf242
Author: Guy Albertelli 
Date:   Sat May 23 23:45:07 2009 -0400

kernel32: Fix GetVolumeNameForVolumeMountPointW to match Mountmgr.

:040000 040000 19963a8213130782cb1388f077a09d62ca43902d
5ae06759dedd15e4c6c20142e0d1e6502e84fc73 M    dlls

Building from the commit prior to c1f161a678e75f12b9378df9fba7a951c39cf242
allows the application to start. Unfortunately, I'm unable to CC the commit
e-mail address.

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #3 from Ken Sharp   2009-06-06 05:30:57 ---
Doesn't look like Guy Albertelli is in Bugzilla.  You could send him a nice
email?

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

Guy Albertelli  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Guy Albertelli   2009-06-06 19:48:28 ---
(In reply to comment #2)
Andrew, it sounds like you have this program installed. If so could you attach
a WINEDEBUG=+volume,+mountmgr listing?

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

--- Comment #5 from Andrew Nguyen   2009-06-07 11:29:28 ---
Created an attachment (id=21625)
 --> (http://bugs.winehq.org/attachment.cgi?id=21625)
MINITAB 15 +volume,+mountmgr trace

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

--- Comment #6 from Guy Albertelli   2009-06-07 22:08:22 ---
Thanks for the trace log.

I have found and downloaded a trial verison of Minitab 15.  Agree it fails with
that patch and that it works on 0.9.55.

However on my system wine-1.1.10 and wine-1.1.5 also fail while wine-1.0 works.
Running a bisect now.

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

--- Comment #7 from Guy Albertelli   2009-06-08 21:51:53 ---
The git-bisect on my system says that this commit is the first bad commit:
3aa93652a48cd82abfc135a76031732ea45daedd is first bad commit
commit 3aa93652a48cd82abfc135a76031732ea45daedd
Author: Juan Lang 
Date:   Wed Jun 25 09:27:53 2008 -0700

inetmib1: Use a helper function to get the item and instance of the MIB2
interface table.

:040000 040000 b5098bbc664d3ba8c03a71de5e1aad13b57d27a6
f4cb7654b7a2104361e1d9272d748d0da21fc21f M    dlls

Note that this commit is between wine-1.0 and wine-1.1.0

Will try backing that patch out.

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

--- Comment #8 from Guy Albertelli   2009-06-10 06:21:25 ---
Created an attachment (id=21715)
 --> (http://bugs.winehq.org/attachment.cgi?id=21715)
MINITAB regression patch

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

--- Comment #9 from Guy Albertelli   2009-06-10 06:26:15 ---
The attach patch allow MINITAB to run with the rest of the first bad commit
applied.  It also seems to restore the intent of the original code prior to
committed patch.

However this code is completely out of my area of experience.  Can anyone else
check this??

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

--- Comment #10 from Mitchell Velasquez   2009-06-13 11:15:10 ---
Did anybody check this? there have not been more comments at this respect.
I'd really like to help testing the patch provided by Guy, but I don't know
how. Can anyone give me some guidance? or tell me how can I help? I'm very
interested in fixing this bug.

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

--- Comment #11 from Austin English   2009-06-13 14:14:57 ---
(In reply to comment #10)
> Did anybody check this? there have not been more comments at this respect.
> I'd really like to help testing the patch provided by Guy, but I don't know
> how. Can anyone give me some guidance? or tell me how can I help? I'm very
> interested in fixing this bug.

http://wiki.winehq.org/Patching

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

Saulius K.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

--- Comment #12 from Juan Lang   2009-06-17 10:51:20 ---
(In reply to comment #10)
> Did anybody check this? there have not been more comments at this respect.

I replied on wine-devel:
http://www.winehq.org/pipermail/wine-devel/2009-June/076562.html

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

--- Comment #13 from Guy Albertelli   2009-06-18 19:51:01 ---
Created an attachment (id=21880)
 --> (http://bugs.winehq.org/attachment.cgi?id=21880)
Partial trace with git code and program failing with notes

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

--- Comment #14 from Guy Albertelli   2009-06-18 19:51:50 ---
Created an attachment (id=21881)
 --> (http://bugs.winehq.org/attachment.cgi?id=21881)
Partial trace with regression patch of program

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

--- Comment #15 from Guy Albertelli   2009-06-18 19:53:00 ---
Created an attachment (id=21882)
 --> (http://bugs.winehq.org/attachment.cgi?id=21882)
Patch used for logs

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

--- Comment #16 from Guy Albertelli   2009-06-18 19:53:53 ---
Created an attachment (id=21883)
 --> (http://bugs.winehq.org/attachment.cgi?id=21883)
Complete log of git code and program failing

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

--- Comment #17 from Guy Albertelli   2009-06-18 19:54:55 ---
Created an attachment (id=21884)
 --> (http://bugs.winehq.org/attachment.cgi?id=21884)
Complete log of revert code with program working

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

--- Comment #18 from Guy Albertelli   2009-06-18 19:58:43 ---
Juan,

The two partial traces should be what you want.  MINITAB deviates after the
SnmpExtenstionQuery loop.  The current git code ends up supplying
ERROR_NO_MORE_ITEMS and then starts dying with RtlUnwind.

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21880|application/octet-stream    |text/plain
          mime type|                            |

--- Comment #18 from Guy Albertelli   2009-06-18 19:58:43 ---
Juan,

The two partial traces should be what you want.  MINITAB deviates after the
SnmpExtenstionQuery loop.  The current git code ends up supplying
ERROR_NO_MORE_ITEMS and then starts dying with RtlUnwind.

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21881|application/octet-stream    |text/plain
          mime type|                            |

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

--- Comment #19 from Juan Lang   2009-06-26 11:44:46 ---
Hi Guy, I've taken a look at the two logs, and the code.

I agree that the logs are different, but I think the code is more correct as it
is than it was before.  For example, in the current git with your trace patch
applied, the first call to SnmpExtensionQuery is:

0009:Call inetmib1.SnmpExtensionQuery(000000a1,0032f89c,0032f874,0032f878)
ret=65024e7f
trace:inetmib1:SnmpExtensionQuery (0xa1, 0x32f89c, 0x32f874, 0x32f878)
trace:snmpapi:SnmpUtilOidNCmp (0x32f674, 0x32f590, 6)
trace:snmpapi:SnmpUtilOidToA (0x32f674)
trace:snmpapi:SnmpUtilIdsToA (0x15a3d0, 11)
trace:inetmib1:SnmpExtensionQuery 1.3.6.1.2.1.2.2.1.3.1

This is a call to get the interface type of the first interface in the system. 
1.3.6.1.2.1.2.2.1.3 is the MIB2 OID for ifType, and 1 refers to the first
instance.

You then point out:
trace:inetmib1:mib2IfEntryQuery (0xa1, 1.3.6.1.2.1.2.2.1.6.1, 0x32f598)
trace:snmpapi:SnmpUtilOidNCmp (0x32f68c, 0x32f4e8, 9)
trace:snmpapi:SnmpUtilOidNCmp (0x32f68c, 0x32f4e8, 9)
err:inetmib1:getItemAndIntegerInstanceFromOid git code *item=6

*** first difference

trace:snmpapi:SnmpUtilAsnAnyCpy (0x32f694, 0x32f474)

In fact, the instance *should* be 6, and the item should be 1.  So I don't see
what the problem is.  In this case, the application is querying for the MAC
address of the first interface in the system.  1.3.6.1.2.1.2.2.1.6 is the MIB2
definition of ifPhysAddress, and 1 refers to the first instance.

Later you point out:
*** note repeated call to SnmpExtensionQuery

0009:Call inetmib1.SnmpExtensionQuery(000000a1,0032f89c,0032f874,0032f878)
ret=65024e7f
trace:inetmib1:SnmpExtensionQuery (0xa1, 0x32f89c, 0x32f874, 0x32f878)
trace:snmpapi:SnmpUtilOidNCmp (0x32f674, 0x32f590, 6)
trace:snmpapi:SnmpUtilOidToA (0x32f674)
trace:snmpapi:SnmpUtilIdsToA (0x15a3d0, 11)
trace:inetmib1:SnmpExtensionQuery 1.3.6.1.2.1.2.2.1.3.2

This is a call to retrieve a different OID, 1.3.6.1.2.1.2.2.1.3.2.  This is the
ifType of the second interface in the system.  Again, 1.3.6.1.2.1.2.2.1.3 is
the ifType, and now 2 refers to the second instance.  Immediately after this,
unsurprisingly, the app queries the MAC address of the second interface, with:
trace:inetmib1:SnmpExtensionQuery 1.3.6.1.2.1.2.2.1.6.2

So this looks correct to me.

You also point out:
009:Call KERNEL32.GetLastError() ret=6504065b

*** !!!!! note error  ERROR_NO_MORE_ITEMS

0009:Ret  KERNEL32.GetLastError() retval=00000103 ret=6504065b

Sure, okay, but that isn't set by inetmib1.  You should see where that's coming
from, as that's a more likely source of the problem that inetmib1.  That is,
inetmib1 appears to have been buggy before, and now it shows a bug elsewhere.

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #20 from Jerome Leclanche   2009-12-01 11:49:10 ---
Still an issue in wine-1.1.33-553-g77d5852.

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21715|0                           |1
        is obsolete|                            |

--- Comment #21 from Juan Lang   2009-12-07 15:28:14 ---
(From update of attachment 21715)
As I commented before, this patch is incorrect.  I've sent (correct) patches
which fix it:
http://www.winehq.org/pipermail/wine-patches/2009-December/082383.html
http://www.winehq.org/pipermail/wine-patches/2009-December/082384.html

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #22 from Juan Lang   2009-12-08 11:14:16 ---
Fixed by commit 91d62162da316f7a25781ea1a88460aa237a116b.

[Bug 18786] Minitab doesn't run anymore

http://bugs.winehq.org/show_bug.cgi?id=18786

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #23 from Alexandre Julliard   2009-12-18 13:07:37 ---
Closing bugs fixed in 1.1.35.